Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\))
Subject: Re: [PATCH 3/7] reset: add BCM6345 reset controller driver
From:   =?utf-8?Q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= <noltari@gmail.com>
In-Reply-To: <e80e5c4c-ceef-3a62-3158-02f742bf76b7@gmail.com>
Date:   Wed, 10 Jun 2020 08:08:37 +0200
Cc:     Philipp Zabel <p.zabel@pengutronix.de>, robh+dt@kernel.org,
        tsbogend@alpha.franken.de, Jonas Gorski <jonas.gorski@gmail.com>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-mips@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com
Content-Transfer-Encoding: quoted-printable
Message-Id: <41A1CC01-BFA0-48A1-A2EE-7917B3A1323A@gmail.com>
References: <20200609134232.4084718-1-noltari@gmail.com>
 <20200609134232.4084718-4-noltari@gmail.com>
 <341e8482c6bd06267633160d7358fa8331bef515.camel@pengutronix.de>
 <729976E9-CAF7-47B6-8783-5FD3D85F9EFD@gmail.com>
 <2a621f170574a616bcf047f6725c74552f7abbb1.camel@pengutronix.de>
 <46614E69-578A-4782-9D72-85B2D2F38FB8@gmail.com>
 <e80e5c4c-ceef-3a62-3158-02f742bf76b7@gmail.com>
To:     Florian Fainelli <f.fainelli@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Florian,

> El 9 jun 2020, a las 22:17, Florian Fainelli <f.fainelli@gmail.com> =
escribi=C3=B3:
>=20
>=20
>=20
> On 6/9/2020 9:41 AM, =C3=81lvaro Fern=C3=A1ndez Rojas wrote:
>>>>> If you can do without this, with I think this driver could be made =
to
>>>>> use reset-simple.
>>>>=20
>>>> Yes, but only if I can add reset support with a configurable sleep =
range to reset-simple. Is this possible?
>>>=20
>>> I should have mentioned, support for this is on the reset/next =
branch:
>>>=20
>>> git://git.pengutronix.de/pza/linux.git reset/next
>>=20
>> Yes, but reset_us was only added to reset_simple_data, so there=E2=80=99=
s no way to fill that value from reset_simple_devdata or device tree, =
right?
>=20
> Not that I can see, but you could certainly extend it here:
>=20
> if (devdata) {
> 		reg_offset =3D devdata->reg_offset;
> 		if (devdata->nr_resets)
> 			data->rcdev.nr_resets =3D devdata->nr_resets;
> 		data->active_low =3D devdata->active_low;
> 		data->status_active_low =3D devdata->status_active_low;
> 	}

Yes, I would extend it there too, but I was just saying that it=E2=80=99s =
a bit strange that it was only added to reset_simple_data without any =
way to fill the value.

>=20
> and have an appropriate devdata structure be provided for your
> compatible string:
>=20
> +	{ .compatible =3D "brcm,bcm6345-reset", .data =3D =
bcm6345_reset_devdata },
> --=20
> Florian

Regards,
=C3=81lvaro.=