Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\))
Subject: Re: [PATCH 2/2] clk: bcm63xx-gate: add BCM6318 support
From:   =?utf-8?Q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= <noltari@gmail.com>
In-Reply-To: <1367fcf3-24ed-9106-a329-da5f8e168e17@gmail.com>
Date:   Wed, 10 Jun 2020 08:12:53 +0200
Cc:     mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org,
        bcm-kernel-feedback-list@broadcom.com, julia.lawall@lip6.fr,
        f4bug@amsat.org, jonas.gorski@gmail.com, lkp@intel.com,
        linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <3E897527-55EB-47DB-99ED-C737725F0F9E@gmail.com>
References: <20200609113049.4035426-1-noltari@gmail.com>
 <20200609113049.4035426-3-noltari@gmail.com>
 <1367fcf3-24ed-9106-a329-da5f8e168e17@gmail.com>
To:     Florian Fainelli <f.fainelli@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Florian,

> El 10 jun 2020, a las 4:27, Florian Fainelli <f.fainelli@gmail.com> =
escribi=C3=B3:
>=20
>=20
>=20
> On 6/9/2020 4:30 AM, =C3=81lvaro Fern=C3=A1ndez Rojas wrote:
>> +static const struct clk_bcm63xx_table_entry bcm6318_clocks[] =3D {
>> +	{ .name =3D "adsl_asb", .bit =3D 0, },
>> +	{ .name =3D "usb_asb", .bit =3D 1, },
>> +	{ .name =3D "mips_asb", .bit =3D 2, },
>> +	{ .name =3D "pcie_asb", .bit =3D 3, },
>> +	{ .name =3D "phymips_asb", .bit =3D 4, },
>> +	{ .name =3D "robosw_asb", .bit =3D 5, },
>> +	{ .name =3D "sar_asb", .bit =3D 6, },
>> +	{ .name =3D "sdr_asb", .bit =3D 7, },
>> +	{ .name =3D "swreg_asb", .bit =3D 8, },
>> +	{ .name =3D "periph_asb", .bit =3D 9, },
>> +	{ .name =3D "cpubus160", .bit =3D 10, },
>> +	{ .name =3D "adsl", .bit =3D 11, },
>> +	{ .name =3D "sar124", .bit =3D 12, },
>=20
> Nit: this should be sar125

Nice catch, I will fix this in v2.

>=20
>> +	{ .name =3D "mips", .bit =3D 13, .flags =3D CLK_IS_CRITICAL, },
>> +	{ .name =3D "pcie", .bit =3D 14, },
>> +	{ .name =3D "robosw250", .bit =3D 16, },
>> +	{ .name =3D "robosw025", .bit =3D 17, },
>> +	{ .name =3D "sdr", .bit =3D 19, .flags =3D CLK_IS_CRITICAL, },
>> +	{ .name =3D "usb", .bit =3D 20, },
>=20
> This should probably be "usbd" to indicate this is the USB device =
clock
> (not host)

Ok, I will change it. I got confused by the fact that both (usbd and =
usbh) were present on 6318_map_part.h:
#define USBD_CLK_EN         (1 << 20)
#define USBH_CLK_EN         (1 << 20)

>=20
> With that fixed:
>=20
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> --=20
> Florian