Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: rllLeGfDrujFXpTuS/nn3TJFIhmvXpZsJuedEUMPH9eYqpfr/Dv4ij4p0ZhYfTXjVt7kbP5VuR
 jZ+re8MzWnuYoQrVu3+l43CpUWyPcnOQGQTgGg37re2SDd0gqGX58MKn/pY43p3Bnc4zMxz32X
 gJzRZN4v2QKEk5iNTUaNFOh9S8ORu3p+GPuqrV5Vz7HHj0jNTxIzRURqlbAv3Z71YiP2u0xiy6
 dgnNhqF3iUlWcSW3OlMPGImPM/nlPeMktqJFm6DL0/6Kvr0/SGkMU8MzMOvKoVNVXu1ugSKNPt
 NEI=
From:   Avri Altman <Avri.Altman@wdc.com>
To:     "Martin K. Petersen" <martin.petersen@oracle.com>
CC:     "kjlu@umn.edu" <kjlu@umn.edu>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        Bean Huo <beanhuo@micron.com>,
        Bart Van Assche <bvanassche@acm.org>,
        Can Guo <cang@codeaurora.org>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Dinghao Liu <dinghao.liu@zju.edu.cn>
Subject: RE: [PATCH] scsi: ufs-bsg: Fix runtime PM imbalance on error
Thread-Topic: [PATCH] scsi: ufs-bsg: Fix runtime PM imbalance on error
Thread-Index: AQHWPsyO1tMSQcTvHEyUblbEcRc526jRb/8Q
Date:   Wed, 10 Jun 2020 07:16:31 +0000
Message-ID: <SN6PR04MB464040E5275E7F5C28CFB9E9FC830@SN6PR04MB4640.namprd04.prod.outlook.com>
References: <20200522045932.31795-1-dinghao.liu@zju.edu.cn>
 <yq1k10fsmaj.fsf@ca-mkp.ca.oracle.com>
In-Reply-To: <yq1k10fsmaj.fsf@ca-mkp.ca.oracle.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 54beff7a-faa4-4992-fd07-08d80d0e33c5
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jun 2020 07:16:31.9863
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: LTaJgzcYCY0IVh8AQJT4YSRQjBNcc/jaFPmAk20mwAkbdXv7CK9dcmC8mOQvLBKdPC4ScWAOkDS3zr6yPCua2g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR04MB4400
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,
=20
> Avri: Please review!
>=20
> > When ufs_bsg_alloc_desc_buffer() returns an error code,
> > a pairing runtime PM usage counter decrement is needed
> > to keep the counter balanced.
> >
> > Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Please add:
Fixes: 74e5e468b664 (scsi: ufs-bsg: Wake the device before sending raw upiu=
 commands)

Reviewed-by: Avri Altman <avri.altman@wdc.com>

Thanks,
Avri

> > ---
> >  drivers/scsi/ufs/ufs_bsg.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/scsi/ufs/ufs_bsg.c b/drivers/scsi/ufs/ufs_bsg.c
> > index 53dd87628cbe..516a7f573942 100644
> > --- a/drivers/scsi/ufs/ufs_bsg.c
> > +++ b/drivers/scsi/ufs/ufs_bsg.c
> > @@ -106,8 +106,10 @@ static int ufs_bsg_request(struct bsg_job *job)
> >               desc_op =3D bsg_request->upiu_req.qr.opcode;
> >               ret =3D ufs_bsg_alloc_desc_buffer(hba, job, &desc_buff,
> >                                               &desc_len, desc_op);
> > -             if (ret)
> > +             if (ret) {
> > +                     pm_runtime_put_sync(hba->dev);
> >                       goto out;
> > +             }
> >
> >               /* fall through */
> >       case UPIU_TRANSACTION_NOP_OUT:
>=20
> --
> Martin K. Petersen      Oracle Linux Engineering