Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp348218ybg; Wed, 10 Jun 2020 02:23:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyH7eXxWSvmcLOkOmihRCslQQ7OrM2ZlbYX7wS+P+WO/I7R2iiN0D1T/AbFi5lMFJzE8cMc X-Received: by 2002:aa7:dace:: with SMTP id x14mr1649134eds.343.1591780988797; Wed, 10 Jun 2020 02:23:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591780988; cv=none; d=google.com; s=arc-20160816; b=DLQi+7UH4yEd6GTmI4xyq5aChYN7Imo7+Zn7S80otsOjId0qjriNiWDOPGXAUyEUQW MGKL10L1yw3/4/rAWPtzxb+iTBPg5ZWzNfFNpGvCSCls4myA7qT4s20WZSfJRSScdYdt DW1VglOuLHYiBd1mYRtKXbaDaKOWmjzCMqCeslYAcUiJ2pLd3ae+UgDjqQAofGyORhOb R22fbgVm4hWos8klr8V102e1gaGHy6sExmF3jrySMCL4x9Rm8QxtIOXxCJBRy1dtBEmB zqBr4TEg+etzPaDJUyUBzySCGSNVH6+iXsaruHbsgge8aFaV7Bpv5qPDJ6LDzbwvZ4+5 81PA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=8zDUyaGBWXgk6E+N6JEYs9ue1EJLN+M9jJJcrTGqvFA=; b=wTzlcvK8fMkUoyhSRb0RprQ9vk8C08+WdFA073laPcnIxSn0iA8esM8HdPkJzXZLi3 ZdU4rcK88AcYdsiCgxzZu2d8AS6Db0UybCutlsu6vuzu44YigaJd/busFbQFURmRWLY3 PzYFtOk+3qrEENgTRQjNkzxh+2dfO20yepP/cRBbl/vPuZVjqPNvxcKMLtGVUuZMLM56 PwUWPT6u54lsRv+ApGUj2FfO5BebTjBBQBZfRv2olvdj4aKCc3eAxogrFGe+94rB5M1q yYACGO4NnDAxhoB5UHNcI7RA/sCZBfqeeflDKf3Eq28p7aiAGH2AOZeA66QBfDhEQGfk keUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WU7bIdPc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jp20si12841444ejb.307.2020.06.10.02.22.44; Wed, 10 Jun 2020 02:23:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WU7bIdPc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727041AbgFJJUh (ORCPT + 99 others); Wed, 10 Jun 2020 05:20:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726219AbgFJJUg (ORCPT ); Wed, 10 Jun 2020 05:20:36 -0400 Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DAD7C03E96B for ; Wed, 10 Jun 2020 02:20:36 -0700 (PDT) Received: by mail-lj1-x242.google.com with SMTP id s1so1596630ljo.0 for ; Wed, 10 Jun 2020 02:20:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8zDUyaGBWXgk6E+N6JEYs9ue1EJLN+M9jJJcrTGqvFA=; b=WU7bIdPcYpxZkpiKwzmOX8mjpxLoBeYgVeMolWE5iA+cc0b+ggsENZ/YJLXpbcaWOK ICmhqq7DQghydBnXTmTHxA3xdbPj2GuY8jD2tMopXOVOEg3ZSIHnRNtyR6h8dqAB02V1 W1yqhQDNn2+BpEO/1jal/dt1E9xDJ0iiL66R7T8QOiABinhNv0zpEDN71o/v9EYACJG7 9a43dZEeOXNVy1CBEhzcEyKTRihBDQkAbsltBSed/4HXzaLHE3ZxXQldlRG5klYBQ9B1 xviuXV2/V0BfQLHR8D82OLPOVFRrxy+oddWO0xKr4DchSFmu51mE7xdhmxYiLUk41dMH 34XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8zDUyaGBWXgk6E+N6JEYs9ue1EJLN+M9jJJcrTGqvFA=; b=M2l0nlxL7Y5eInJBp4K7sxNotKniqq13dagyFxC/D7pQT4Tu2droIZErC3/znWsD6i CuAr9LVYO+4kfmsLBd/BFx1F2P7R3+CmjnnGawZlE/Y+nQoYeRhD1zZ8P/LzmoIJpp6g IjzdJbOAYY8NJXHU0rVRMfTQJG3Vr6G73YVaxDx54Gtf4raklBe+NmMnofTbW9pgjfK+ H4CfJKm4GSzRJyWzHh01ynJ9PsvXt7+Rjy140n1g5HVLoMqd0eMRr18CI4qp8mqi/KJX HOqTizOHSi+1gl1NNnd0WHc9k12hZl+17RT9XrUcg8plw0CqFXh2LViV0WkY+pzrt4uF fGDA== X-Gm-Message-State: AOAM530Z2KlMHVf7QHaRerwka6Y4j/Jfi5/w1DSLefubwWiYkAF2ZPV1 ALgAruIKbtOaQGjL1P9IC78xvdYgm/TTDosRYomEYQ== X-Received: by 2002:a2e:a40f:: with SMTP id p15mr1346976ljn.286.1591780834630; Wed, 10 Jun 2020 02:20:34 -0700 (PDT) MIME-Version: 1.0 References: <20200605030052.78235-1-navid.emamdoost@gmail.com> In-Reply-To: <20200605030052.78235-1-navid.emamdoost@gmail.com> From: Linus Walleij Date: Wed, 10 Jun 2020 11:20:23 +0200 Message-ID: Subject: Re: [PATCH] gpio: arizona: put pm_runtime in case of failure To: Navid Emamdoost Cc: Bartosz Golaszewski , patches@opensource.cirrus.com, "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" , Navid Emamdoost , wu000273@umn.edu, Kangjie Lu , smccaman@umn.edu Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 5, 2020 at 5:01 AM Navid Emamdoost wrote: > Calling pm_runtime_get_sync increments the counter even in case of > failure, causing incorrect ref count if pm_runtime_put is not called in > error handling paths. Call pm_runtime_put if pm_runtime_get_sync fails. > > Signed-off-by: Navid Emamdoost Patch applied for fixes. Yours, Linus Walleij