Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp361097ybg; Wed, 10 Jun 2020 02:46:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw0Fphm+eqSDop4fgFH2GD+wMyngxSP4iPmZu2aH88tTgoMVbrSDqI9VFdI6/04MPstoebc X-Received: by 2002:a17:906:4d42:: with SMTP id b2mr2536954ejv.34.1591782416696; Wed, 10 Jun 2020 02:46:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591782416; cv=none; d=google.com; s=arc-20160816; b=TnIqHuS25q57QfM9g+2cojUFS/r9hE54VUICgYhGulK2WstNZVhZF1cnP41ktYISur WACouDDGFg6kQgShLFLmWIkKclyEy6r+l4YYZnIxn+TXp+tITsFRryRunMQaacnnwY7I 5mpSmZcZYlqK3Gx40bHxzwEVjjBuvybXTSjfjQdfDhXUGN484KTG1hrgPdC7E56X7PO+ G0keT7rCLQkq1Ep3W/lizM5ibcrjgxVNaX8mBgfNyv2CIjgBt7UTY9F8WP6d4fNkRHyp Y3mOp9MnMzYB+igMQwg7tsuWgilcdW+cC3Xz8y7LSPnuMeVWEka2ZLQBEiBb5k3IGDvs iTuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=svyjfmEJc3+r5Bull8lSuu/qgDN2rTAndZ5rJi9Ba2o=; b=ytnLZRYdPz+2Mt1LvM3U5JP4bEqRFTtlF89UgL4qri6NyqXADvmAPjDpF7M8Bq8NVF 5xxOgAxcB3BRg31P5U5Ur5ed2SZ5gDZCtn8/oqsiAsqe99uWkhvYpBXiGTX94HuGiikq KtmLJ6hvasCm3N4LP3qF5vAkRth7fJGiBY/MBpC60dXgGghCS16HsiE9x1oa9XOiuQM4 1QHaYHwM7mfjQpdNmDavCwr3B+j5TD76P8Hw2ymOiQ7aUhCU3d0Hndm+Nt2DXUMUkaz4 ed6milLL2YYCSowyu1jP4qRvzyJ2qhrF05oO0qXF6AZkBwfbhzUOiL5Ku/RZrwEIFFm0 wAWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=AMgNG3Lb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y14si12421745ejp.357.2020.06.10.02.46.34; Wed, 10 Jun 2020 02:46:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=AMgNG3Lb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727910AbgFJJoV (ORCPT + 99 others); Wed, 10 Jun 2020 05:44:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727909AbgFJJoU (ORCPT ); Wed, 10 Jun 2020 05:44:20 -0400 Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com [IPv6:2a00:1450:4864:20::244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB1B7C08C5C1 for ; Wed, 10 Jun 2020 02:44:18 -0700 (PDT) Received: by mail-lj1-x244.google.com with SMTP id 9so1654681ljv.5 for ; Wed, 10 Jun 2020 02:44:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=svyjfmEJc3+r5Bull8lSuu/qgDN2rTAndZ5rJi9Ba2o=; b=AMgNG3LbXSbZD6eBl2/IEceHF5cilPgFw2K3RxPXAl8WAyTiHclajD38G1Tc2Q7IIL JSAl5vPSokAFzuD6dghWzOBP8VQeaIBnEhmG7l6DbIj5XLzYlaKFxl68kpyO7qxTJuch Oknbf4oKQ2BxCbsKbeM4DVYh+BL5fS+J3SitSurgrSviegmUdN1RTWASwgL5E7dK3Eea ftChCFiQWkpFaq8mqhE2kLdcsDJoZmen1UBhmI1jCJ/cSLyTijZ0xSpCTHcX9e5qpBOV KK4npBNbzohL21ccWphgOTo20/ZK6StWglohLHKmhPuVh27p5gBk18RwPFlLeJWaHDQQ dH/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=svyjfmEJc3+r5Bull8lSuu/qgDN2rTAndZ5rJi9Ba2o=; b=cGkAxP5GY/Wns/fq9IRKJor+1wQAMV0bf/1gzBiiU0NrrPrU5JBN+eI2PHMkETHQbh hua7bbGQVsym1wpWJuhSYn0ambGHeld7Mx11ceG+Owxfezu04VUfdWPmoBsIEh9ZMTX4 DunGSL8egv/QSfAz7/MS9f5fmyQ8mjWqLol8Fp9oT0zWdqBY/2OVBvZWgSJ527s6lyfC Ph/M2yVrR3JWqlhqHRUDmRw33po4jWvKcf0Z+hwO9FgIv80XJAgaVQ5u9lJt0kVDTJeJ JQvMEu9N1R6awunWeoyuxUa4ohgqNbbNLgMwT8SdOpxc/9JsQSwMh7KvGAxwgkpckoZ5 S31A== X-Gm-Message-State: AOAM533QnaSqi2X+5O23VqJMVv+G6yXXBSW6d0qklDlv1bV43gJqKsHv T21SVCm49Nrq2xwLz0DmU95E0KgF0IU+GM0Yh4PqlQ== X-Received: by 2002:a2e:350a:: with SMTP id z10mr1266313ljz.104.1591782257094; Wed, 10 Jun 2020 02:44:17 -0700 (PDT) MIME-Version: 1.0 References: <20200605224403.181015-1-sebastian.reichel@collabora.com> <20200605224403.181015-3-sebastian.reichel@collabora.com> In-Reply-To: <20200605224403.181015-3-sebastian.reichel@collabora.com> From: Linus Walleij Date: Wed, 10 Jun 2020 11:44:05 +0200 Message-ID: Subject: Re: [PATCHv2 2/6] power: supply: gpio-charger: Make gpios optional To: Sebastian Reichel Cc: Sebastian Reichel , Rob Herring , Emil Velikov , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King , Linux PM list , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "linux-kernel@vger.kernel.org" , kernel@collabora.com, Linux ARM Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 6, 2020 at 12:44 AM Sebastian Reichel wrote: > While strongly recommended, not all devices have a gpio to > detect if the charger is connected. This moves the 'gpios' > from required to optional section. > > This also modifies error handling for the GPIO a bit: We > no longer fallback to pdata, if a GPIO is specified using > GPIO descriptor tables. This is a bit cleaner and does > not have any real impact: There are only two mainline pdata > users (arm/mach-sa1100/collie.c, arm/mach-pxa/tosa.c) and > none of them specify the GPIO via gpiod descriptor tables. > Once both have been converted the driver's support for > specifying GPIOs numbers in pdata will be dropped. > > Signed-off-by: Sebastian Reichel Reviewed-by: Linus Walleij Yours, Linus Walleij