Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 10 Jun 2020 12:18:19 +0200
From:   Robert Richter <rrichter@marvell.com>
To:     Zhenzhong Duan <zhenzhong.duan@gmail.com>
CC:     <linux-kernel@vger.kernel.org>, <linux-edac@vger.kernel.org>,
        <tony.luck@intel.com>, <bp@alien8.de>, <mchehab@kernel.org>,
        <james.morse@arm.com>
Subject: Re: [PATCH] EDAC, {skx, i10nm}: Advice mcelog that the error were
 handled
Message-ID: <20200610101819.oa2ivjtxildwothl@rric.localdomain>
References: <20200610065801.3579-1-zhenzhong.duan@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200610065801.3579-1-zhenzhong.duan@gmail.com>
User-Agent: NeoMutt/20170113 (1.7.2)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from rric.localdomain (31.208.96.227) by HE1PR0301CA0012.eurprd03.prod.outlook.com (2603:10a6:3:76::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.19 via Frontend Transport; Wed, 10 Jun 2020 10:18:26 +0000
X-Originating-IP: [31.208.96.227]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4bedb116-0d0e-472c-7b8b-08d80d279e37
X-MS-TrafficTypeDiagnostic: BYAPR18MB2408:
X-Microsoft-Antispam-PRVS: <BYAPR18MB240880F926A0F3DDF3A46253D9830@BYAPR18MB2408.namprd18.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4714;
X-Forefront-PRVS: 0430FA5CB7
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 7XWWDQqyBo48ZM64QWZexdx2/u5O2khYVTZhCSXirrpNCCznyGRicILDylY05fzUNjysHTe9wBwmORPJHdEuPYoFVYA69kLsYOktFhdfjvH9A+E60NrfsafHKie8TbtOOpna9+VRriIfsheJtTo7FIohERZGygTycTWFEcjdFPhdt3lZL9XAqBkO89E7MsBnRypVtnX7dFguhdurGd/qouFdNOlJEY9LRpnARbmBB61ZeBpXdCoBMCJ91R4dqlNMr7M9i2nnAF4XNsjRGOibZ2GDKAn0/tfgnafG6doR9SWnchoZWJC5QG1HxhaBj1dCjqwJuA1stSOvCjUwwh2zMw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR18MB2661.namprd18.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(376002)(346002)(136003)(39850400004)(396003)(366004)(5660300002)(53546011)(6506007)(66476007)(83380400001)(26005)(1076003)(66556008)(6666004)(66946007)(86362001)(52116002)(956004)(55016002)(316002)(7696005)(16526019)(8676002)(9686003)(2906002)(8936002)(6916009)(186003)(4326008)(478600001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: Y3jGL5E6U1nQN7gIPceAHwFWzD7zIE2+Lpq6+/Wlc7Kk2zd6uCntD304iuQvGcY/dR6k1JwNVnsU1jwwLt1dOvrKQz8V72eYwXh8Fmx48POFjUrp4DGGNGl4Ggi9y7Btxj6J5KcqQtUDsr0ImqtsmyITCgT0OFGWAYA8mhTXZELBOjjHH6r45Sx0TX0mWk15Lq5vkGP1+7vNiLeZDyTGJNqPGLRm8BULvZjRnWGeIzxxZvjxiWUfzGh1hmyelYNr2+CiZccB8iOL9gd5826EpmesvM7VLeILtKMhMUNnqAfcCdGG8VvRWubhui6CYUZOSOsN0N6T1p0z4G9bk63WO4Rliv09z+VKF80HiC0AIjfZej/qrUZZ9QeZ603HLxcLisj+P4fuYWnQzp19ZkQfHhnKTDMGQyRbUYc9j3wK13/baD+n629D0wx2dWT0+bKKZEE+2FYB0beghHQgKNg9WHzp/ga1hwTLCJppN67/pP8=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4bedb116-0d0e-472c-7b8b-08d80d279e37
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2020 10:18:28.5355
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Rb0b+PVGh8Sk/WGOcbzXyeeYPAHbatbXaFv5sEgvEsFapigkJQsEsMuTZDNz0MGjcHahV1lEXHkV3cp3KkaaYA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2408
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216,18.0.687
 definitions=2020-06-10_06:2020-06-10,2020-06-10 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10.06.20 14:58:01, Zhenzhong Duan wrote:
> If one MCE error has been processed in kernel, it's not necessory
> to pass it to user level mcelog.
> 
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@gmail.com>

Reviewed-by: Robert Richter <rrichter@marvell.com>

> ---
>  drivers/edac/skx_common.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/edac/skx_common.c b/drivers/edac/skx_common.c
> index 46be1a7..8c0165b 100644
> --- a/drivers/edac/skx_common.c
> +++ b/drivers/edac/skx_common.c
> @@ -615,7 +615,8 @@ int skx_mce_check_error(struct notifier_block *nb, unsigned long val,
>  
>  	skx_mce_output_error(mci, mce, &res);
>  
> -	return NOTIFY_DONE;
> +	/* Advice mcelog that the error were handled */

... error was ...

And make a sentence out of it, so close with a dot.

> +	return NOTIFY_STOP;

This change aligns with other implementation in:

 i7core_mce_check_error(),
 amd_decode_mce() and
 sbridge_mce_check_error().

-Robert

>  }
>  
>  void skx_remove(void)
> -- 
> 1.8.3.1
>