Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp404515ybg; Wed, 10 Jun 2020 04:01:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzZ2foPWVScd2MZVgZ3yswqMfNnOHHoZMkbOXiMqJaie7VbwYw8SGPWIXPCbD4dlhAD8+RR X-Received: by 2002:a17:907:2636:: with SMTP id aq22mr2720109ejc.384.1591786877411; Wed, 10 Jun 2020 04:01:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591786877; cv=none; d=google.com; s=arc-20160816; b=P1+7Y5pLZYC8S+hS2AEjQ1OdU4dYIescApisJMfQ6sMuDDIHKG/K1OuBIiSowFyJHb iNR/temYNiEmtvSLfR2Fpo2rlbO+nNC/0+8HfzaVNVqyuYJZ4aINT++9tiD0jBut4na8 Uy2PJ6qBjTrOjyCPcMRtZGzFFJUt5wxJn8ZxX8TlyZdhkn0YrrWxyY/fKe598voRJkJ3 WdqiAcciW8NP3UfFMPSPIcutVREYcZsiboMh3Ci21KrckjB00HJ1HizDJhSrKuXMRqB2 WzXR8nAg/jUjYd81JAA6SbEYP3dvcPNpaRZhARkqBn4QYNcqhvvv/Q06+7zeu0XFjs/w w3TQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=qHk8FeUEIxdpTchN08WfjOETdxw2DWBb3XvV4cG32mw=; b=Bh8HSAUZVxya7TFhwEbTX+bon+AJb5axnTCU7g6f/ByINo6lQQl2ex8xmlydOMjmBt 7akd3e4bdSOJ2JxRsIPMAXm3Dc93hUJHVC0/KkPQFfn7wZSh+R0R8qxREFPBoRVYDzBf qN/Iv9k914HnCAOztcE96ffV7n+yMbwA0zNjkT59ujwmU6RXAmc6nyJ2B/CpxXrQI1dO NqAdWZHxQ0pNVOP8NaXKm4GPpPcOOE8XaTDhduY70rbxw4XORRkU517zamO/nnwBnCHc 3hA5vam7QiMra4mc2kkR1e5zByT23ZP/B0ck/yKbHPi0JWdv/ytWy9GKAtn6izklkp9h 9nJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=B88mvquo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m9si12228464edp.531.2020.06.10.04.00.52; Wed, 10 Jun 2020 04:01:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=B88mvquo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728344AbgFJK60 (ORCPT + 99 others); Wed, 10 Jun 2020 06:58:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:55412 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728267AbgFJK60 (ORCPT ); Wed, 10 Jun 2020 06:58:26 -0400 Received: from localhost (unknown [122.171.156.216]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 64F92206F7; Wed, 10 Jun 2020 10:58:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591786705; bh=rSbEJSH5wWHm/u11HYgmNGrwGzUdhPr2VTU9myeit8Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=B88mvquodblHQiVmx/bmvCnLjjKFTzUMx6y9jLgDG+utdI1Sat2H6uJiyvFafdAcW EUfQcV3aPa8DikIELFcI2W82W6ZH3AZ9zyu9If+6SgeygqbbhcJUk+d0g8Da8UfxZL aq88/Fy/nLQ+DwxJDvl7BRg3I4mJ/g5Q7/iyjX1M= Date: Wed, 10 Jun 2020 16:28:20 +0530 From: Vinod Koul To: Jaroslav Kysela Cc: Srinivas Kandagatla , tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, broonie@kernel.org Subject: Re: [RFC PATCH] ALSA: compress: Fix gapless playback state machine Message-ID: <20200610105820.GA1393454@vkoul-mobl> References: <20200610100729.362-1-srinivas.kandagatla@linaro.org> <817d009e-fa09-e897-cfc3-997bf1dd5e30@perex.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <817d009e-fa09-e897-cfc3-997bf1dd5e30@perex.cz> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10-06-20, 12:40, Jaroslav Kysela wrote: > Dne 10. 06. 20 v 12:07 Srinivas Kandagatla napsal(a): > > For gapless playback call to snd_compr_drain_notify() after > > partial drain should put the state to SNDRV_PCM_STATE_RUNNING > > rather than SNDRV_PCM_STATE_SETUP as the driver is ready to > > process the buffers for new track. > > > > With existing code, if we are playing 3 tracks in gapless, after > > partial drain finished on previous track 1 the state is set to > > SNDRV_PCM_STATE_SETUP which is then moved to SNDRV_PCM_STATE_PREPARED > > after data write. With this state calls to snd_compr_next_track() and > > few other calls will fail as they expect the state to be in > > SNDRV_PCM_STATE_RUNNING. > > > > Here is the sequence of events and state transitions: > > > > 1. set_params (Track 1), state = SNDRV_PCM_STATE_SETUP > > 2. set_metadata (Track 1), no state change, state = SNDRV_PCM_STATE_SETUP > > 3. fill and trigger start (Track 1), state = SNDRV_PCM_STATE_RUNNING > > 4. set_next_track (Track 2), state = SNDRV_PCM_STATE_RUNNING > > 5. partial_drain (Track 1), state = SNDRV_PCM_STATE_SETUP > > 6 snd_compr_drain_notify (Track 1), state = SNDRV_PCM_STATE_SETUP > > 7. fill data (Track 2), state = SNDRV_PCM_STATE_PREPARED > > 8. set_metadata (Track 3), no state change, state = SNDRV_PCM_STATE_PREPARED > > 9. set_next_track (Track 3), !! FAILURE as state != SNDRV_PCM_STATE_RUNNING > > > The snd_compr_drain_notify() is called only from snd_compr_stop(). Something > is missing in this sequence? It is supposed to be invoked by driver when partial drain is complete.. both intel and sprd driver are calling this. snd_compr_stop is stop while draining case so legit Somehow not sure how it got missed earlier, but this seem a decent fix but we still need to check all the states here.. -- ~Vinod