Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp421620ybg; Wed, 10 Jun 2020 04:27:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyCo5vH0bMuE4uA0DgV31dA2JYnyy2wtYgruU7j45QRALGsJHrDAnxdBERnDdTVvCW/Vct2 X-Received: by 2002:a17:906:aec3:: with SMTP id me3mr2869783ejb.94.1591788422206; Wed, 10 Jun 2020 04:27:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591788422; cv=none; d=google.com; s=arc-20160816; b=C7ygfoEflMtP8iwHBj7M5AqQ4eyLRb4LWzjyS6jXhkPPoxIXS09wD89/CTb6SKNYuX r/3eG5rD8jNSdAOmxqjs43pAHr0PGOao0+UJnXqZff7XulQA6RfB364fVg1uFmDLysbj LZ3s2jyLxX5kj2BW5K2FNiAR8gaynJh/PKtFIuMO1H0WoQHDI42CganJgOX9zh02viV6 83Og6vRDcT0tXC8UTxZZfrb3QpDFHJoJFG48onAf/mqPyJGdo5o8SNnFxlQ3xnq29M6V dRT4m7XX+b+nAx0Lohx53LmDwB/VjyUfqU+UFnYU95whT1i8CK5eSSrwLepcou88LkJt s1Qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from; bh=dZ9P4EG8TMw8PUDi52pp9H8nMSJx8f+9h5wxeY51+5s=; b=JSrJgEzTNDpNjX1N/rOb6TghnsW8U31pnaNNc0gUx3cmQ6ZHbZDn37PsNjBrsM26FQ kpyn86/E1zcBA3pjKYqjpBrphWWC4LQplO2K8xk7aaeFSjbxQNUmb/v/gVzjDboLZwZZ U11c3+LzsA7GNjnPeMGm6owml6iPcVY3JGwDetublYLmR3NtbnZW//xJQC4N6/uIoaQj fPYv0WF10uOa88GP4o+KQfzHD5Wrnj4u1HnAEJBYhWh8SAwYsCqVg3VdA2S7tj06sLdB 4lQdfSS0/hHx4Y/XVX+0FsYtzvdX+b+E+1SbGoBGDZNUX24ye2gNlxm+7B3Ez2eeNeVH m5AQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bs16si5777141edb.197.2020.06.10.04.26.39; Wed, 10 Jun 2020 04:27:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728466AbgFJLVl (ORCPT + 99 others); Wed, 10 Jun 2020 07:21:41 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:43732 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728322AbgFJLVk (ORCPT ); Wed, 10 Jun 2020 07:21:40 -0400 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 05AB4Ypg116490; Wed, 10 Jun 2020 07:21:33 -0400 Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0a-001b2d01.pphosted.com with ESMTP id 31jkrgtuuk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Jun 2020 07:21:33 -0400 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 05ABLSrV006580; Wed, 10 Jun 2020 11:21:32 GMT Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by ppma03ams.nl.ibm.com with ESMTP id 31g2s7yjea-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Jun 2020 11:21:31 +0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 05ABLT0D7799170 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 10 Jun 2020 11:21:30 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D7F495204E; Wed, 10 Jun 2020 11:21:29 +0000 (GMT) Received: from ozlabs.au.ibm.com (unknown [9.192.253.14]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id 863D55205F; Wed, 10 Jun 2020 11:21:29 +0000 (GMT) Received: from localhost (unknown [9.206.222.209]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.au.ibm.com (Postfix) with ESMTPSA id 51A32A0217; Wed, 10 Jun 2020 21:21:28 +1000 (AEST) From: Michael Ellerman To: Satheesh Rajendran , linuxppc-dev@lists.ozlabs.org Cc: Satheesh Rajendran , linux-kernel@vger.kernel.org, Thiago Jung Bauermann , Ram Pai , Sukadev Bhattiprolu , Laurent Dufour Subject: Re: [PATCH] powerpc/pseries/svm: Fixup align argument in alloc_shared_lppaca() function In-Reply-To: <20200609113909.17236-1-sathnaga@linux.vnet.ibm.com> References: <20200609113909.17236-1-sathnaga@linux.vnet.ibm.com> Date: Wed, 10 Jun 2020 21:21:49 +1000 Message-ID: <87imfzf9o2.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216,18.0.687 definitions=2020-06-10_07:2020-06-10,2020-06-10 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 spamscore=0 suspectscore=1 clxscore=1015 impostorscore=0 mlxscore=0 bulkscore=0 priorityscore=1501 phishscore=0 cotscore=-2147483648 lowpriorityscore=0 mlxlogscore=840 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006100084 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Satheesh Rajendran writes: > Argument "align" in alloc_shared_lppaca() function was unused inside the > function. Let's fix it and update code comment. I think it would be better to drop the align argument entirely and keep that logic, and the comment, internal to alloc_shared_lppaca(). cheers