Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp429709ybg; Wed, 10 Jun 2020 04:39:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwll6zLiN9zN350kJGdCUeAh5Ct6462NkI+lL7j5FfmyqRNUVqWdLTujua5GkDuqmgU1VPu X-Received: by 2002:a17:907:10d1:: with SMTP id rv17mr2882237ejb.51.1591789183401; Wed, 10 Jun 2020 04:39:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591789183; cv=none; d=google.com; s=arc-20160816; b=ABwvoStWicpt4DMo0gar19ksYQ4voXf2bS90wkmhF1gHGy9Bs0RYq57a0v8LOQMgNy KE1K7SkgcRbz/1brBB6b3UaPMdIg5+j+1LQ8NURf/9e93rjEVYw/hu/cha4HeEMXXdLJ +XPbvu6h0x04FW4i1drtIrlRs3YDRup1svRunlwDDT1myeYo3MFQCkM+za412bU2SAuA LyoBI2ZDhwWt8leT6he11NcQKgNkhwMvIHvzUcgGDhcY8BOh41YsRVG1zCVFZs12L/z8 Z5Os4vIysxUPIUA/84X0FWmqvlyGblLT+241D5y3FXY9s+uzPWCTmpkHIcdGZItrAigB Z1Zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:to:from :dkim-signature; bh=qsT1gCj+s7CWFymn08xxmx3dZhMjbbtFSYSlDs2tyjU=; b=UczK8ODhBunlY10EO7OPDRgl2P1JzIzp3cxBClih6vJIDA3hbBqZ//F11V5gc6FPYR KMTjLzPaffXXm0GKbzMtDS17qYtAlXYdFBP1Jv8LyQlHoBawZ5q3T3SMKhYeiko8Pqje WB4Oest2iYBGF/HIJNhVSlMVMKFWIyIe9lCKpnh3OpN86ooxD6AhJ2u8/FMI/ZEus0eH 56LT7wniR+9l/efnvY7jAt0Q08V3/lPaC8+75/kaRqUbz9iM/DbewGMCnIQDX23jsgsj BOFeYfWuioWUjUPPvMkAbYFyC3e49FqCDr4zqVHtLup1coK+pAttoFidu3Dpl9NivOLk xLpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=J9SC3o9r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id si25si13246545ejb.43.2020.06.10.04.39.20; Wed, 10 Jun 2020 04:39:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=J9SC3o9r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728805AbgFJLhE (ORCPT + 99 others); Wed, 10 Jun 2020 07:37:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728705AbgFJLgj (ORCPT ); Wed, 10 Jun 2020 07:36:39 -0400 Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1116C08C5C1; Wed, 10 Jun 2020 04:36:38 -0700 (PDT) Received: by mail-qk1-x743.google.com with SMTP id l17so1596753qki.9; Wed, 10 Jun 2020 04:36:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=qsT1gCj+s7CWFymn08xxmx3dZhMjbbtFSYSlDs2tyjU=; b=J9SC3o9rHNx+zrdx7P9kKBj3FQVrZPPAwcoa3ww06QBvTPqfJB0syEKqDJXidEF0dk 8PfhPYo1aJj4M/juRqlunLnFxwSsIUUktl/9Bg5EfLGKi9cUz8KcjNn9WQQdWrLj+zQK ztn2N83cy+MQpNM5VPzcrdWw+QGYrQtId8OtIdp1gJQVcsanoyT2g6aKcgowDF9YaYT7 B6N1mswsU54+RIgJbA47mY5b3gzLLesjf/8TSxLnx6EoiGLiGH820dTXQqmkcVmFl3t9 DHhB468PiotNcLW/cX/Wx1KNh+W2zgw0nU50t8hdm8bwvuENfFbA+eFs20tm1UWurNSS G4aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=qsT1gCj+s7CWFymn08xxmx3dZhMjbbtFSYSlDs2tyjU=; b=nf3vhuIJBOhd4siZMFH0HPirhZgxdfnFu9YlHwD2G8HWdpQ049Mv4FhM4lYVopB1nm jusDitBJ0JquI+wT/SxZ688Dv39KgsEiMJtBfPzAgtHSrzvHJomUuLSdNsI6KO8vwoZE wiDkf3Nn6wSqv/fGPubG91XizLulqnFR5rB8E7Hby/hDwhCR/o0yPduFiEIbgkAfW7Z2 BdcC/2FNpBmJ8mzOQ2tiz0XFpERL/41DOBCLd4QLHbMi5eZ3iV2ZIRwbOpuP9G0s0YtP y4N1b8QbzoBV+BBf717/j643Y/gn73zGk15W5hy17snhwk5g+yKUHV8/Fg8Big1i4bkF zjdg== X-Gm-Message-State: AOAM531ZwzBu5NfXmhpRrc4BZNGqbP9DlWwAkky/5IR8YAupnIEUmfKd EdkPvlFKPet+f1/5p7y1mNIJQ/AupIxeNQ== X-Received: by 2002:a37:707:: with SMTP id 7mr2327325qkh.15.1591788998224; Wed, 10 Jun 2020 04:36:38 -0700 (PDT) Received: from linux.home ([2604:2000:1344:41d:61ac:316c:1207:3fa6]) by smtp.googlemail.com with ESMTPSA id g5sm13809059qta.46.2020.06.10.04.36.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2020 04:36:37 -0700 (PDT) From: Gaurav Singh To: gaurav1086@gmail.com, Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org (open list:GPIO SUBSYSTEM), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] max732x_probe: remove redundant check Date: Wed, 10 Jun 2020 07:36:30 -0400 Message-Id: <20200610113630.11922-1-gaurav1086@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Signed-off-by: Gaurav Singh The pdata is already checked for its validity. Remove this redundant check. --- drivers/gpio/gpio-max732x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-max732x.c b/drivers/gpio/gpio-max732x.c index 5fb0bcf31142..63472f308857 100644 --- a/drivers/gpio/gpio-max732x.c +++ b/drivers/gpio/gpio-max732x.c @@ -703,7 +703,7 @@ static int max732x_probe(struct i2c_client *client, if (ret) return ret; - if (pdata && pdata->setup) { + if (pdata->setup) { ret = pdata->setup(client, chip->gpio_chip.base, chip->gpio_chip.ngpio, pdata->context); if (ret < 0) -- 2.17.1