Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: tRCMCf0cC57dobeWM9CJUIUQEBcjnDkCmmimitTGVaen/LOuUjJfmwx/3UvyiNCGvpEpxrEMxV
 i+fTQD7Jj/YMoq28YKgrurZQZG8LWNIVhLHfRwhwWyWNu6adaMHKRvFsLsAstV2A6PXoZMQ4yW
 PmU+Zqxib8XRTAJ3u+e2Kizd0AyEww1SRjyhWZPcKRaZ19R0Eqqn92I2+UC40fPzDrUnvmV0UP
 0N/+33BfpjbARGiOuL7HUqz26a0R+IK+AMczYoJ/CyhlHXm01hRpjd3axPeR0ZPhHVA/vMn75m
 0HI=
References: <20200609072828.9088-1-lars.povlsen@microchip.com> <5f006733-52b6-e003-5db3-2ff16596918c@roeck-us.net>
From:   Lars Povlsen <lars.povlsen@microchip.com>
To:     Guenter Roeck <linux@roeck-us.net>
CC:     Lars Povlsen <lars.povlsen@microchip.com>,
        Jean Delvare <jdelvare@suse.com>,
        Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
        <linux-hwmon@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>
Subject: Re: [PATCH v2 0/3] hwmon: Adding support for Microchip Sparx5 SoC
In-Reply-To: <5f006733-52b6-e003-5db3-2ff16596918c@roeck-us.net>
Date:   Wed, 10 Jun 2020 09:33:58 +0200
Message-ID: <87eeqnidcp.fsf@soft-dev15.microsemi.net>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


Guenter Roeck writes:

> On 6/9/20 12:28 AM, Lars Povlsen wrote:
>> This is an add-on series to the main SoC Sparx5 series
>> (Message-ID: <20200608123024.5330-1-lars.povlsen@microchip.com>)
>>
>> Changes in v2:
>> - Changes in driver as per review comments
>>
>
> And you expect the reviewers/maintainers to remember what those were ?
>

Well, I can see that this might not be the case. I'll be a little more
specific next time. Sorry about that.

For the record, it was:

- Removed unnecessary #includes
- Statement reordering in s5_read()
- Replaced EINVAL with EIO
- Add 'break' in default: case statement.
- Removed extra ()
- Removed superfluous initialization

I got some more comments from Jonathan Cameron
<Jonathan.Cameron@huawei.com>, so there will be another round.

Thanks,

---Lars

>> Lars Povlsen (3):
>>   dt-bindings: hwmon: Add Sparx5 temperature sensor
>>   arm64: dts: sparx5: Add hwmon temperature sensor
>>   hwmon: sparx5: Add Sparx5 SoC temperature driver
>>
>>  .../bindings/hwmon/microchip,sparx5-temp.yaml |  39 +++++
>>  arch/arm64/boot/dts/microchip/sparx5.dtsi     |   6 +
>>  drivers/hwmon/Kconfig                         |  10 ++
>>  drivers/hwmon/Makefile                        |   2 +-
>>  drivers/hwmon/sparx5-temp.c                   | 152 ++++++++++++++++++
>>  5 files changed, 208 insertions(+), 1 deletion(-)
>>  create mode 100644 Documentation/devicetree/bindings/hwmon/microchip,sparx5-temp.yaml
>>  create mode 100644 drivers/hwmon/sparx5-temp.c
>>
>> --
>> 2.27.0
>>

-- 
Lars Povlsen,
Microchip