Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp602326ybg; Wed, 10 Jun 2020 08:51:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzyjevohVblzR1CQM7ELk0weT+VGqNimwnGo3axtzmOJsaeFwhI9Qg50YEE1EyX3jy3xWc6 X-Received: by 2002:a05:6402:22a5:: with SMTP id cx5mr3173907edb.246.1591804273628; Wed, 10 Jun 2020 08:51:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591804273; cv=none; d=google.com; s=arc-20160816; b=PkXKScXRJJK75DaENd7HQQiKVdY04C0xQU8Vj4/73Gro+0XdGpFOwFSd0UTA1HGArh 9JnXnh9zB33oHbS4d+HdBLKPBZUwHnz7kKE+2DBaCxRzj+Naw8ObM9+6/XWgtnyc701Y 7Y4sNG1D8ODo3NM9Iy7UaPIJ0Zx24AwgF92HsGSpDSOW3xdCq19ffhmIZaPmET1cnJEy mIWSGyFXvQ/nh5VSiNHK3+XtFnwk84AOG1IXlRr3EXXhNczUlmfGh/WTSQ1CsqPLvaPt 3JpqD8oqCfUztl21rrseOXkjxaE+Zr0IKCAHS7clcpCRE/u0yykW0zP0OOpDJFtC3iAJ eS0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=f4mk8DMZSx/C0D8exzWloYHBDhuLPA8lrqRoaVYx+eU=; b=O6HBJON8er0wOvIPR7Uz5pGayFZeQekCutvPmYZf04YWhCghiuXCa1HgnkFgDYboq8 DmM6Xpg0HLRrMyuC96r3c8rjN/IR6oND4BKbwy58q67XqVUWpyzh6uvvFz/s2Lq9h8bW 6kobO+DK5qCISByfp2mf/TeqjpNf9VW1iLARj5s0RUcfPPTIQyTlonf9Z3l739nNWvnU JrMZHwrxlGEwgJOxm/g8ylfB3znJcwvC/cjbGXAtk4vyD5O9oWQ50gkReIML0pXdfqUj KVdEAQCdsroWg5EEsd4jEldPhYHhMgz+dp741YNeXsfUt+/wzNMgqpv4gyo42WBUHZhv 9kiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=XB3sMSmP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o18si240473ejr.423.2020.06.10.08.50.51; Wed, 10 Jun 2020 08:51:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=XB3sMSmP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728449AbgFJLVP (ORCPT + 99 others); Wed, 10 Jun 2020 07:21:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:39226 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728381AbgFJLVP (ORCPT ); Wed, 10 Jun 2020 07:21:15 -0400 Received: from localhost.localdomain (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 90C21204EA; Wed, 10 Jun 2020 11:21:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591788074; bh=Vy1uNGpCyh3WA6USKC361S2rQ3bIgdUucbjMN7/azjo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XB3sMSmPStKwcCZbiYtdbjcc80l0y5WR7y4apK8+o9JokOR6gHgKEQwDzHFPMA85c FoCa4mEEx9ZMZAoRsv+zHWXuDbAvF/9mmVN4hLO1ZrO/iqgDUErh9zdAoFUs3ez8g3 nU3W3qhCqAntUiYzsYf4mHoYpPfCt5U6DER3f7lQ= From: Will Deacon To: Nick Desaulniers , Catalin Marinas Cc: Will Deacon , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Thomas Gleixner , Enrico Weigelt , Ard Biesheuvel , Allison Randal , Lorenzo Pieralisi , Jeremy Linton , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2] arm64: acpi: fix UBSAN warning Date: Wed, 10 Jun 2020 12:21:08 +0100 Message-Id: <159178566875.41592.7975510364023488303.b4-ty@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200608203818.189423-1-ndesaulniers@google.com> References: <20200608203818.189423-1-ndesaulniers@google.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 8 Jun 2020 13:38:17 -0700, Nick Desaulniers wrote: > Will reported a UBSAN warning: > > UBSAN: null-ptr-deref in arch/arm64/kernel/smp.c:596:6 > member access within null pointer of type 'struct acpi_madt_generic_interrupt' > CPU: 0 PID: 0 Comm: swapper Not tainted 5.7.0-rc6-00124-g96bc42ff0a82 #1 > Call trace: > dump_backtrace+0x0/0x384 > show_stack+0x28/0x38 > dump_stack+0xec/0x174 > handle_null_ptr_deref+0x134/0x174 > __ubsan_handle_type_mismatch_v1+0x84/0xa4 > acpi_parse_gic_cpu_interface+0x60/0xe8 > acpi_parse_entries_array+0x288/0x498 > acpi_table_parse_entries_array+0x178/0x1b4 > acpi_table_parse_madt+0xa4/0x110 > acpi_parse_and_init_cpus+0x38/0x100 > smp_init_cpus+0x74/0x258 > setup_arch+0x350/0x3ec > start_kernel+0x98/0x6f4 > > [...] Applied to arm64 (for-next/core), thanks! [1/1] arm64: acpi: fix UBSAN warning https://git.kernel.org/arm64/c/a194c33f45f8 Cheers, -- Will https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev