Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
References: <20200609150936.GA13060@iZj6chx1xj0e0buvshuecpZ>
User-agent: mu4e 0.9.17; emacs 26.3
From:   Valentin Schneider <valentin.schneider@arm.com>
To:     Peng Liu <iwtbavbm@gmail.com>
Cc:     mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
        vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
        rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched: correct SD_flags returned by tl->sd_flags()
In-reply-to: <20200609150936.GA13060@iZj6chx1xj0e0buvshuecpZ>
Date:   Wed, 10 Jun 2020 11:03:14 +0100
Message-ID: <jhjv9jz2q71.mognet@arm.com>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 09/06/20 16:09, Peng Liu wrote:
> During sched domain init, we check whether non-topological SD_flags are
> returned by tl->sd_flags(), if found, fire a waning and correct the
                                               ^^^^^^
                                            s/waning/warning/

> violation, but the code failed to correct the violation. Correct this.
>
> Fixes: 143e1e28cb40 ("sched: Rework sched_domain topology definition")
> Signed-off-by: Peng Liu <iwtbavbm@gmail.com>

Reviewed-by: Valentin Schneider <valentin.schneider@arm.com>

> ---
>  kernel/sched/topology.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
> index ba81187bb7af..9079d865a935 100644
> --- a/kernel/sched/topology.c
> +++ b/kernel/sched/topology.c
> @@ -1328,7 +1328,7 @@ sd_init(struct sched_domain_topology_level *tl,
>               sd_flags = (*tl->sd_flags)();
>       if (WARN_ONCE(sd_flags & ~TOPOLOGY_SD_FLAGS,
>                       "wrong sd_flags in topology description\n"))
> -		sd_flags &= ~TOPOLOGY_SD_FLAGS;
> +		sd_flags &= TOPOLOGY_SD_FLAGS;
>
>       /* Apply detected topology flags */
>       sd_flags |= dflags;