Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp665136ybg; Wed, 10 Jun 2020 10:21:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwDeP9eTNtkUhd0PcRjgpALzaxoYcvnY1LcEPYWF/XJn6qSdg9rLqKPJ/63XABLD2AFC9mF X-Received: by 2002:a50:d7d1:: with SMTP id m17mr3520336edj.126.1591809695543; Wed, 10 Jun 2020 10:21:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591809695; cv=none; d=google.com; s=arc-20160816; b=tqzmWrdGWTPxlOHrGkZfxbPf+NZ6EWwo+qQpe4mICLZJa2ypdMFeCOvy6tRXEvbkfZ RX/VUTeO7ztzI2NtYTmWkFLfXXXIMpjqs0JQLuHX7hPhd6Dr7X3bMeYGHZbiQFobb6c5 sdmaHPKJxgxfcdFP7NSXiQYF7HdgGD8RKA/vdKLdMDB8Sb2fTvFwMe3lp24NEN1B3XQm 89pjUHNL6AyZwmiXNypXR1Axo9BYRRKiRspz+DIC3wwLONblsit8pF1tF89S2NwNadPr nGFbWZhaEvUEkpB7I7nQuzdYA9+ad3YbuQCqqDOmjrgrVIQgOHKvkkyBlhyplWz/Ooy7 YJsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=M/EqEOAtehHW7io4dYQqZr4W9Xbm8d3Mu/KfCnLCi50=; b=jEOzuKWlmQLJUbt2ANtnhCZJw+zaB6EjwwIOqBxGQa+DuNWBVoyOZbWzrpwobPn1Dc tu2VZaDS780Xw8MMPm55U+oqOs/Bmns7sJyxqEw8jaXJyaFwshVlWeCgCDKpFbBAE3BP FUkaZgqnkDFX7AudRxa5z6fZ9xNqCkHtDv8gOD55mzumvTniONXg12MlDGyTILaCkf+p UdCmEvQXk6DlQHxpioqP+GZnl9nUqiIS4C3cgOz9C9n8ANcFd6zLz0MGNFK4ofVBP4lF BIcngcAkFZM4RiKrCM+Lak48eW1a5YnoThp/IFubqoW4o6jTvMgvpOWsyy0zssyXGDZn 3CtQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bo9si146525edb.239.2020.06.10.10.21.12; Wed, 10 Jun 2020 10:21:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728975AbgFJQCO (ORCPT + 99 others); Wed, 10 Jun 2020 12:02:14 -0400 Received: from asavdk3.altibox.net ([109.247.116.14]:35780 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726754AbgFJQCN (ORCPT ); Wed, 10 Jun 2020 12:02:13 -0400 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 931FE20025; Wed, 10 Jun 2020 18:02:09 +0200 (CEST) Date: Wed, 10 Jun 2020 18:02:08 +0200 From: Sam Ravnborg To: Matthias Schiffer Cc: Thierry Reding , David Airlie , Daniel Vetter , Rob Herring , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: (EXT) Re: [PATCH 3/4] drm/panel: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44 Message-ID: <20200610160208.GA138424@ravnborg.org> References: <20200610120131.3069-1-matthias.schiffer@ew.tq-group.com> <20200610120131.3069-4-matthias.schiffer@ew.tq-group.com> <20200610145954.GA135509@ravnborg.org> <44d3b82a11fc292f0aa3f60a8ccebd4e8ce5d3e8.camel@ew.tq-group.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <44d3b82a11fc292f0aa3f60a8ccebd4e8ce5d3e8.camel@ew.tq-group.com> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=edQTgYMH c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=8f9FM25-AAAA:8 a=e5mUnYsNAAAA:8 a=MH3lEQRaDhxj07Duq-8A:9 a=dKu1ZNvqqGtcOEyT:21 a=FKxxUMPwspYndQKg:21 a=CjuIK1q_8ugA:10 a=uSNRK0Bqq4PXrUp6LDpb:22 a=Vxmtnl_E_bksehYqCbjh:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 10, 2020 at 05:26:23PM +0200, Matthias Schiffer wrote: > On Wed, 2020-06-10 at 16:59 +0200, Sam Ravnborg wrote: > > Hi Matthias. > > > > Thanks, a few details you need to fix. See below. > > > > Sam > > > > On Wed, Jun 10, 2020 at 02:01:30PM +0200, Matthias Schiffer wrote: > > > From: Michael Krummsdorf > > > > > > Add support for the CDTech Electronics displays S070PWS19HP-FC21 > > > (7.0" WSVGA) and S070SWV29HG-DC44 (7.0" WVGA) to panel-simple. > > > > > > Signed-off-by: Michael Krummsdorf > > > Signed-off-by: Matthias Schiffer > > > > > > --- > > > drivers/gpu/drm/panel/panel-simple.c | 60 > > > ++++++++++++++++++++++++++++ > > > 1 file changed, 60 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/panel/panel-simple.c > > > b/drivers/gpu/drm/panel/panel-simple.c > > > index b6ecd1552132..1673113e5a5a 100644 > > > --- a/drivers/gpu/drm/panel/panel-simple.c > > > +++ b/drivers/gpu/drm/panel/panel-simple.c > > > @@ -1315,6 +1315,60 @@ static const struct panel_desc > > > cdtech_s043wq26h_ct7 = { > > > .bus_flags = DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, > > > }; > > > > > > +/* S070PWS19HP-FC21 2017/04/22 */ > > > +static const struct drm_display_mode cdtech_s070pws19hp_fc21_mode > > > = { > > > + .clock = 51200, > > > + .hdisplay = 1024, > > > + .hsync_start = 1024 + 160, > > > + .hsync_end = 1024 + 160 + 20, > > > + .htotal = 1024 + 160 + 20 + 140, > > > + .vdisplay = 600, > > > + .vsync_start = 600 + 12, > > > + .vsync_end = 600 + 12 + 3, > > > + .vtotal = 600 + 12 + 3 + 20, > > > + .vrefresh = 60, > > > > .vrefresh is no longer present, please drop. > > I based my patches on the branch drm-next of > https://cgit.freedesktop.org/drm/drm, should I have used a different > branch? drm-misc-next would in this case be a better choice. In most cases both would have worked equally well, but we have nuked .refresh recently. Sam > > > > > + .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC, > > > +}; > > > + > > > +static const struct panel_desc cdtech_s070pws19hp_fc21 = { > > > + .modes = &cdtech_s070pws19hp_fc21_mode, > > > + .num_modes = 1, > > > + .bpc = 6, > > > + .size = { > > > + .width = 154, > > > + .height = 86, > > > + }, > > > + .bus_format = MEDIA_BUS_FMT_RGB666_1X18, > > > + .bus_flags = DRM_BUS_FLAG_DE_HIGH | > > > DRM_BUS_FLAG_PIXDATA_POSEDGE, > > > +}; > > > > Please add .connector_type - it is mandatory. > > > + > > > +/* S070SWV29HG-DC44 2017/09/21 */ > > > +static const struct drm_display_mode cdtech_s070swv29hg_dc44_mode > > > = { > > > + .clock = 33300, > > > + .hdisplay = 800, > > > + .hsync_start = 800 + 210, > > > + .hsync_end = 800 + 210 + 2, > > > + .htotal = 800 + 210 + 2 + 44, > > > + .vdisplay = 480, > > > + .vsync_start = 480 + 22, > > > + .vsync_end = 480 + 22 + 2, > > > + .vtotal = 480 + 22 + 2 + 21, > > > + .vrefresh = 60, > > > > .vrefresh is no longer present, please drop. > > > + .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC, > > > +}; > > > + > > > +static const struct panel_desc cdtech_s070swv29hg_dc44 = { > > > + .modes = &cdtech_s070swv29hg_dc44_mode, > > > + .num_modes = 1, > > > + .bpc = 6, > > > + .size = { > > > + .width = 154, > > > + .height = 86, > > > + }, > > > + .bus_format = MEDIA_BUS_FMT_RGB666_1X18, > > > + .bus_flags = DRM_BUS_FLAG_DE_HIGH | > > > DRM_BUS_FLAG_PIXDATA_POSEDGE, > > > > Please add .connector_type - it is mandatory. > > > +}; > > > + > > > static const struct drm_display_mode cdtech_s070wv95_ct16_mode = { > > > .clock = 35000, > > > .hdisplay = 800, > > > @@ -3723,6 +3777,12 @@ static const struct of_device_id > > > platform_of_match[] = { > > > }, { > > > .compatible = "cdtech,s043wq26h-ct7", > > > .data = &cdtech_s043wq26h_ct7, > > > + }, { > > > + .compatible = "cdtech,s070pws19hp-fc21", > > > + .data = &cdtech_s070pws19hp_fc21, > > > + }, { > > > + .compatible = "cdtech,s070swv29hg-dc44", > > > + .data = &cdtech_s070swv29hg_dc44, > > > }, { > > > .compatible = "cdtech,s070wv95-ct16", > > > .data = &cdtech_s070wv95_ct16, > > > -- > > > 2.17.1