Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: FYtMEJkip4VfC8YdeUSRBIFM0v8xMgbZxkdwyizMew0etLXYkuyrwxjYmFzXT3HNF+/dCj5Boa
 fD1GDVmikrNw==
IronPort-SDR: NSo4/NBIGqOn+vaxO10VsYFX88Xyvk3JlQuR0gjkJXXrglVtj3MN/tmT/fKDjU/A7ImkazCtde
 smGLAKnHfg4w==
Subject: Re: [Intel-wired-lan] [PATCH] e1000e: Squash an unused function
 warning
To:     Palmer Dabbelt <palmer@dabbelt.com>, davem@davemloft.net
Cc:     netdev@vger.kernel.org, Palmer Dabbelt <palmerdabbelt@google.com>,
        linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
        kuba@kernel.org, kernel-team@android.com,
        "Neftin, Sasha" <sasha.neftin@intel.com>,
        vitaly.lifshits@intel.com, amir.avivi@intel.com
References: <20200610014907.148473-1-palmer@dabbelt.com>
From:   "Neftin, Sasha" <sasha.neftin@intel.com>
Message-ID: <8b01c6d6-db4d-d05c-d8cd-733cec31094e@intel.com>
Date:   Wed, 10 Jun 2020 19:18:02 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.1
MIME-Version: 1.0
In-Reply-To: <20200610014907.148473-1-palmer@dabbelt.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 6/10/2020 04:49, Palmer Dabbelt wrote:
> From: Palmer Dabbelt <palmerdabbelt@google.com>
> 
> e1000e_check_me is only used under CONFIG_PM_SLEEP but exists
> unconditionally, which triggers a warning.
> 
> Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>
> ---
>   drivers/net/ethernet/intel/e1000e/netdev.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
> index a279f4fa9962..f7148d1fcba2 100644
> --- a/drivers/net/ethernet/intel/e1000e/netdev.c
> +++ b/drivers/net/ethernet/intel/e1000e/netdev.c
> @@ -134,6 +134,7 @@ static const struct e1000e_me_supported me_supported[] = {
>   	{0}
>   };
>   
> +#ifdef CONFIG_PM_SLEEP
Thanks Palmer for catching this warning,
can we use "__maybe_unused" declaration instead of wrapping? I think it 
is more convenient and consistent.
>   static bool e1000e_check_me(u16 device_id)
>   {
>   	struct e1000e_me_supported *id;
> @@ -145,6 +146,7 @@ static bool e1000e_check_me(u16 device_id)
>   
>   	return false;
>   }
> +#endif
>   
>   /**
>    * __ew32_prepare - prepare to write to MAC CSR register on certain parts
>