Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: sR9lifVVQCTHBATsQZWehFn7wpOFphzJN8y+abrU6aDd+CHM2lrZdJwIu3IzPg8UlXQlmy4YXn
 s0P+QMXUcu/Q==
IronPort-SDR: kx5x97zDI+jMG/eqid0UpxmxpyBmfYSZ6mzpplV3XC3EcPNgDsT2z0Zg8KYyLp7tK2r1pHyElA
 jjaDzawW/gvA==
Date:   Wed, 10 Jun 2020 10:19:12 -0700
From:   "Luck, Tony" <tony.luck@intel.com>
To:     Zhenzhong Duan <zhenzhong.duan@gmail.com>
Cc:     linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org,
        bp@alien8.de, mchehab@kernel.org, james.morse@arm.com,
        rrichter@marvell.com
Subject: Re: [PATCH] EDAC/mc: call edac_inc_ue_error() before panic
Message-ID: <20200610171912.GB1474@agluck-desk2.amr.corp.intel.com>
References: <20200610065846.3626-1-zhenzhong.duan@gmail.com>
 <20200610065846.3626-2-zhenzhong.duan@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200610065846.3626-2-zhenzhong.duan@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jun 10, 2020 at 02:58:46PM +0800, Zhenzhong Duan wrote:
> By calling edac_inc_ue_error() before panic, we get a correct UE error
> count for core dump analysis.

Looks accurate, and I'll add the patch to be applied. But I wonder
how big a problem it is. Isn't most of the information deriveable
from the panic message?

> 
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@gmail.com>
> ---
>  drivers/edac/edac_mc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/edac/edac_mc.c b/drivers/edac/edac_mc.c
> index 75ede27..c1f23c2 100644
> --- a/drivers/edac/edac_mc.c
> +++ b/drivers/edac/edac_mc.c
> @@ -1011,6 +1011,8 @@ static void edac_ue_error(struct edac_raw_error_desc *e)
>  			e->other_detail);
>  	}
>  
> +	edac_inc_ue_error(e);
> +
>  	if (edac_mc_get_panic_on_ue()) {
>  		panic("UE %s%son %s (%s page:0x%lx offset:0x%lx grain:%ld%s%s)\n",
>  			e->msg,
> @@ -1020,8 +1022,6 @@ static void edac_ue_error(struct edac_raw_error_desc *e)
>  			*e->other_detail ? " - " : "",
>  			e->other_detail);
>  	}
> -
> -	edac_inc_ue_error(e);
>  }
>  
>  static void edac_inc_csrow(struct edac_raw_error_desc *e, int row, int chan)
> -- 
> 1.8.3.1
>