Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] sysctl: Delete the code of sys_sysctl
To:     "Eric W. Biederman" <ebiederm@xmission.com>
CC:     <keescook@chromium.org>, <ak@linux.intel.com>,
        <alex.huangjianhui@huawei.com>, <linzichang@huawei.com>,
        <linux-kernel@vger.kernel.org>
References: <1591683605-8585-1-git-send-email-nixiaoming@huawei.com>
 <87a71c59my.fsf@x220.int.ebiederm.org>
From:   Xiaoming Ni <nixiaoming@huawei.com>
Message-ID: <84286450-295b-b61b-f400-f08e7eafbe7c@huawei.com>
Date:   Wed, 10 Jun 2020 22:19:26 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.1.2
MIME-Version: 1.0
In-Reply-To: <87a71c59my.fsf@x220.int.ebiederm.org>
Content-Type: text/plain; charset="gbk"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2020/6/10 3:20, Eric W. Biederman wrote:
> Xiaoming Ni <nixiaoming@huawei.com> writes:
> 
>> Since the commit 61a47c1ad3a4dc ("sysctl: Remove the sysctl system call"),
>> sys_sysctl has lost its actual role: any input can only return an error.
> 
> The remaining code does have a role.  It reports programs that attempt
> to use the removed sysctl.
> 
> It would help if your change description had a reason why we don't want
> to warn people that a program has used a removed system call.
> 
> Probably something like:
> 
>    We have been warning about people using the sysctl system call for years
>    and believe there are no more users.  Even if there are users of this
>    interface if they have not complained or fixed their code by now they
>    probably are not going to, so there is no point in warning them any
>    longer.
> 
> With a change like that made to the patch description.
> 
> Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
> 
Thanks for your guidance
I will add it in the v2 version

Thanks
Xiaoming Ni