Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 10 Jun 2020 10:32:20 -0400
From:   Alan Stern <stern@rowland.harvard.edu>
To:     Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc:     mathias.nyman@intel.com,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "open list:USB XHCI DRIVER" <linux-usb@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] xhci: Suspend ports to U3 directly from U1 or U2
Message-ID: <20200610143220.GC11727@rowland.harvard.edu>
References: <20200610064231.9454-1-kai.heng.feng@canonical.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200610064231.9454-1-kai.heng.feng@canonical.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jun 10, 2020 at 02:42:30PM +0800, Kai-Heng Feng wrote:
> xHCI spec "4.15.1 Port Suspend" states that port can be put to U3 as long
> as Enabled bit is set and from U0, U1 or U2 state.
> 
> Currently only USB_PORT_FEAT_LINK_STATE puts port to U3 directly, let's
> do the same for USB_PORT_FEAT_SUSPEND and bus suspend case.
> 
> This is particularly useful for USB2 devices, which may take a very long
> time to switch USB2 LPM on and off.

Have these two patches been tested with a variety of USB-2.0 and USB-2.1 
devices?

Alan Stern