Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 10 Jun 2020 10:09:32 -0400
From:   Alan Stern <stern@rowland.harvard.edu>
To:     Chuhong Yuan <hslester96@gmail.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Magnus Damm <magnus.damm@gmail.com>, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: ohci-sm501: Add missed iounmap() in remove
Message-ID: <20200610140932.GA11727@rowland.harvard.edu>
References: <20200610024844.3628408-1-hslester96@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200610024844.3628408-1-hslester96@gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jun 10, 2020 at 10:48:44AM +0800, Chuhong Yuan wrote:
> This driver misses calling iounmap() in remove to undo the ioremap()
> called in probe.
> Add the missed call to fix it.
> 
> Fixes: f54aab6ebcec ("usb: ohci-sm501 driver")
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
> ---
>  drivers/usb/host/ohci-sm501.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/host/ohci-sm501.c b/drivers/usb/host/ohci-sm501.c
> index cff965240327..b91d50da6127 100644
> --- a/drivers/usb/host/ohci-sm501.c
> +++ b/drivers/usb/host/ohci-sm501.c
> @@ -191,6 +191,7 @@ static int ohci_hcd_sm501_drv_remove(struct platform_device *pdev)
>  	struct resource	*mem;
>  
>  	usb_remove_hcd(hcd);
> +	iounmap(hcd->regs);
>  	release_mem_region(hcd->rsrc_start, hcd->rsrc_len);
>  	usb_put_hcd(hcd);
>  	mem = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> -- 
> 2.26.2

Acked-by: Alan Stern <stern@rowland.harvard.edu>