Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp772231ybg; Wed, 10 Jun 2020 13:19:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz5TYZPBDhY9ccrPBwOnqt5MyPM3YAVMBTIMow1vrA4BqZMSVZ9WQB7hh8ry0aOeHRlxwSG X-Received: by 2002:a17:906:1904:: with SMTP id a4mr5028022eje.194.1591820352017; Wed, 10 Jun 2020 13:19:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591820352; cv=none; d=google.com; s=arc-20160816; b=TegQ5XNle73lFZ9cm+Zy0qU4KgutL5/LL+WhzyT3EuhTIQ01g9RYqwRDRZz970Dcw1 ryh27eOj8N7BDpsUxli546BI/HkKCMDJjHQRuqclOQH8nHgNZEGkUf8zpRL/oev2B2vm lFjts8fbhaoWuu3SU1sXILaB+W5Q+VtuuLgrUUxePfIU4D04Gih12R8OE1uMoMcGKDJV Wu7e2hYH42S/e27eVPu2fx9ji52XPf0WmtzDu37p7WmwRRU4AyoXVfQKwmNq7dYHwxKR q2R6BTgbetWdgqRng6ElSgwoCIwMMR5WX7uCSD4OECkx129DL1uBnRlzGlRgndZdv4fa 0ifA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=DbT62iamLGyvfGvWivf5BSNso9GnTYIYuw7syNClQaQ=; b=vRWsIzf9KT6088DagbVlidi+zQgJF1fjAiKcTQcDv/EB7VGtY1ejXdWocFb4ahh0nr VnlsFh5/OnUNfBk8vCHM71zJZgKYyoGY0cdNf/kbey89e/LRAXvuqukzaqLeL5A48pCG va0RDe1iYsFXNRFyYzvexSNI0ap9krkZ4d32bxkSLk6E4RAHnhsF8QPPg8XEqy/1hZmT 1izTH9Xvh3C/aR2anOM/KJayqNISnQGeiY1UAOAHLO4J7mz1ndq17ZA/ZOr5K9DAk2Pq K456YvIj84PwEKgm6uT9p0hFQevHgrwp4u4Z2C8j/Fc4eLlK/FB80fj/KmetxyNYZKwJ Feug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=RdP3NhHu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n19si351827edv.82.2020.06.10.13.18.48; Wed, 10 Jun 2020 13:19:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=RdP3NhHu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729239AbgFJSnN (ORCPT + 99 others); Wed, 10 Jun 2020 14:43:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:34470 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726105AbgFJSnM (ORCPT ); Wed, 10 Jun 2020 14:43:12 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 610962070B; Wed, 10 Jun 2020 18:43:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591814592; bh=vk+TyI0YXDcw/F4oBBcx2/OX0Q8DCn+GCXhtsjoEvUU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RdP3NhHuaEqkiOhDW44QUO6Iw2GjL+5wD56VnCs+XjZUNDuVZEZ4gogpsz/dur0Mg XpQD+R+KfiehPnLIpulDDFblTJoF8qD3qWzt2gtI2dmwttpIWvOpmryGKbLtsLQot0 B/R5TTjaAvruddHmxV4T1l46G2akDfah86nQBoUQ= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.lan) by disco-boy.misterjones.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jj5gs-001rXS-U4; Wed, 10 Jun 2020 19:43:11 +0100 From: Marc Zyngier To: Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu Cc: tglx@linutronix.de, jason@lakedaemon.net Subject: Re: [PATCH] irqchip/gic-v4.1: Use readx_poll_timeout_atomic() to fix sleep in atomic Date: Wed, 10 Jun 2020 19:43:07 +0100 Message-Id: <159181454880.1512339.2705658130320062146.b4-ty@kernel.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200605052345.1494-1-yuzenghui@huawei.com> References: <20200605052345.1494-1-yuzenghui@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: yuzenghui@huawei.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu, tglx@linutronix.de, jason@lakedaemon.net X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 5 Jun 2020 13:23:45 +0800, Zenghui Yu wrote: > readx_poll_timeout() can sleep if @sleep_us is specified by the caller, > and is therefore unsafe to be used inside the atomic context, which is > this case when we use it to poll the GICR_VPENDBASER.Dirty bit in > irq_set_vcpu_affinity() callback. > > Let's convert to its atomic version instead which helps to get the v4.1 > board back to life! > > [...] Applied to irq/irqchip-next, thanks! [1/1] irqchip/gic-v4.1: Use readx_poll_timeout_atomic() to fix sleep in atomic commit: a87d4e00eacbc95b44466e3470529f4de49b450a Cheers, M. -- Without deviation from the norm, progress is not possible.