Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Qian Cai <cai@lca.pw>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Andy Lutomirski <luto@kernel.org>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        X86 ML <x86@kernel.org>,
        "Paul E. McKenney" <paulmck@kernel.org>,
        Alexandre Chartre <alexandre.chartre@oracle.com>,
        Frederic Weisbecker <frederic@kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <sean.j.christopherson@intel.com>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Petr Mladek <pmladek@suse.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Joel Fernandes <joel@joelfernandes.org>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Juergen Gross <jgross@suse.com>,
        Brian Gerst <brgerst@gmail.com>,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Will Deacon <will@kernel.org>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Wei Liu <wei.liu@kernel.org>,
        Michael Kelley <mikelley@microsoft.com>,
        Jason Chen CJ <jason.cj.chen@intel.com>,
        Zhao Yakui <yakui.zhao@intel.com>,
        Alexander Potapenko <glider@google.com>
Subject: Re: [patch V9 10/39] x86/entry: Provide helpers for execute on irqstack
In-Reply-To: <20200610123833.GD954@lca.pw>
References: <87zh9cnfmg.fsf@nanos.tec.linutronix.de> <87wo4gnetx.fsf@nanos.tec.linutronix.de> <20200610123833.GD954@lca.pw>
Date:   Wed, 10 Jun 2020 21:38:56 +0200
Message-ID: <87h7vig17z.fsf@nanos.tec.linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Qian Cai <cai@lca.pw> writes:
> On Tue, Jun 09, 2020 at 10:50:50PM +0200, Thomas Gleixner wrote:
>> Thomas Gleixner <tglx@linutronix.de> writes:
>> >> BAD (after oom02)
>> >> # cat /sys/kernel/debug/stackdepot/info
>> >> Unique stacks: 140476
>> >
>> > That's indeed odd. I try to reproduce and figure out what really breaks
>> > here.
>> 
>> I checked your config file and I think I know where this comes from. Can
>> you plase disable KASAN just for testing purposes and compare before
>> after again?
>
> It turns out I'll need a few days to be able to get ahold of those
> affected systems again. I'll be reporting back as soon as possible.

I figured it out. It has nothing to do with asm_call_on...(). It's also
unrelated to page_owner. It's purely a KASAN issue.

KASAN trims stack traces with the help of filter_irq_stacks() which
relies on __irqentry_text_start/end

The entry rework moved the interrupt entry points out of the irqentry
section, which breaks that filter function.

I made it work again. Here are the numbers which make that obvious:

Mainline:
Unique stacks: 23403
Depot index:   244
Depot offset:  4208

x86/entry:
Unique stacks: 38835
Depot index:   464
Depot offset:  7616

x86/entry + fix:
Unique stacks: 23607
Depot index:   247
Depot offset:  14224

So with the non-working trimming this generates more unique stacks and
because they are not trimmed they become larger and eat more storage
space. The resulting average per stack shows that:

Mainline:           171 bytes per stack
x86/entry:          195 bytes per stack
x86/entry + fix:    172 bytes per stack

I'll point you to a test branch shortly.

Thanks,

        tglx