Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp775007ybg; Wed, 10 Jun 2020 13:24:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzf5/sgXZNm7maEKeh/L3TwmJv2R46KsqiSaJnX0S/5t9Utk3+oi8Jk88HzgqC6YivEa4xO X-Received: by 2002:a17:906:2c44:: with SMTP id f4mr5281214ejh.183.1591820647848; Wed, 10 Jun 2020 13:24:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591820647; cv=none; d=google.com; s=arc-20160816; b=umrepRgyVOTLIZp3Rrr6rEDXbrvhkhTtX0pzcEf7wAqQhKfXDoOMGIfAFQ8uqi7mKh pnNIVEzdzUhtxF1ybtF5i+I+nTOoq6T/FuDl8+M+Q//WfElnn880vYMTXxpinmtwwEVM ZRYSyjB99ttL0s8pe1wBUCBTYdxQiwX7jOAA9XS572JnbKGFi8d+hOvgkf8rCtYf68jD BAck43qb3CQHuKQlV3gCZBbND1Q0uKRoWYpldPmUizmEkY+EXCGmXQAvzlAt6pkpuL2G S+HVgKiofflSUobXl34X4qfmUs/Yn5BqdO2AdK69PgpG0uZqoPj8mhdP7Ui3BU+MWIqP F27g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=mmPoGnRfA4TUBSdV1ap2zn7Ew2a8qCnx8Rp9BKBKl4s=; b=XgJF2NquIBk8Cl0SfjAHOuSWezQKPA6RQ5mHt7sN3QpfhptVYKXzsfPLWd8ZLDYLiH PtG+1MKJpjtAFiin6Sm4FUZsUCEDJDP2X9oQgtglxpcnVbEZcoRLCToEK45MFZzNcXlS kj5iEwv3duP2dvqQqDL4nG9z8M3UZDzDnjH9t50M9gsiv6psEPHGTvgQUXnO3/pybMB8 L7KXeffUoYvWcrmJqkze3HlNJ6Hqnr00fPRXa3dvZUYCioetCA+JKAY/MBcBhxSaVtTc dDnHMFxlcymhtVE3P9QftU7FrteF1q5aPvW7bMtubR/JeCrVOyTCb17N6W4NMgJIqOsI 8Tig== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Q5FK+pK0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gt26si611469ejb.750.2020.06.10.13.23.45; Wed, 10 Jun 2020 13:24:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Q5FK+pK0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730818AbgFJUP1 (ORCPT + 99 others); Wed, 10 Jun 2020 16:15:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730577AbgFJUNv (ORCPT ); Wed, 10 Jun 2020 16:13:51 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10935C00863B; Wed, 10 Jun 2020 13:13:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=mmPoGnRfA4TUBSdV1ap2zn7Ew2a8qCnx8Rp9BKBKl4s=; b=Q5FK+pK0rlhrqdQfcRpYaQNhyr 9ERE6UdAQr92hPMbjQZaSR5ylWRW5PjUBvl0S98MdVV1cmRWTQBfI6DjgaHA5QgTMk9o+4YZefDFQ ujIFF9I4t50ykVeBiDedoUZ98B96D3Op4PnbePR9YyBhA4+9IK9LlhSQPjg9/RQRUIEfRGuxaQJAX g2GrClrm5J9SRCH2mm1DlmaO59hh4JEpYl4kFUkvT2KKIJRMU53JdILUluaWtzQVQDk4CoWxhkup/ oXlPFQLp6+orAWifK/R6CoiLOnDCCYy0IPybyQA2HShydsk9CInMgFQpxox701IJEFOl0z1LTamw8 9FJaHaaw==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jj76a-0003XP-UF; Wed, 10 Jun 2020 20:13:48 +0000 From: Matthew Wilcox To: linux-fsdevel@vger.kernel.org Cc: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 41/51] mm: Fix truncation for pages of arbitrary size Date: Wed, 10 Jun 2020 13:13:35 -0700 Message-Id: <20200610201345.13273-42-willy@infradead.org> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200610201345.13273-1-willy@infradead.org> References: <20200610201345.13273-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Matthew Wilcox (Oracle)" Remove the assumption that a compound page is HPAGE_PMD_SIZE, and the assumption that any page is PAGE_SIZE. Signed-off-by: Matthew Wilcox (Oracle) --- mm/truncate.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mm/truncate.c b/mm/truncate.c index 152974888124..a9fde773179b 100644 --- a/mm/truncate.c +++ b/mm/truncate.c @@ -168,7 +168,7 @@ void do_invalidatepage(struct page *page, unsigned int offset, * becomes orphaned. It will be left on the LRU and may even be mapped into * user pagetables if we're racing with filemap_fault(). * - * We need to bale out if page->mapping is no longer equal to the original + * We need to bail out if page->mapping is no longer equal to the original * mapping. This happens a) when the VM reclaimed the page while we waited on * its lock, b) when a concurrent invalidate_mapping_pages got there first and * c) when tmpfs swizzles a page between a tmpfs inode and swapper_space. @@ -177,12 +177,12 @@ static void truncate_cleanup_page(struct address_space *mapping, struct page *page) { if (page_mapped(page)) { - pgoff_t nr = PageTransHuge(page) ? HPAGE_PMD_NR : 1; + unsigned int nr = thp_nr_pages(page); unmap_mapping_pages(mapping, page->index, nr, false); } if (page_has_private(page)) - do_invalidatepage(page, 0, PAGE_SIZE); + do_invalidatepage(page, 0, thp_size(page)); /* * Some filesystems seem to re-dirty the page even after -- 2.26.2