Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp775560ybg; Wed, 10 Jun 2020 13:25:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw55skJgxqu0doXsnZ7YbFsSCwP0w4NgI5xZ7vq0mqAVZQq/LaUw0rIkBNUz7Jyj+VCGo7d X-Received: by 2002:a17:906:68ca:: with SMTP id y10mr5043033ejr.322.1591820706398; Wed, 10 Jun 2020 13:25:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591820706; cv=none; d=google.com; s=arc-20160816; b=0XI+iDlGB6ty7FTm0f9FH/x4ijJNiQG6cJIqCEqeroHGa7zNtqFFFgvmkfMyqEiZBU mBQhUrfwVi73NWKPUNpOnX9tvuoTrDmJZErQRNpeCUUMOG96PbUNAi8aCIRa/+rczqhx YUOrLt0u2QCF+yx4/YTQvVrKgOyL9s7xPQHMIDDuxTVyMYeKmBx8w37sxjYGDKO+xC1r rtYJROoD0hMZytvY6ZWAxYwr6yXGdi4ioc4f18rgVC/JLO31yr4HyWi80FWrSns79JYW qIrX/b8g99evJ6jnLYQcVR0Ixq6diOpn+YATubtPu907yCvUF3SQ6lbJ+KX75tGlQrPS vEtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=33n6uHIDU/xwgJxMoeJs++K6GI7dTUyUJxhDT49yQow=; b=OGR2CVL4X8aql7F/dfRrOsS4PLPyAms1/Ugyixyo4q3a2Rddx155c8S4Ku4JqO2Xhb pJN6m96Xn5aIP4fZeBkB9zKbF6643N39oZ3QP25WVGG9Oic7SVnOvfLbl53IcdAq3ru1 aGRXJjc/Ckzm/jXL4YGfIL/kiTogtGPJgyCaINFet1U9NRKsGvpV4Tnar+3Q+BSe2oSV uFhLFUTpAj66mQMQFfFd+xThidndYkw1oPEBBz6wBgy6tdM7l7uTXyNXKOv+NuLXXeas SHuWnJquSp4JN31NZtwtfnM5DAYpd8qZbXk9xEyaeP+QGrhziUm/VOzJkOqWmLwkFZV7 NRhw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=F4zTFIQB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x72si358504ede.303.2020.06.10.13.24.43; Wed, 10 Jun 2020 13:25:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=F4zTFIQB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730867AbgFJUQL (ORCPT + 99 others); Wed, 10 Jun 2020 16:16:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730559AbgFJUNu (ORCPT ); Wed, 10 Jun 2020 16:13:50 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93D1EC008632; Wed, 10 Jun 2020 13:13:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=33n6uHIDU/xwgJxMoeJs++K6GI7dTUyUJxhDT49yQow=; b=F4zTFIQBmlQAqxKjoc16EhcY4g VDaIF7Tnc7ZuUPpoYpIo4Hs+R4wqGUFkQFSMA5eilS6i+6eHGnqeaZqDu/0FcdTIY4pvRjcJURHeZ hxQ4WaKXHesAjK4W6g7UOoRUHkeVt/mQr1tOQGEqz2tTyHYMcVYczOnssY+QZkP9XFIK/8gfm0SSY 0mJFXwxZA4noGIpK3rBov1HwCkm8HCsZw+8SKbXOpAdVUrb5fOtzQxE2v15zudkDTyySSAveZ4QGF KBBADkbLpfr8h+l4/EUjBTxJKKZoMDc4gXlhrO/i12MaLUXcUiHZwK4MxzISo3xA4SzV/KFSJWIxS XLKP1Cpw==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jj76a-0003W9-F4; Wed, 10 Jun 2020 20:13:48 +0000 From: Matthew Wilcox To: linux-fsdevel@vger.kernel.org Cc: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Hellwig Subject: [PATCH v6 30/51] iomap: Inline data shouldn't see THPs Date: Wed, 10 Jun 2020 13:13:24 -0700 Message-Id: <20200610201345.13273-31-willy@infradead.org> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200610201345.13273-1-willy@infradead.org> References: <20200610201345.13273-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Matthew Wilcox (Oracle)" Assert that we're not seeing THPs in functions that read/write inline data, rather than zeroing out the tail. Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Christoph Hellwig --- fs/iomap/buffered-io.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c index 9275268ea97e..318c1ecc18c0 100644 --- a/fs/iomap/buffered-io.c +++ b/fs/iomap/buffered-io.c @@ -215,6 +215,7 @@ iomap_read_inline_data(struct inode *inode, struct page *page, return; BUG_ON(page->index); + BUG_ON(PageCompound(page)); BUG_ON(size > PAGE_SIZE - offset_in_page(iomap->inline_data)); addr = kmap_atomic(page); @@ -728,6 +729,7 @@ static size_t iomap_write_end_inline(struct inode *inode, struct page *page, void *addr; WARN_ON_ONCE(!PageUptodate(page)); + BUG_ON(PageCompound(page)); BUG_ON(pos + copied > PAGE_SIZE - offset_in_page(iomap->inline_data)); addr = kmap_atomic(page); -- 2.26.2