To: linux-kernel@vger.kernel.org
From: Stephen Hemminger <shemminger@osdl.org>
Subject: Re: [RFC PATCH 34/35] Add the Xen virtual network device driver.
Date: Wed, 22 Mar 2006 09:17:57 -0800
Organization: OSDL
Message-ID: <20060322091757.427f8ce8@localhost.localdomain>
References: <20060322063040.960068000@sorel.sous-sol.org>
	<20060322063808.464342000@sorel.sous-sol.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
NNTP-Posting-Date: Wed, 22 Mar 2006 17:17:56 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1415
Lines: 46

On Tue, 21 Mar 2006 22:31:14 -0800
Chris Wright <chrisw@sous-sol.org> wrote:

> The network device frontend driver allows the kernel to access network
> devices exported exported by a virtual machine containing a physical
> network device driver.
> 
> Signed-off-by: Ian Pratt <ian.pratt@xensource.com>
> Signed-off-by: Christian Limpach <Christian.Limpach@cl.cam.ac.uk>
> Signed-off-by: Chris Wright <chrisw@sous-sol.org>
> ---

In addition to earlier comments:

* should handle multiple interfaces, not just one static.

* the whole notifier fake arp call back is fugly

* use sysfs instead of /proc to handle the simple rxbuf_min,max stuff or use
  ethtool ring parameters

* proc module_owner not set, so ref counting not done.  Moot if you switch
  to sysfs.

* since you add ethtool for checksum,
  why not some basic stuff like driver info and carrier state?

* xen_net_read_mac seems like it could just be put inside driver.

* minor
	use free_netdev() rather than kfree in error path
	don't bother initializing .next/.priority in notifier_block if it is just 0

* what about mtu change?

* what about mac address change?

* Could you support scatter gather?


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/