Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751014AbWCVRYl (ORCPT ); Wed, 22 Mar 2006 12:24:41 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751015AbWCVRYl (ORCPT ); Wed, 22 Mar 2006 12:24:41 -0500 Received: from xenotime.net ([66.160.160.81]:29608 "HELO xenotime.net") by vger.kernel.org with SMTP id S1750991AbWCVRYk (ORCPT ); Wed, 22 Mar 2006 12:24:40 -0500 Date: Wed, 22 Mar 2006 09:26:49 -0800 From: "Randy.Dunlap" To: Arjan van de Ven Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, clemens@ladisch.de Subject: Re: [PATCH] hpet header sanitization Message-Id: <20060322092649.d967c47a.rdunlap@xenotime.net> In-Reply-To: <1143018140.2955.45.camel@laptopd505.fenrus.org> References: <20060321144607.153d1943.rdunlap@xenotime.net> <20060321161303.53c2895f.akpm@osdl.org> <20060321162630.d995c63c.rdunlap@xenotime.net> <1143018140.2955.45.camel@laptopd505.fenrus.org> Organization: YPO4 X-Mailer: Sylpheed version 2.2.2 (GTK+ 2.8.3; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1277 Lines: 42 On Wed, 22 Mar 2006 10:02:19 +0100 Arjan van de Ven wrote: > On Tue, 2006-03-21 at 16:26 -0800, Randy.Dunlap wrote: > > On Tue, 21 Mar 2006 16:13:03 -0800 Andrew Morton wrote: > > > > > "Randy.Dunlap" wrote: > > > > > > > > From: Randy Dunlap > > > > > > > > Add __KERNEL__ block. > > > > Use __KERNEL__ to allow ioctl interface to be usable. > > > > > > hm, why? > > > > because there is a test/example source file in (inside) > > Documentation/hpet.txt that won't build otherwise. > > And because hpet.h contains _userspace_ ioctl interface struct > > and macros... > > > then please split the header in 2 parts; one for the kernel > and one for userspace so would you tell me what the purpose (use) of __KERNEL__ is meant to be, please? Fortunately there are only about 165 header files in include/ that use both __KERNEL__ and _IO() macros (out of 5425 header files). > either put both here, or move the kernel one to the directory where the > source code is --- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/