Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] checkpatch: ignore CamelCase for inttypes.h format
 specifiers
To:     Joe Perches <joe@perches.com>, Andy Whitcroft <apw@canonical.com>
Cc:     BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>,
        linux-kernel@vger.kernel.org
References: <20200610203307.9344-1-scott.branden@broadcom.com>
 <1b2d9ead79a5a035a287b7ecba8655b2c633d5cd.camel@perches.com>
From:   Scott Branden <scott.branden@broadcom.com>
Message-ID: <a3d5f2c5-40fb-c97d-8365-423213926e89@broadcom.com>
Date:   Wed, 10 Jun 2020 14:48:09 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <1b2d9ead79a5a035a287b7ecba8655b2c633d5cd.camel@perches.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 2020-06-10 2:09 p.m., Joe Perches wrote:
> On Wed, 2020-06-10 at 13:33 -0700, Scott Branden wrote:
>> Ignore CamelCase for inttypes.h for fixed integer types format specifiers.
>> (ex. PRIx32 for uint32_t).
> Personally, I don't like those.
Checkpatch is run against a lot of code outside of the linux kernel but 
following linux coding style.
There is nothing personal about this, they are the format specifiers in 
inttypes.h for fixed width types .
>
>> Signed-off-by: Scott Branden <scott.branden@broadcom.com>
>> ---
>>   scripts/checkpatch.pl | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
>> index 899e380782c0..9fa90457b270 100755
>> --- a/scripts/checkpatch.pl
>> +++ b/scripts/checkpatch.pl
>> @@ -5157,6 +5157,8 @@ sub process {
>>   			    $var =~ /[A-Z][a-z]|[a-z][A-Z]/ &&
>>   #Ignore Page<foo> variants
>>   			    $var !~ /^(?:Clear|Set|TestClear|TestSet|)Page[A-Z]/ &&
>> +#Ignore inttypes.h scanf/printf format specifiers for fixed size integer types
>> +			    $var !~ /^(?:PRI|SCN)[dxoui](8|16|32|64|PTR|MAX)?$/ &&
>>   #Ignore SI style variants like nS, mV and dB
>>   #(ie: max_uV, regulator_min_uA_show, RANGE_mA_VALUE)
>>   			    $var !~ /^(?:[a-z0-9_]*|[A-Z0-9_]*)?_?[a-z][A-Z](?:_[a-z0-9_]+|_[A-Z0-9_]+)?$/ &&