Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp872406ybg; Wed, 10 Jun 2020 16:25:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy2CsvokaInsNa3cYVX2GYoeXnXCflwzkVH9cJWIE/gUQz2lHY6eQ//dhd5crXVzvqlCPde X-Received: by 2002:a17:906:528b:: with SMTP id c11mr5517966ejm.407.1591831501512; Wed, 10 Jun 2020 16:25:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591831501; cv=none; d=google.com; s=arc-20160816; b=IyMs84CMwwRSzmuQcWzw15DlWFIC6GbA7yDfW1vIkci9d8MvOaFnGM6t/jbP4MR1qF pv9WInNyGHUQknMyr+StsJ5I7NHYroNPqfEZoxJETm6ztRNwfsyL4AuzJ7lceeq5ALGp qrfKlhjPTKdoLonNQ8HvK0ohDyPNINw/SOiToOLbyYvoN3qmh1YCdOErgIC1UctspvmR 8mcsyC+HXgpWjzLBYThpHMzfsvMavjiAvtSJbDlJuhezOqciS9YCzwviJZuwPzUYXEH/ MPCzB2KY7Brxs+xLaupHyuLV1jUJuWkpKZ/Ln/HJdR55BWu7tSAqT4KakGz+lbXRJjy5 3Ijw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=EsI4HNkyqgRaf5lt2rwu9aBPPdUXK91akHA5CicInu4=; b=z4AuZlmW8PEA3cynIcyJFHsBJTQlic1XVP8yUo4Zr1eBXpIkLnz0EluqmRJVVbFh72 v3Ks8pZN41TSsoUQJ1p2C6LqsQRm4UPALc4mA/sXLtv+Wczr9YI52Bg24n3Mdp+Z7iVf Re7nAnMwOnpvbKXZRK1TNBSECH4ahHLrECkZog7ZMKx3DKhOiyQNj5+IyQpnP74tO1ez a4HRGXvUis3lg3SFJygHeCn521ZnBnQCLx+PQOCiUBOj9THEAJml8+4rGNvV2eSaGbU8 Qu9D/hommYpbOMXJxOnR+jx6uDshyif5MgNs/u8L067SLebgSIKNO9anmlR2nuspDI53 SPWA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id do15si1340005ejc.430.2020.06.10.16.24.36; Wed, 10 Jun 2020 16:25:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726778AbgFJXWk (ORCPT + 99 others); Wed, 10 Jun 2020 19:22:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726374AbgFJXWj (ORCPT ); Wed, 10 Jun 2020 19:22:39 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F4D7C03E96B; Wed, 10 Jun 2020 16:22:39 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id E3D2811F5F667; Wed, 10 Jun 2020 16:22:37 -0700 (PDT) Date: Wed, 10 Jun 2020 16:22:37 -0700 (PDT) Message-Id: <20200610.162237.1053512967005656899.davem@davemloft.net> To: clabbe@baylibre.com Cc: antoine.tenart@bootlin.com, linux@armlinux.org.uk, nicolas.ferre@microchip.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] net: cadence: macb: disable NAPI on error From: David Miller In-Reply-To: <1591782824-31654-1-git-send-email-clabbe@baylibre.com> References: <1591782824-31654-1-git-send-email-clabbe@baylibre.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 10 Jun 2020 16:22:38 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Corentin Labbe Date: Wed, 10 Jun 2020 09:53:44 +0000 > When the PHY is not working, the macb driver crash on a second try to > setup it. > [ 78.545994] macb e000b000.ethernet eth0: Could not attach PHY (-19) ... > This is due to NAPI left enabled if macb_phylink_connect() fail. > > Fixes: 7897b071ac3b ("net: macb: convert to phylink") > Signed-off-by: Corentin Labbe Applied and queued up for v5.5+ -stable, thanks.