Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 2/2] KVM: async_pf: Inject 'page ready' event only if
 'page not present' was previously injected
To:     Vivek Goyal <vgoyal@redhat.com>,
        Sean Christopherson <sean.j.christopherson@intel.com>
Cc:     Vitaly Kuznetsov <vkuznets@redhat.com>, kvm@vger.kernel.org,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>, linux-kernel@vger.kernel.org
References: <20200610175532.779793-1-vkuznets@redhat.com>
 <20200610175532.779793-2-vkuznets@redhat.com>
 <20200610193211.GB243520@redhat.com> <20200610194738.GE18790@linux.intel.com>
 <20200610195725.GA263462@redhat.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <91bf7843-ec23-e89e-a61f-1e36a32af09c@redhat.com>
Date:   Thu, 11 Jun 2020 01:53:37 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.6.0
MIME-Version: 1.0
In-Reply-To: <20200610195725.GA263462@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 10/06/20 21:57, Vivek Goyal wrote:
> I personally find it better that initialization of
> work->notpresent_injected is very explicit at the site where this 
> structure has been allocated and being initialized. (Instead of a
> a callee function silently initializing a filed of this structure).

I agree.

Paolo