Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp888660ybg; Wed, 10 Jun 2020 16:58:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxetDm62MBob/rpwYq7PGzy7B6pGVLhm7nOitdpIWnF7gC4DJGnf53aLGJW4PusKRvi9vkH X-Received: by 2002:a17:906:5652:: with SMTP id v18mr5591874ejr.72.1591833494848; Wed, 10 Jun 2020 16:58:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591833494; cv=none; d=google.com; s=arc-20160816; b=SAg+XI9mHUpuyJ2fKLyn+J3rrSVEZW7nrLX+JnJJ/5ZuZypFOnFY4lmmt3wdM8yOHC pSYOKlklexOiM+JBo5LGYst8gh1sqTUhRA/uzSCPF1ZuSBmlKvylcoNu9dNN1GEad8mo a1Qn6WNpEHF1HWfXnO5o18RnOklSUd+xGeC5+hG/9A7zAnvVvpqr27R3y277OMX/KGYu 4VUOglavqNu6d8X3dznocMgAoEbzig6zVnZpZPXMg2G4k4zanMrwuUo+s3eeeMD2tGTu 3dS4HwZR5jP71l919BUuJIKwNFsiS86TNCTup22ahfdVNraHjPi4+/9HVzIKiag1Jgzl WAqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=XT9FGFWKMDAc/4D+NwXX+C546Ycu5Vv14VbAOKkiLFk=; b=XPMwrICdv/R95ww1i6ncwexWIWf5ngZttBTvpwxMqoYysssPsU9ZVyTGARqDPopg9e sPsxnd3dBrO24933V5ioqSf5Qg9IOT/2i0M6HvhMndKj+8W5/Il25jZ2gC6zYqLtrjZr LV0LdYdHOxdJGBuT6og0FIbjBsD38LLyPWrE8PVvRmDoe2nqicsw77viMAsLYm1JKstP Al9QTpA7qTkzmWv4n+y+8P0L0Jy5OH8/447uf27Yput7uffWeAMxxci6z7sZUZLzFEG0 kVo47uvX9k8ovN0O/I2tnAPM74KdTx/93/jtcedifn8TR9TnYeGEFd/dcY+4VviAxlb3 P8Kw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x22si1002915ejw.222.2020.06.10.16.57.52; Wed, 10 Jun 2020 16:58:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726987AbgFJXzQ (ORCPT + 99 others); Wed, 10 Jun 2020 19:55:16 -0400 Received: from retiisi.org.uk ([95.216.213.190]:58564 "EHLO hillosipuli.retiisi.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726808AbgFJXzQ (ORCPT ); Wed, 10 Jun 2020 19:55:16 -0400 Received: from valkosipuli.localdomain (valkosipuli.retiisi.org.uk [IPv6:2a01:4f9:c010:4572::80:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by hillosipuli.retiisi.org.uk (Postfix) with ESMTPS id 7869E634C87; Thu, 11 Jun 2020 02:55:11 +0300 (EEST) Received: from sailus by valkosipuli.localdomain with local (Exim 4.92) (envelope-from ) id 1jjAYo-0000KR-W7; Thu, 11 Jun 2020 02:55:11 +0300 Date: Thu, 11 Jun 2020 02:55:10 +0300 From: Sakari Ailus To: Andrey Konovalov Cc: mchehab@kernel.org, manivannan.sadhasivam@linaro.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, c.barrett@framos.com, a.brela@framos.com, peter.griffin@linaro.org Subject: Re: [PATCH v4 00/10] Improvements to IMX290 CMOS driver Message-ID: <20200610235510.GC805@valkosipuli.retiisi.org.uk> References: <20200607163025.8409-1-andrey.konovalov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200607163025.8409-1-andrey.konovalov@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrey, On Sun, Jun 07, 2020 at 07:30:15PM +0300, Andrey Konovalov wrote: > This patchset adds improvements to the existing media driver for IMX290 > CMOS sensor from Sony. The major changes are adding 2 lane support, > configurable link frequency & pixel rate, test pattern generation, and > RAW12 mode support. Could you still see what checkpatch.pl says and address the style issues, please? Apart from those this seems fine to me. There are some on msleep() but I wouldn't worry about those. Thanks. -- Sakari Ailus