Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp983364ybg; Wed, 10 Jun 2020 20:13:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzhAa7shDorxUv9Z9ZhYt8GQGqhzo54UyIqh9fdgbFLq1PyP+XoBEBmO3JnX+e4mT4nHAp+ X-Received: by 2002:a50:f044:: with SMTP id u4mr5210638edl.226.1591845180610; Wed, 10 Jun 2020 20:13:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591845180; cv=none; d=google.com; s=arc-20160816; b=ZVQdpUGFscHtssDW9b1HCVxly/MGczgFXwQ/X2dl4JtNYt7p9fCMxAFZmXRW5HX+vr fEIReojuHs+DHR+V1918+9fT61OeZoU/0v3Rus/ahD1hOtjc09ewjUFsRYEbOyjK2zCS DwA6xr/vsz6N/scoiaiHZykjh4dY7U3ch7KJ6kEnHixXP+5wVsi+F2eyR3Zkvo9boQdo o148kZHvvBOFAEun2UgUKadKsxc3yk7MVkgHFpekyepAXWoAnF7MNXVKGFWuLkb7OHN+ pRyT3JKy8rJbsdF0qnFE/DI9y6fObi1zg2kcCUTWNjvf4doevfDRm66gtQ9MVZcLabF0 BqGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=ehrgS32gMf6wPQo2vNkaEDhcW2sOAF2ZJzxzXWBGECE=; b=Vx1QxwrJEEeWbn4l7u03A9+N2BhBQS/biWEUs0yDjNMRBoHBxZunmfmBB5SwJdmwZh 1TCQSKkYFdqQ8LBhYaBbLVV1EBbF3W8mfzpjfepPNJwafuzPkPNAwYcs53FiyaHGLdgj +0EMjSVAqITIMD5xEKAaohLDGDf5N36bj/1uX3Ts9X2UjXagZNEKYDTb1b/gI5OLpBWh N5popq1qERCswqaU/KNnHOlQujkKIW1jCh5oejsaRjkLG8WRwnaKA1ara+/HjuydkybP QK3PXTvHkt0L86IXVkSsz+lGcx8If6fEyRjcM+UeeyluUXSZzPUWaOciUy9w87D5f1qp irhw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=SBsE6fpH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f20si927783edr.380.2020.06.10.20.12.37; Wed, 10 Jun 2020 20:13:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=SBsE6fpH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726339AbgFKDIo (ORCPT + 99 others); Wed, 10 Jun 2020 23:08:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726279AbgFKDIn (ORCPT ); Wed, 10 Jun 2020 23:08:43 -0400 Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D03F5C08C5C1 for ; Wed, 10 Jun 2020 20:08:42 -0700 (PDT) Received: by mail-pg1-x541.google.com with SMTP id d10so1909041pgn.4 for ; Wed, 10 Jun 2020 20:08:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ehrgS32gMf6wPQo2vNkaEDhcW2sOAF2ZJzxzXWBGECE=; b=SBsE6fpH4sTwK5vsS5U/GGQxmT1TplW0qGq+4upLh6ZhwzIxHpBeNlbHnyQYU8wT/r cjennryJaV9c2rscT78TblJBogRH1ufR3cM8RKm1iTpPR2JMTCkKGKLSZM4BB2AcIaJ2 wgDlOfaKhPoFTM7jvfUgfLKhD4CC+720cLJmz1O3gpPUxuhuNxI0QxXGYTAhapzX/Kru JOWLwvJ/FbIcDif+2mu9IBIvnfbkTsjtcFXe+doNnlJ7K7CiPCw4T1VlleEgL0tGO/nc OAyXskLWT4TF7oi3nv2vYRmKcWregzVBiVxGyDMeoqrlSPoeJ6zUy8m87YMyW6xL4JZV +5VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ehrgS32gMf6wPQo2vNkaEDhcW2sOAF2ZJzxzXWBGECE=; b=SVLCbzJbsjHN4Tv3aefxnDjCZ9jFa+cffd6y8DHnQc+iVACjxvO53eVLgOJizqHzwV HQjXMJ9U/97n8Rj1QdD6+cQbHX/9EiO4JNWz3ZDPHh0d5zfFCeJoFQ0SD7tY3bWh3fM9 54iQNAqSt82aDJQWaOuRBhMbRO6utpHTAAtIiBamTbobTAOZyQN5ERghpLSgckxKOuhu oRgJCR2UOTq1WIBffEKA8ieCxyreAmhPxQgMayn0w/48Wk99MCo51bkW0EUKtSg/F+fD 7zvq6WOqZKW6f3FLv+tNlhohSJkjP1Bvqw4JZ8DNWfyiYxLC59H6+lglpuwjbTmCSjSV ALyw== X-Gm-Message-State: AOAM530uMu5pbR8UhyvabgSz3Cq1zVLQiiJVWnauC+CjKjnp1IpuvEIu rWs0x4c7RnQTuZa3RNvGpV+S3/QODTpHug== X-Received: by 2002:a63:658:: with SMTP id 85mr4989496pgg.181.1591844921701; Wed, 10 Jun 2020 20:08:41 -0700 (PDT) Received: from daehojeong1.seo.corp.google.com ([2401:fa00:d:1:b8f4:bbde:37ba:20bd]) by smtp.gmail.com with ESMTPSA id b5sm999331pjz.34.2020.06.10.20.08.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2020 20:08:41 -0700 (PDT) From: Daeho Jeong To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com Cc: Daeho Jeong Subject: [PATCH] f2fs: add F2FS_IOC_SEC_TRIM_FILE ioctl Date: Thu, 11 Jun 2020 12:08:09 +0900 Message-Id: <20200611030809.199132-1-daeho43@gmail.com> X-Mailer: git-send-email 2.27.0.278.ge193c7cf3a9-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Daeho Jeong Added a new ioctl to send discard commands or/and zero out to whole data area of a regular file for security reason. Signed-off-by: Daeho Jeong --- fs/f2fs/f2fs.h | 8 +++ fs/f2fs/file.c | 143 +++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 151 insertions(+) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index c812fb8e2d9c..ca139fac5a73 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -434,6 +434,7 @@ static inline bool __has_cursum_space(struct f2fs_journal *journal, _IOR(F2FS_IOCTL_MAGIC, 18, __u64) #define F2FS_IOC_RESERVE_COMPRESS_BLOCKS \ _IOR(F2FS_IOCTL_MAGIC, 19, __u64) +#define F2FS_IOC_SEC_TRIM_FILE _IOW(F2FS_IOCTL_MAGIC, 20, __u32) #define F2FS_IOC_GET_VOLUME_NAME FS_IOC_GETFSLABEL #define F2FS_IOC_SET_VOLUME_NAME FS_IOC_SETFSLABEL @@ -453,6 +454,13 @@ static inline bool __has_cursum_space(struct f2fs_journal *journal, #define F2FS_GOING_DOWN_METAFLUSH 0x3 /* going down with meta flush */ #define F2FS_GOING_DOWN_NEED_FSCK 0x4 /* going down to trigger fsck */ +/* + * Flags used by F2FS_IOC_SEC_TRIM_FILE + */ +#define F2FS_TRIM_FILE_DISCARD 0x1 /* send discard command */ +#define F2FS_TRIM_FILE_ZEROOUT 0x2 /* zero out */ +#define F2FS_TRIM_FILE_MASK 0x3 + #if defined(__KERNEL__) && defined(CONFIG_COMPAT) /* * ioctl commands in 32 bit emulation diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index dfa1ac2d751a..ba9b7ec5d6bf 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -3749,6 +3749,146 @@ static int f2fs_reserve_compress_blocks(struct file *filp, unsigned long arg) return ret; } +static int f2fs_secure_erase(struct block_device *bdev, block_t block, + block_t len, u32 flags) +{ + struct request_queue *q = bdev_get_queue(bdev); + sector_t sector = SECTOR_FROM_BLOCK(block); + sector_t nr_sects = SECTOR_FROM_BLOCK(len); + int ret = 0; + + if (!q) + return -ENXIO; + + if (flags & F2FS_TRIM_FILE_DISCARD) + ret = blkdev_issue_discard(bdev, sector, nr_sects, GFP_NOFS, + blk_queue_secure_erase(q) ? + BLKDEV_DISCARD_SECURE : 0); + + if (!ret && (flags & F2FS_TRIM_FILE_ZEROOUT)) + ret = blkdev_issue_zeroout(bdev, sector, nr_sects, GFP_NOFS, 0); + + return ret; +} + +static int f2fs_sec_trim_file(struct file *filp, unsigned long arg) +{ + struct inode *inode = file_inode(filp); + struct f2fs_sb_info *sbi = F2FS_I_SB(inode); + struct address_space *mapping = inode->i_mapping; + struct block_device *prev_bdev = NULL; + pgoff_t index, pg_start = 0, pg_end; + block_t prev_block = 0, len = 0; + u32 flags; + int ret = 0; + + if (!(filp->f_mode & FMODE_WRITE)) + return -EBADF; + + if (get_user(flags, (u32 __user *)arg)) + return -EFAULT; + if (flags == 0 || (flags & ~F2FS_TRIM_FILE_MASK)) + return -EINVAL; + + if ((flags & F2FS_TRIM_FILE_DISCARD) && !f2fs_hw_support_discard(sbi)) + return -EOPNOTSUPP; + + file_start_write(filp); + inode_lock(inode); + + if (!S_ISREG(inode->i_mode) || f2fs_is_atomic_file(inode) || + f2fs_compressed_file(inode)) { + ret = -EINVAL; + goto err; + } + + if (!inode->i_size) + goto err; + pg_end = DIV_ROUND_UP(inode->i_size, PAGE_SIZE); + + ret = f2fs_convert_inline_inode(inode); + if (ret) + goto err; + + down_write(&F2FS_I(inode)->i_gc_rwsem[WRITE]); + down_write(&F2FS_I(inode)->i_mmap_sem); + + ret = filemap_write_and_wait(mapping); + if (ret) + goto out; + + truncate_inode_pages(mapping, 0); + + for (index = pg_start; index < pg_end;) { + struct dnode_of_data dn; + unsigned int end_offset; + + set_new_dnode(&dn, inode, NULL, NULL, 0); + ret = f2fs_get_dnode_of_data(&dn, index, LOOKUP_NODE); + if (ret) + goto out; + + end_offset = ADDRS_PER_PAGE(dn.node_page, inode); + if (pg_end < end_offset + index) + end_offset = pg_end - index; + + for (; dn.ofs_in_node < end_offset; + dn.ofs_in_node++, index++) { + struct block_device *cur_bdev; + block_t blkaddr = f2fs_data_blkaddr(&dn); + + if (__is_valid_data_blkaddr(blkaddr)) { + if (!f2fs_is_valid_blkaddr(F2FS_I_SB(inode), + blkaddr, DATA_GENERIC_ENHANCE)) { + ret = -EFSCORRUPTED; + goto out; + } + } else + continue; + + cur_bdev = f2fs_target_device(sbi, blkaddr, NULL); + if (f2fs_is_multi_device(sbi)) { + int i = f2fs_target_device_index(sbi, blkaddr); + + blkaddr -= FDEV(i).start_blk; + } + + if (len) { + if (prev_bdev == cur_bdev && + blkaddr == prev_block + len) { + len++; + } else { + ret = f2fs_secure_erase(prev_bdev, + prev_block, len, flags); + if (ret) + goto out; + + len = 0; + } + } + + if (!len) { + prev_bdev = cur_bdev; + prev_block = blkaddr; + len = 1; + } + } + + f2fs_put_dnode(&dn); + } + + if (len) + ret = f2fs_secure_erase(prev_bdev, prev_block, len, flags); +out: + up_write(&F2FS_I(inode)->i_mmap_sem); + up_write(&F2FS_I(inode)->i_gc_rwsem[WRITE]); +err: + inode_unlock(inode); + file_end_write(filp); + + return ret; +} + long f2fs_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) { if (unlikely(f2fs_cp_error(F2FS_I_SB(file_inode(filp))))) @@ -3835,6 +3975,8 @@ long f2fs_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) return f2fs_release_compress_blocks(filp, arg); case F2FS_IOC_RESERVE_COMPRESS_BLOCKS: return f2fs_reserve_compress_blocks(filp, arg); + case F2FS_IOC_SEC_TRIM_FILE: + return f2fs_sec_trim_file(filp, arg); default: return -ENOTTY; } @@ -4004,6 +4146,7 @@ long f2fs_compat_ioctl(struct file *file, unsigned int cmd, unsigned long arg) case F2FS_IOC_GET_COMPRESS_BLOCKS: case F2FS_IOC_RELEASE_COMPRESS_BLOCKS: case F2FS_IOC_RESERVE_COMPRESS_BLOCKS: + case F2FS_IOC_SEC_TRIM_FILE: break; default: return -ENOIOCTLCMD; -- 2.27.0.278.ge193c7cf3a9-goog