Message-ID: <442190C2.6040001@oracle.com>
Date: Wed, 22 Mar 2006 10:00:34 -0800
From: Zach Brown <zach.brown@oracle.com>
User-Agent: Mozilla Thunderbird 1.0.7-1.1.fc4 (X11/20050929)
MIME-Version: 1.0
To: Kristen Accardi <kristen.c.accardi@intel.com>
Cc: linux-kernel@vger.kernel.org, stern@rowland.harvard.edu
Subject: Re: [patch] add private data to notifier_block
References: <1142970154.31210.10.camel@whizzy>
In-Reply-To: <1142970154.31210.10.camel@whizzy>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 953
Lines: 27

Kristen Accardi wrote:

> device data can be easily accessed.  This patch will modify the
> notifier_block struct to add a void *, and will require no modifications
> to any other users of the notifier_block.

>  {
>  	int (*notifier_call)(struct notifier_block *self, unsigned long, void *);
>  	struct notifier_block *next;
> +	void *data;
>  	int priority;
>  };

Well, it might introduce warnings in users who weren't using named
initializers -- their bare priority initialization might now shift to
trying to initialize a pointer.

Though, that's probably a good thing as it gives an opportunity to
convert them.  We also don't want to create a padded structure by
putting the void * after the int.

- z
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/