Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp1049488ybg; Wed, 10 Jun 2020 22:47:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzMIYMa68EfCt6VIbnfOVPD1nGcGeHdFRAnM1gZw3YqmDeSctPszWaDZEW2KmonhUBvoZ7e X-Received: by 2002:a17:906:470b:: with SMTP id y11mr7049413ejq.182.1591854432150; Wed, 10 Jun 2020 22:47:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591854432; cv=none; d=google.com; s=arc-20160816; b=KQ7u0hgNzDUe7rvRyfmPcTd2wKF8HA6sTdOYS0SYhcnxfLmyywINcHA5XclxS7jOYq 7/0r0RQ1rcRnu2wJ6VRoxXEfPsJCpLasF3lVyLUh4xiCMe2K5m950qjaG4Q/jiNHymI6 CgxQ/fBtv3rofzmp9Q22SmsoT7/VaTJdHjbkBLCZS6xl1KDv9F7IUMjGP7HD8u8tlTeg fABe9XYEgjtxVVoRVEvZMaDG3zIV0kYTBYv13DbbFpvUf+aqz079rmruy3Ojort+Zavm cEM2oMRibYbqpu+8f4gL/yoCyXKEz329hyArCUI6/7QPOTuArKVyLhnzqaubGvZxrpWG rLIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=CMSRdAMjqQ0hUIKg7+9PjXGS1txRLKEo1w8Yv1LWP4U=; b=hyM+yVJPWmClWXPX89I/oPT0LIOBLxaAHa8QXZoBReTPTaqs3aArB20ZhLycCtdK0U iOiNkfGg3GMgaykyC/B/caS7qW1q1vdntjkuYE8R2Gs9lg1W+Mzb8WYcQgE4dfzoAxsm mcqmNIDZpzq8X8RV3tGRLK6ocp3+mslwP+cZ50WH7tMxtyKSm3WyX/6FBPZDwZT+vJjD ncScVaevVHivnOK2EHHLxefwjU5D5vDn31Bpxs2qOFz2KfPMh9YTiXhzX41m/H1qjrHZ ruRKu4sKzVICO4UI8S/lfv8Tn6ndNRO2RofmXsGoB4FILR1pEuJb4kgBjQfI3oCb5lln t5eQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=RPc879Fn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ha26si1403334ejb.533.2020.06.10.22.46.48; Wed, 10 Jun 2020 22:47:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=RPc879Fn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726454AbgFKFpF (ORCPT + 99 others); Thu, 11 Jun 2020 01:45:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726147AbgFKFpE (ORCPT ); Thu, 11 Jun 2020 01:45:04 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41201C08C5C1 for ; Wed, 10 Jun 2020 22:45:04 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id y17so4737216wrn.11 for ; Wed, 10 Jun 2020 22:45:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=CMSRdAMjqQ0hUIKg7+9PjXGS1txRLKEo1w8Yv1LWP4U=; b=RPc879FnDmXOmAiuG2ZiC2YAn/tFY+I56Ips0B76qiI4DawSzuLFJVbQq0JOYlQDvD QLujLY1XQ4R7Jo2IeeSNhcAYgf3KHPenlEC/nFdJIa9AoFcCBxo6ovQH8zm+bPeHfxFx Ia36NQzuV5x9wyHdewsXeQX2C1iAjxvRH5d+dcUdrkTKU5Wa2CLaXobq1J4sAnYghdwv cN1Knh+GBr2tfe99M45qIk5ozZq8B1Daw1dCXcbesgd3/OscMuvVXSbwvDpkVlMVWCIF nwS/J6EaUvJevLnehE9CPm8svB3JeptLEDquIukgcmT5DmpfSsppK5sv3tCRRfqxrYa0 vg+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=CMSRdAMjqQ0hUIKg7+9PjXGS1txRLKEo1w8Yv1LWP4U=; b=W+XmNXWtWuW8rr7uROmDGlQztndGgBMHqQzKAx7MiBw0U7gC76rr+6RLPTiSi1BSF/ /PAocoj2khv4MRYdz8pNe0wpBT4znjTezLXhfHz0fnocG6lvvleWBTesQ1Towb/82sMf 0culi3KaTCa30KTIAAYnEerotQAkBdLjjeQeyhcP/9VVANXXru7DSYq9q+8nsTmszk1t ICs6ofrEGJkN+pK74u8SYYqc82qY6r8qtLkmh8mvWGhD0yH3bVN+qjfmRb9yEBoqjh2n Kh3Zxwvr0xdJG0ihHcFavXdvG5tBl1GJxfVbYogoL73YiCllJIAxXdx87nZW4D3w6vo6 zQSw== X-Gm-Message-State: AOAM531Jn9eFjjwLZvoCp5ZmY6MSEWg/e7sXyplR//WwSqMcWTk6mzsi nyQj+5UFQbvQDOQalS1DSjg= X-Received: by 2002:a5d:6a4b:: with SMTP id t11mr7404152wrw.404.1591854301729; Wed, 10 Jun 2020 22:45:01 -0700 (PDT) Received: from mail.broadcom.com ([192.19.231.250]) by smtp.gmail.com with ESMTPSA id j16sm3492724wre.21.2020.06.10.22.44.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2020 22:45:01 -0700 (PDT) From: Kamal Dasu To: Brian Norris , Kamal Dasu , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra Cc: linux-mtd@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] mtd: rawnand: brcmnand: Don't default to edu transfer Date: Thu, 11 Jun 2020 01:44:53 -0400 Message-Id: <20200611054454.2547-1-kdasu.kdev@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When flash-dma is absent do not default to using flash-edu. Make sure flash-edu is enabled before setting EDU transfer function. Fixes: a5d53ad26a8b ("mtd: rawnand: brcmnand: Add support for flash-edu for dma transfers") Signed-off-by: Kamal Dasu --- drivers/mtd/nand/raw/brcmnand/brcmnand.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c index 8f9ffb46a09f..0c1d6e543586 100644 --- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c +++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c @@ -2953,8 +2953,9 @@ int brcmnand_probe(struct platform_device *pdev, struct brcmnand_soc *soc) if (ret < 0) goto err; - /* set edu transfer function to call */ - ctrl->dma_trans = brcmnand_edu_trans; + if (has_edu(ctrl)) + /* set edu transfer function to call */ + ctrl->dma_trans = brcmnand_edu_trans; } /* Disable automatic device ID config, direct addressing */ -- 2.17.1