Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200610090748.45908-1-pihsun@chromium.org> <20200610090748.45908-3-pihsun@chromium.org>
 <3776237e-a6d5-ccda-79e4-39545b818e34@collabora.com>
In-Reply-To: <3776237e-a6d5-ccda-79e4-39545b818e34@collabora.com>
From:   Pi-Hsun Shih <pihsun@chromium.org>
Date:   Thu, 11 Jun 2020 15:20:42 +0800
Message-ID: <CANdKZ0cwcTaXM+y3scooJyrH_DVdF8=jS2QN96CyoPrH8RmbTg@mail.gmail.com>
Subject: Re: [PATCH v3 2/2] regulator: Add driver for cros-ec-regulator
To:     Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc:     Nicolas Boichat <drinkcat@chromium.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Benson Leung <bleung@chromium.org>,
        Guenter Roeck <groeck@chromium.org>,
        Tzung-Bi Shih <tzungbi@google.com>,
        Lee Jones <lee.jones@linaro.org>,
        Yicheng Li <yichengli@chromium.org>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Thanks for the review, would address most of them in v4. An inline
reply as below:

On Thu, Jun 11, 2020 at 12:47 AM Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
>
> Hi Pi-Hsun,
>
> Thank you for your patch.
>
> On 10/6/20 11:07, Pi-Hsun Shih wrote:
> > +/*****************************************************************************/
> > +/* Voltage regulator controls */
> > +
> > +/*
> > + * Get basic info of voltage regulator for given index.
> > + *
> > + * Returns the regulator name and supported voltage list in mV.
> > + */
> > +#define EC_CMD_REGULATOR_GET_INFO 0x012B
>
> This introduces a new EC command, while you are here, please also add the
> command in drivers/platform/chrome/cros_ec_trace.c, so we can trace properly the
> command. Also can you point me to the commit that introduces this command in the
> EC firmware?

The commit that introduces this in EC firmware is at https://crrev.com/c/2100327