Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: lOKWR2sA++bVoHADnte08VIQl50LoRhATXUliGYK/7alKvJiJBymhptU+9JYr6qtZWpDCQqzS+
 OGtdAtUPJROQ==
IronPort-SDR: HRmqmbzRLw8/f2rQQukq4hhYhkyAW6AAnCu6i+38YfyYkbtaL1vbq0s5e6LxjNOenQqT8pLdBk
 nPRcJVHMlrUA==
Reply-To: vadivel.muruganx.ramuthevar@linux.intel.com
Subject: Re: [PATCH v2 2/2] usb: phy: Add USB3 PHY support for Intel LGM SoC
To:     Andy Shevchenko <andriy.shevchenko@intel.com>
Cc:     linux-kernel@vger.kernel.org, balbi@kernel.org,
        p.zabel@pengutronix.de, gregkh@linuxfoundation.org,
        robh@kernel.org, devicetree@vger.kernel.org,
        linux-usb@vger.kernel.org, cheol.yong.kim@intel.com,
        qi-ming.wu@intel.com, yin1.li@intel.com
References: <20200611021246.3250-1-vadivel.muruganx.ramuthevar@linux.intel.com>
 <20200611021246.3250-3-vadivel.muruganx.ramuthevar@linux.intel.com>
 <20200611081254.GR2428291@smile.fi.intel.com>
From:   "Ramuthevar, Vadivel MuruganX" 
        <vadivel.muruganx.ramuthevar@linux.intel.com>
Message-ID: <21b5db0e-c45a-2255-0389-04b204685d63@linux.intel.com>
Date:   Thu, 11 Jun 2020 16:36:29 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.1
MIME-Version: 1.0
In-Reply-To: <20200611081254.GR2428291@smile.fi.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Andy,

Thank you so much for the review comments...

On 11/6/2020 4:12 pm, Andy Shevchenko wrote:
> On Thu, Jun 11, 2020 at 10:12:46AM +0800, Ramuthevar,Vadivel MuruganX wrote:
>> From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
>>
>> Add support for USB PHY on Intel LGM SoC.
> 
> ...
> 
>> +static int get_flipped(struct tca_apb *ta, bool *flipped)
>> +{
>> +	union extcon_property_value property;
>> +	int ret;
>> +
>> +	ret = extcon_get_property(ta->phy.edev, EXTCON_USB_HOST,
>> +				  EXTCON_PROP_USB_TYPEC_POLARITY, &property);
>> +	if (ret) {
>> +		dev_err(ta->phy.dev, "no polarity property from extcon\n");
> 
>> +		return false;
> 
> return ret;
Noted.
> 
>> +	}
>> +
>> +	*flipped = property.intval;
>> +
> 
>> +	return *flipped;
> 
> return 0;
Noted.
> 
>> +}
> 
> ...I suppose it should be as above.
> 
> ...
> 
>> +	ret = readl_poll_timeout(ctrl1, val, val & SRAM_INIT_DONE,
>> +				 10, 10 * 1000);
exceeds more than 80 characters, so checkpatch throws warnings, to avoid 
that move to next line.
> 
> On one line easier to read.
> 
>> +	if (ret) {
>> +		dev_err(ta->phy.dev, "SRAM init failed, 0x%x\n", val);
>> +		return ret;
>> +	}
> 
> ...
> 
>> +static int phy_set_vbus(struct usb_phy *phy, int on)
>> +{
>> +	struct tca_apb *ta = container_of(phy, struct tca_apb, phy);
> 
>> +	int ret = 0;
> 
> Assignment is redundant.
so you mean , should be declared as
int ret;
right?

> 
>> +
>> +	if (on) {
>> +		ret = regulator_enable(ta->vbus);
>> +		if (ret)
>> +			dev_err(ta->phy.dev, "regulator not enabled\n");
>> +	} else {
>> +		ret = regulator_disable(ta->vbus);
>> +		if (ret)
>> +			dev_err(ta->phy.dev, "regulator not disabled\n");
>> +	}
>> +
>> +	return ret;
>> +}
> 
> ...
> 
>> +	ret = get_flipped(ta, &flipped);
>> +	if (!ret)
>> +		dev_err(ta->phy.dev, "no polarity property from extcon\n");
> 
> This should be fixed accordingly.
Noted.
> 
> ...
> 
>> +		dev_info(ta->phy.dev, "connected%s\n",
>> +			 flipped ? " flipped" : "");
> 
> One line.
exceeds more than 80 characters, so checkpatch throw warnings, to avoid 
that moved to next line.

Regards
Vadivel
>