Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: gkrByYmdD0llxZ7os43nv0FkpVmwnSKutCp89rC1VpQzmeMhYGIycqf2zoUwCcvCKAsaN7jIk8
 2lHDAO4iPBjg==
IronPort-SDR: juYuwjBBW9pUdIFqtvG3zMWTcmKtppmN3Rnc6YnMclLnW8KezPcotPYDMWX4LzKxJg9MZTpMDO
 PXagRMx5znpw==
Date:   Thu, 11 Jun 2020 11:57:10 +0300
From:   Andy Shevchenko <andriy.shevchenko@intel.com>
To:     "Ramuthevar, Vadivel MuruganX" 
        <vadivel.muruganx.ramuthevar@linux.intel.com>
Cc:     linux-kernel@vger.kernel.org, balbi@kernel.org,
        p.zabel@pengutronix.de, gregkh@linuxfoundation.org,
        robh@kernel.org, devicetree@vger.kernel.org,
        linux-usb@vger.kernel.org, cheol.yong.kim@intel.com,
        qi-ming.wu@intel.com, yin1.li@intel.com
Subject: Re: [PATCH v2 2/2] usb: phy: Add USB3 PHY support for Intel LGM SoC
Message-ID: <20200611085710.GV2428291@smile.fi.intel.com>
References: <20200611021246.3250-1-vadivel.muruganx.ramuthevar@linux.intel.com>
 <20200611021246.3250-3-vadivel.muruganx.ramuthevar@linux.intel.com>
 <20200611081254.GR2428291@smile.fi.intel.com>
 <21b5db0e-c45a-2255-0389-04b204685d63@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <21b5db0e-c45a-2255-0389-04b204685d63@linux.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jun 11, 2020 at 04:36:29PM +0800, Ramuthevar, Vadivel MuruganX wrote:
> On 11/6/2020 4:12 pm, Andy Shevchenko wrote:
> > On Thu, Jun 11, 2020 at 10:12:46AM +0800, Ramuthevar,Vadivel MuruganX wrote:
> > > From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>

...

> > > +	ret = readl_poll_timeout(ctrl1, val, val & SRAM_INIT_DONE,
> > > +				 10, 10 * 1000);
> exceeds more than 80 characters, so checkpatch throws warnings, to avoid
> that move to next line.

> > On one line easier to read.

It's 82 characters. It's fine.

> > > +	if (ret) {
> > > +		dev_err(ta->phy.dev, "SRAM init failed, 0x%x\n", val);
> > > +		return ret;
> > > +	}

...

> > > +	int ret = 0;
> > 
> > Assignment is redundant.
> so you mean , should be declared as
> int ret;
> right?

Right.

...

> > > +		dev_info(ta->phy.dev, "connected%s\n",
> > > +			 flipped ? " flipped" : "");
> > 
> > One line.
> exceeds more than 80 characters, so checkpatch throw warnings, to avoid that
> moved to next line.

It's fine to have on one line.

And by the way, try new checkpatch.


-- 
With Best Regards,
Andy Shevchenko