Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp1200193ybg; Thu, 11 Jun 2020 03:43:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxsNNA3tw4fMMxjUoPJqvmehwKz0zVfxudKiXFqLmd//UrMKY2VYNcC8i9kGvhmLxY1YUxs X-Received: by 2002:a17:906:7c57:: with SMTP id g23mr6290631ejp.299.1591872236067; Thu, 11 Jun 2020 03:43:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591872236; cv=none; d=google.com; s=arc-20160816; b=wsEpBvcITUgJqoxf9d204V+ha6K1MIMO8mDQv1Qdh8u1+MPyvEpso0MRlQS0rQ8yTJ ZZIi+et0OIRq7BtCjKx4keavF1mhvlCweBzpUVMlX3jYyDOrug6wMr70SRtof6hRmSJT /91bi6MsNDlQXljJSAcSGXO+Lf//c/2kzx1kWOq8Sn3v8bBFohhWJ2igod2appfSIQzX ihudUp2Uh4Cx+yICLxsTAABlZl4dy+QY7azKpTZsw1SsDURY6Ef+8E0yQhtPKf0BF8pU 9AjCiGLhP5wuYdQQB8VK5x6gmaTWjvRM5M+AbmxyU8zQK8aftp0UknCyhEEOkTaoRNDw 1y2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:ironport-sdr:ironport-sdr; bh=gX4BToq62nmuEDxhUp1njKt6wD63It11yDwHvsXpstM=; b=Hsni4CHrfVXdFIxpKmOEwfngNP8UcEJVesrN26FnROkJrMbPLLUuJCUzJ9cZwRVj71 b+xU2RclZjOg1Bnd+KitGVSqXK5ceS8edzXWw6cxGIn36XAREXa++JgoYD8ell0hIR2o jroottOBfAm9OUVIXNNJ7kqP/tzcaiT9sVAspVI9mlWvI0mcanrubZ/EiuWOgZFQO42O aBnFpSZjpBOewE2f02oAjakndkH7ETS14ZOULwdJCY/oM088ezZCjLD0RrVT+7xaiuTj 5GG4vlqWSI+6XmT4hPzCnK05ndsZyLjFXIaadf7vmTqsn2mFvrFiMa9sBI3Fv1Do0Vjw 0wCw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k3si1766720ejc.102.2020.06.11.03.43.33; Thu, 11 Jun 2020 03:43:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727089AbgFKKjz (ORCPT + 99 others); Thu, 11 Jun 2020 06:39:55 -0400 Received: from mga02.intel.com ([134.134.136.20]:47919 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726864AbgFKKjw (ORCPT ); Thu, 11 Jun 2020 06:39:52 -0400 IronPort-SDR: rvW4FZpXds/zgrK11PAcerrWa3MUF6c5bAK1d9tW0D2laaa2B2GBHO4HBJ7ednGs8FQbgi4Uqq U3XXfluWVsjg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2020 03:39:51 -0700 IronPort-SDR: n1oDAK+8ZZRCo4XPJCfRE/6cleWAyxhiJPzudO4+U5xSV/Bp68ZuhzSbxXvQkATLEVN8eu6V0y T7NxhaoTxIKA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,499,1583222400"; d="scan'208";a="380349596" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.163]) by fmsmga001.fm.intel.com with SMTP; 11 Jun 2020 03:39:48 -0700 Received: by lahna (sSMTP sendmail emulation); Thu, 11 Jun 2020 13:39:47 +0300 Date: Thu, 11 Jun 2020 13:39:47 +0300 From: Mika Westerberg To: Luis Alberto Herrera Cc: tudor.ambarus@microchip.com, Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Jethro Beekman , Boris Brezillon , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: revert "spi-nor: intel: provide a range for poll_timout" Message-ID: <20200611103947.GC247495@lahna.fi.intel.com> References: <20200610224652.64336-1-luisalberto@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200610224652.64336-1-luisalberto@google.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 10, 2020 at 10:46:49PM +0000, Luis Alberto Herrera wrote: > This change reverts aba3a882a178: "mtd: spi-nor: intel: provide a range > for poll_timout". That change introduces a performance regression when > reading sequentially from flash. Logging calls to intel_spi_read without > this change we get: > > Start MTD read > [ 20.045527] intel_spi_read(from=1800000, len=400000) > [ 20.045527] intel_spi_read(from=1800000, len=400000) > [ 282.199274] intel_spi_read(from=1c00000, len=400000) > [ 282.199274] intel_spi_read(from=1c00000, len=400000) > [ 544.351528] intel_spi_read(from=2000000, len=400000) > [ 544.351528] intel_spi_read(from=2000000, len=400000) > End MTD read > > With this change: > > Start MTD read > [ 21.942922] intel_spi_read(from=1c00000, len=400000) > [ 21.942922] intel_spi_read(from=1c00000, len=400000) > [ 23.784058] intel_spi_read(from=2000000, len=400000) > [ 23.784058] intel_spi_read(from=2000000, len=400000) > [ 25.625006] intel_spi_read(from=2400000, len=400000) > [ 25.625006] intel_spi_read(from=2400000, len=400000) > End MTD read > > Signed-off-by: Luis Alberto Herrera Acked-by: Mika Westerberg