Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <1591872811.5140.41.camel@linux.ibm.com>
Subject: Re: [LKP] [ima] 8eb613c0b8: stress-ng.icache.ops_per_sec -84.2%
 regression
From:   Mimi Zohar <zohar@linux.ibm.com>
To:     Xing Zhengjun <zhengjun.xing@linux.intel.com>,
        kernel test robot <rong.a.chen@intel.com>
Cc:     Lakshmi Ramasubramanian <nramas@linux.microsoft.com>,
        LKML <linux-kernel@vger.kernel.org>, lkp@lists.01.org
Date:   Thu, 11 Jun 2020 06:53:31 -0400
In-Reply-To: <cb6a244c-5bab-1ccc-4386-e1b1caf48eb3@linux.intel.com>
References: <20200603091150.GH12456@shao2-debian>
         <099cfe59-1601-a0fc-3849-13eee8754130@linux.intel.com>
         <1591797185.5140.2.camel@linux.ibm.com>
         <cb6a244c-5bab-1ccc-4386-e1b1caf48eb3@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 2020-06-11 at 15:10 +0800, Xing Zhengjun wrote:
> On 6/10/2020 9:53 PM, Mimi Zohar wrote:
>  	ucode: 0x500002c
> > 
> > Does the following change resolve it?
> > 
> > diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c
> > index c44414a7f82e..78e1dfc8a3f2 100644
> > --- a/security/integrity/ima/ima_main.c
> > +++ b/security/integrity/ima/ima_main.c
> > @@ -426,7 +426,8 @@ int ima_file_mprotect(struct vm_area_struct *vma, unsigned long prot)
> >   	int pcr;
> >   
> >   	/* Is mprotect making an mmap'ed file executable? */
> > -	if (!vma->vm_file || !(prot & PROT_EXEC) || (vma->vm_flags & VM_EXEC))
> > +	if (!(ima_policy_flag & IMA_APPRAISE) || !vma->vm_file ||
> > +	    !(prot & PROT_EXEC) || (vma->vm_flags & VM_EXEC))
> >   		return 0;
> >   
> >   	security_task_getsecid(current, &secid);
> > 
> Thanks. I test the change, it can resolve the regression.

Thanks!  Can I get your "Tested-by" tag?

Mimi