Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751034AbWCVUIM (ORCPT ); Wed, 22 Mar 2006 15:08:12 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751037AbWCVUIM (ORCPT ); Wed, 22 Mar 2006 15:08:12 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:62147 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S1751011AbWCVUIL (ORCPT ); Wed, 22 Mar 2006 15:08:11 -0500 Subject: Re: [PATCH] hpet header sanitization From: Arjan van de Ven To: "Randy.Dunlap" Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, clemens@ladisch.de In-Reply-To: <20060322092649.d967c47a.rdunlap@xenotime.net> References: <20060321144607.153d1943.rdunlap@xenotime.net> <20060321161303.53c2895f.akpm@osdl.org> <20060321162630.d995c63c.rdunlap@xenotime.net> <1143018140.2955.45.camel@laptopd505.fenrus.org> <20060322092649.d967c47a.rdunlap@xenotime.net> Content-Type: text/plain Date: Wed, 22 Mar 2006 21:08:02 +0100 Message-Id: <1143058082.2955.68.camel@laptopd505.fenrus.org> Mime-Version: 1.0 X-Mailer: Evolution 2.2.3 (2.2.3-2.fc4) Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1282 Lines: 37 On Wed, 2006-03-22 at 09:26 -0800, Randy.Dunlap wrote: > On Wed, 22 Mar 2006 10:02:19 +0100 Arjan van de Ven wrote: > > > On Tue, 2006-03-21 at 16:26 -0800, Randy.Dunlap wrote: > > > On Tue, 21 Mar 2006 16:13:03 -0800 Andrew Morton wrote: > > > > > > > "Randy.Dunlap" wrote: > > > > > > > > > > From: Randy Dunlap > > > > > > > > > > Add __KERNEL__ block. > > > > > Use __KERNEL__ to allow ioctl interface to be usable. > > > > > > > > hm, why? > > > > > > because there is a test/example source file in (inside) > > > Documentation/hpet.txt that won't build otherwise. > > > And because hpet.h contains _userspace_ ioctl interface struct > > > and macros... > > > > > > then please split the header in 2 parts; one for the kernel > > and one for userspace > > so would you tell me what the purpose (use) of __KERNEL__ > is meant to be, please? for legacy headers.. the same ;) Thats no reason to fix up new cases... things should get better not just get a small rubber bandaid... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/