Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp1470510ybg; Thu, 11 Jun 2020 10:37:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyL7+j9BSW9okbTsHMUSdb2zD+5Y69vbVNHXMVduBk8slxvkA9uBOSM+1W1wW7mJe4Wm5rC X-Received: by 2002:a50:ee93:: with SMTP id f19mr7659524edr.256.1591897078644; Thu, 11 Jun 2020 10:37:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591897078; cv=none; d=google.com; s=arc-20160816; b=BTIwnZS9ZeV25I88sunkQUvaRh3ayWtIWRe2jGnK081q5cFi1hAHtRBdglZ8cRuCEv 6RGn680XTDsBnwHiM9xiST+RxRMR1hiUKq6EBXQuVXHH4KD59N4LUfaZ4AwpxJgC5M/R htPNQlzXOgUFqh/C9b9EWZyZ8M1f1hPpGfWlO0BqHRkdDMJBUJ17gxql/Ayd+x6DjVZN aVxibg3QRmo4dDg5yS5da+Q0ay5weQqSSQByzWXFAKzhIHrizPf+AX9l/ZQk/jC/r+5b T+lg4OHwgvedc6h4kziaDW0ZkN/7VKbYwiy4/Z1qlc217yWBTJ16vjH3d/EDSlmvSe3z 0FUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=XLbENzTAZMsx6589A6q18FZsHVyr6g7BAe5tWoSZfFw=; b=h4Hi9rm3kmTqWGC6/qYScgE2gjTX7syzpoJ6GEqrjoTGExg3rYZVm1zalf1SMgrRGG CopnToJyZ65Pa1TwKzOgOVihRe4yuiS53YSW5/lm94oMFHm0kYt85CQfdxpPRsaQv8SG 9Yc18dZFXKT+X4rF42YIGmbEqZNaNQe1u5L0xWgRY0+tuhl3BzU1fpWQlSLA+JuJJLQ2 i8tXptcxUpWSuVjScpW3NJ8MFCk/mJl6k2OMiYRPrv+YjjAdYATOoSXD+6kTokdOIqVy 2cgMFORPEriCCq7eJcqtnJGqsZnRcduYK8E32UWluDLdSqCeTdUQS45A1tkBOrzyJrxw kRPQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y7si2011166edo.557.2020.06.11.10.37.37; Thu, 11 Jun 2020 10:37:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728385AbgFKOaR (ORCPT + 99 others); Thu, 11 Jun 2020 10:30:17 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:52728 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728323AbgFKOaR (ORCPT ); Thu, 11 Jun 2020 10:30:17 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jjODf-0000ff-14; Thu, 11 Jun 2020 14:30:15 +0000 From: Colin King To: linux-block@vger.kernel.org, Jens Axboe Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] pktcdvd: remove redundant initialization of variable ret Date: Thu, 11 Jun 2020 15:30:14 +0100 Message-Id: <20200611143014.925317-1-colin.king@canonical.com> X-Mailer: git-send-email 2.27.0.rc0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King The variable ret is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/block/pktcdvd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c index 0b944ac96d6b..27a33adc41e4 100644 --- a/drivers/block/pktcdvd.c +++ b/drivers/block/pktcdvd.c @@ -1613,7 +1613,7 @@ static noinline_for_stack int pkt_get_last_written(struct pktcdvd_device *pd, disc_information di; track_information ti; __u32 last_track; - int ret = -1; + int ret; ret = pkt_get_disc_info(pd, &di); if (ret) -- 2.27.0.rc0