Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: PsbZ79/vWtTOXbbjBo61mRiPmZUMnqXNuM/Qc+w4P8Gu8myqKohjee6SNkWJi05SUwsWfPP2In
 nlEwdmGcf6O3epFZas+dnW5Dce8TIDy6uJ/KoHGWF7yhF6lxdSXkfo5iM81SLalq0U6e852stl
 2S0KacSxORAgcK+04R1QxnjhBoRuSq7WxVypBZKUJTvEcb3rqgo0Mig/SstsodapVvii8rxz/T
 gc1bN0mWuEHIhc7llVljsDpRvOdltsaRncXvnHzCnoNt3AbH6tTAXeT9dhZR9+8/L+BS4xQdk2
 1eg=
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To:     Logan Gunthorpe <logang@deltatee.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        Christoph Hellwig <hch@lst.de>,
        Sagi Grimberg <sagi@grimberg.me>,
        Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
        Max Gurtovoy <maxg@mellanox.com>,
        Stephen Bates <sbates@raithlin.com>
Subject: Re: [PATCH v13 0/9] nvmet: add target passthru commands support
Thread-Topic: [PATCH v13 0/9] nvmet: add target passthru commands support
Thread-Index: AQHWKhRsU0RUeVdtwkqjNhBWhX0tSw==
Date:   Thu, 11 Jun 2020 19:16:53 +0000
Message-ID: <BYAPR04MB4965CEDB8E3AE4B7F4C527AF86800@BYAPR04MB4965.namprd04.prod.outlook.com>
References: <20200514172253.6445-1-logang@deltatee.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 58e1a248-9d32-4f93-168b-08d80e3c0063
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jun 2020 19:16:53.9336
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: q4hjPUjTqkG9UXwUwcwL0C9mUN8x6JBW0ZXwwa1hCmEZttQQUjypkpGOIBp0p4ia4AJQhepPMi/Jg9CRv3Gattnm3GidJZ9J/lKiNhjYezg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB3861
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 5/14/20 10:23 AM, Logan Gunthorpe wrote:=0A=
> This is v13 of the passthru patchset which is mostly a resend of v12=0A=
> with Sagi's reviewed-by tags collected.=0A=
> =0A=
> Below, I'll reiterrate some points I made previously that haven't been=0A=
> responded to:=0A=
> =0A=
> I don't think cloning the ctrl_id or the subsysnqn is a good idea.=0A=
> I sent an email trying to explain why here[1] but there was no response.=
=0A=
> In short, I think cloning the ctrl_id will break multipathing over=0A=
> fabrics and copying the subsysnqn only has the effect of breaking=0A=
> loopback; the user can always copy the underlying subsysnqn if it=0A=
> makes sense for their overall system.=0A=
> =0A=
> I maintain overriding the CMIC bit in the ctrl id is necessary to=0A=
> allow multipath over fabrics even if the underlying device did=0A=
> not support multipath.=0A=
> =0A=
> I also think the black list for admin commands is appropriate, and I=0A=
> added it based on Sagi's feedback[2]. There are plenty of commands that=
=0A=
> may be dangerous like firmware update and format NVM commands, and NS=0A=
> attach commands won't work out of the box because we don't copy the=0A=
> ctrl_id. It seems like there's more commands to be careful of than ones=
=0A=
> that are that are obviously acceptable. So, I think the prudent course=0A=
> is blacklisting by default until someone has a usecase and can show=0A=
> the command is safe seems and makes sense. For our present use cases,=0A=
> the identify, log page and vendor specific commands are all that we=0A=
> care about.=0A=
> =0A=
> A git branch is available here and is based on v5.7-rc5:=0A=
> =0A=
> https://github.com/sbates130272/linux-p2pmem  nvmet_passthru_v13=0A=
> =0A=
> [1]https://lore.kernel.org/linux-block/247eca47-c3bc-6452-fb19-f7aa27b05a=
60@deltatee.com/=0A=
> [2]https://lore.kernel.org/linux-block/e4430207-7def-8776-0289-0d58689dc0=
cd@grimberg.me/=0A=
> =0A=
> --=0A=
> =0A=
> v13 Changes:=0A=
>    1. Rebased onto v5.7-rc5=0A=
>    2. Collected Sagi's Reviewed-by tags=0A=
=0A=
Are you planning to send V14 based on nvme-5.9 branch ?=0A=