Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp1606349ybg; Thu, 11 Jun 2020 14:28:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw68CkQWURsBVpqUSgpRzRVF4HLPSxLJIEz3IynTigeO/sJGbqPJGIMMbVlRjIYTCWbUXqh X-Received: by 2002:a05:6402:8d1:: with SMTP id d17mr8425599edz.38.1591910899977; Thu, 11 Jun 2020 14:28:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591910899; cv=none; d=google.com; s=arc-20160816; b=qb47EL2DgF+RMiE7J/PZtunOKBl4m9hHQa/00QT2RQVJr1gGc9mKsLren0id5S+Xlb 0i2AAid0I2qJ9k48QJLtRqnJPTHZoTOp7j4YOfM6KUG+f8At3xlz7FpVPPLpqEN39qee EAtjB+OSmq5BKKg/MIP63zJlce1ZMyHtgiSbkalYcw6klb74BIZZCC+nMklvd8mEelvP WY5bD9uuxKDDqIdBvbm6ts7X4o65A1uSY7gphCdhJf8566vegWBUefZMaL1NlS1Pr8mQ if88lc3+ltPEK0AmJx9Fb/0QGhyx6g1wKV/aqcFM0UzUiXv4198CkR35OPYcz6++805z FYYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:reply-to; bh=cqhNe/2SPywZILbgE/+22HPYa6yvMo3aZHkQAAKpinI=; b=D1BqXiouCMNXqQbesuNyXwVrtIH4mIjdwnGgF/MnltSmClbvGIOI4f9sR9BDtkjkoj W/Sj8XAwJh8aD47aN58t3K4BH+G/9Wgt9DExM1cpPUekU7aOmL1aWpfwIqlGPi4Jz+q+ WmbAw5Vz9MOYAo9ryAqmzGeR1RcUan11SI/CNiecgTJnOS1Qg6m0mPdwQLn71qzJJazD 40YUGh9UgLvS3DSonp5WDfaWD7lLyom2QOc4Jf1NE3DDAoc/UnvlKgjqNc5yIFgtjZRP Y47jJJqOOBGReh9G5/oF4u75N2mEwg3Yfr6cPW/VzNAbKMf+lOCN8IhJxmctxSMT/HzO PP7w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d3si2831912edl.218.2020.06.11.14.27.57; Thu, 11 Jun 2020 14:28:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726332AbgFKVZr (ORCPT + 99 others); Thu, 11 Jun 2020 17:25:47 -0400 Received: from mail-lj1-f193.google.com ([209.85.208.193]:45816 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726153AbgFKVZq (ORCPT ); Thu, 11 Jun 2020 17:25:46 -0400 Received: by mail-lj1-f193.google.com with SMTP id i27so8647424ljb.12 for ; Thu, 11 Jun 2020 14:25:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=cqhNe/2SPywZILbgE/+22HPYa6yvMo3aZHkQAAKpinI=; b=KQ2LFRHVlfWb54Q/n0NOXIVzPOfMTdMoeP3oDG+xljESn94p5YTNof/c4T19cVx5+q 5uD+fYSbbRWY0nGjrgbuKhhVQXdW1BZB+u/KEW8rAkxvouPoRTspnnF44ViM+pxt3zQU 3J9cCvhjqoZgqH79kJ0ddpDSvPrTfV+4msbRy96V5eIdhcsSCafPfJ7td1DMiIZx/eiX GtOVmJnO3HwdYJLTYmV03fjAYeqDj0Kbrlmt3p4q/aTyWTD7ch1r7l4gjp+bAIgRy067 VIld6qhG3e4PzJrp2l+gzS/vKDUlhETUWB4B8cRFxJxC/L19UoJjvxe3vkxj/wz09dGH Ytwg== X-Gm-Message-State: AOAM533BxD6MdtH89F1Q1Ky9ZZtN2uFMcICa4YAiXvCRYfZx9XpQZzMH 1lxDPuqKZMF4azJ5tj+45Eo= X-Received: by 2002:a2e:8ec1:: with SMTP id e1mr4911933ljl.23.1591910743441; Thu, 11 Jun 2020 14:25:43 -0700 (PDT) Received: from [10.68.32.147] (broadband-37-110-38-130.ip.moscow.rt.ru. [37.110.38.130]) by smtp.gmail.com with ESMTPSA id e9sm1016116ljn.61.2020.06.11.14.25.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jun 2020 14:25:42 -0700 (PDT) Reply-To: efremov@linux.com Subject: Re: [Cocci] [PATCH v2 4/4] coccinelle: api: add selfcheck for memdup_user rule To: Julia Lawall Cc: linux-kernel@vger.kernel.org, cocci@systeme.lip6.fr References: <20200608150038.223747-1-efremov@linux.com> <20200608150038.223747-5-efremov@linux.com> From: Denis Efremov Autocrypt: addr=efremov@linux.com; keydata= mQINBFsJUXwBEADDnzbOGE/X5ZdHqpK/kNmR7AY39b/rR+2Wm/VbQHV+jpGk8ZL07iOWnVe1 ZInSp3Ze+scB4ZK+y48z0YDvKUU3L85Nb31UASB2bgWIV+8tmW4kV8a2PosqIc4wp4/Qa2A/ Ip6q+bWurxOOjyJkfzt51p6Th4FTUsuoxINKRMjHrs/0y5oEc7Wt/1qk2ljmnSocg3fMxo8+ y6IxmXt5tYvt+FfBqx/1XwXuOSd0WOku+/jscYmBPwyrLdk/pMSnnld6a2Fp1zxWIKz+4VJm QEIlCTe5SO3h5sozpXeWS916VwwCuf8oov6706yC4MlmAqsQpBdoihQEA7zgh+pk10sCvviX FYM4gIcoMkKRex/NSqmeh3VmvQunEv6P+hNMKnIlZ2eJGQpz/ezwqNtV/przO95FSMOQxvQY 11TbyNxudW4FBx6K3fzKjw5dY2PrAUGfHbpI3wtVUNxSjcE6iaJHWUA+8R6FLnTXyEObRzTS fAjfiqcta+iLPdGGkYtmW1muy/v0juldH9uLfD9OfYODsWia2Ve79RB9cHSgRv4nZcGhQmP2 wFpLqskh+qlibhAAqT3RQLRsGabiTjzUkdzO1gaNlwufwqMXjZNkLYu1KpTNUegx3MNEi2p9 CmmDxWMBSMFofgrcy8PJ0jUnn9vWmtn3gz10FgTgqC7B3UvARQARAQABtCFEZW5pcyBFZnJl bW92IDxlZnJlbW92QGxpbnV4LmNvbT6JAlcEEwEIAEECGwMFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4ACGQEWIQR2VAM2ApQN8ZIP5AO1IpWwM1AwHwUCXsQtuwUJB31DPwAKCRC1IpWwM1Aw H3dQD/9E/hFd2yPwWA5cJ5jmBeQt4lBi5wUXd2+9Y0mBIn40F17Xrjebo+D8E5y6S/wqfImW nSDYaMfIIljdjmUUanR9R7Cxd/Z548Qaa4F1AtB4XN3W1L49q21h942iu0yxSLZtq9ayeja6 flCB7a+gKjHMWFDB4nRi4gEJvZN897wdJp2tAtUfErXvvxR2/ymKsIf5L0FZBnIaGpqRbfgG Slu2RSpCkvxqlLaYGeYwGODs0QR7X2i70QGeEzznN1w1MGKLOFYw6lLeO8WPi05fHzpm5pK6 mTKkpZ53YsRfWL/HY3kLZPWm1cfAxa/rKvlhom+2V8cO4UoLYOzZLNW9HCFnNxo7zHoJ1shR gYcCq8XgiJBF6jfM2RZYkOAJd6E3mVUxctosNq6av3NOdsp1Au0CYdQ6Whi13azZ81pDlJQu Hdb0ZpDzysJKhORsf0Hr0PSlYKOdHuhl8fXKYOGQxpYrWpOnjrlEORl7NHILknXDfd8mccnf 4boKIZP7FbqSLw1RSaeoCnqH4/b+ntsIGvY3oJjzbQVq7iEpIhIoQLxeklFl1xvJAOuSQwII I9S0MsOm1uoT/mwq+wCYux4wQhALxSote/EcoUxK7DIW9ra4fCCo0bzaX7XJ+dJXBWb0Ixxm yLl39M+7gnhvZyU+wkTYERp1qBe9ngjd0QTZNVi7MbkCDQRbCVF8ARAA3ITFo8OvvzQJT2cY nPR718Npm+UL6uckm0Jr0IAFdstRZ3ZLW/R9e24nfF3A8Qga3VxJdhdEOzZKBbl1nadZ9kKU nq87te0eBJu+EbcuMv6+njT4CBdwCzJnBZ7ApFpvM8CxIUyFAvaz4EZZxkfEpxaPAivR1Sa2 2x7OMWH/78laB6KsPgwxV7fir45VjQEyJZ5ac5ydG9xndFmb76upD7HhV7fnygwf/uIPOzNZ YVElGVnqTBqisFRWg9w3Bqvqb/W6prJsoh7F0/THzCzp6PwbAnXDedN388RIuHtXJ+wTsPA0 oL0H4jQ+4XuAWvghD/+RXJI5wcsAHx7QkDcbTddrhhGdGcd06qbXe2hNVgdCtaoAgpCEetW8 /a8H+lEBBD4/iD2La39sfE+dt100cKgUP9MukDvOF2fT6GimdQ8TeEd1+RjYyG9SEJpVIxj6 H3CyGjFwtIwodfediU/ygmYfKXJIDmVpVQi598apSoWYT/ltv+NXTALjyNIVvh5cLRz8YxoF sFI2VpZ5PMrr1qo+DB1AbH00b0l2W7HGetSH8gcgpc7q3kCObmDSa3aTGTkawNHzbceEJrL6 mRD6GbjU4GPD06/dTRIhQatKgE4ekv5wnxBK6v9CVKViqpn7vIxiTI9/VtTKndzdnKE6C72+ jTwSYVa1vMxJABtOSg8AEQEAAYkCPAQYAQgAJgIbDBYhBHZUAzYClA3xkg/kA7UilbAzUDAf BQJexC4MBQkHfUOQAAoJELUilbAzUDAfPYoQAJdBGd9WZIid10FCoI30QXA82SHmxWe0Xy7h r4bbZobDPc7GbTHeDIYmUF24jI15NZ/Xy9ADAL0TpEg3fNVad2eslhCwiQViWfKOGOLLMe7v zod9dwxYdGXnNRlW+YOCdFNVPMvPDr08zgzXaZ2+QJjp44HSyzxgONmHAroFcqCFUlfAqUDO T30gV5bQ8BHqvfWyEhJT+CS3JJyP8BmmSgPa0Adlp6Do+pRsOO1YNNO78SYABhMi3fEa7X37 WxL31TrNCPnIauTgZtf/KCFQJpKaakC3ffEkPhyTjEl7oOE9xccNjccZraadi+2uHV0ULA1m ycHhb817A03n1I00QwLf2wOkckdqTqRbFFI/ik69hF9hemK/BmAHpShI+z1JsYT9cSs8D7wb aF/jQVy4URensgAPkgXsRiboqOj/rTz9F5mpd/gPU/IOUPFEMoo4TInt/+dEVECHioU3RRrW EahrGMfRngbdp/mKs9aBR56ECMfFFUPyI3VJsNbgpcIJjV/0N+JdJKQpJ/4uQ2zNm0wH/RU8 CRJvEwtKemX6fp/zLI36Gvz8zJIjSBIEqCb7vdgvWarksrhmi6/Jay5zRZ03+k6YwiqgX8t7 ANwvYa1h1dQ36OiTqm1cIxRCGl4wrypOVGx3OjCar7sBLD+NkwO4RaqFvdv0xuuy4x01VnOF Message-ID: <320775f0-8ff6-5ada-9160-67d9683d7465@linux.com> Date: Fri, 12 Jun 2020 00:25:53 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/9/20 7:22 PM, Julia Lawall wrote: > > > On Mon, 8 Jun 2020, Denis Efremov wrote: > >> Check that the rule matches vmemdup_user implementation. >> memdup_user is out of scope because we are not matching >> kmalloc_track_caller() function. > > Is this a bit over-enginered? Last patch it's just a PoC. Patches 1-3 are independent from 4. > More precisely, even if it is nice to check > that the API definition has the expected behavior, does it make sense to > do it in one case but not the other? Yes, I also don't like it. However, I doubt that we need to match kmalloc_track_caller. Thanks, Denis