Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Arvind Sankar <nivedita@alum.mit.edu>
Date:   Thu, 11 Jun 2020 17:44:13 -0400
To:     Nick Desaulniers <ndesaulniers@google.com>
Cc:     Arvind Sankar <nivedita@alum.mit.edu>,
        Masahiro Yamada <masahiroy@kernel.org>,
        Fangrui Song <maskray@google.com>,
        Rong Chen <rong.a.chen@intel.com>,
        kernel test robot <lkp@intel.com>, kbuild-all@lists.01.org,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Makefile: Improve compressed debug info support detection
Message-ID: <20200611214413.GA3924125@rani.riverdale.lan>
References: <20200610063715.v2qrqvwtegdxdwzl@google.com>
 <20200610191106.2662548-1-nivedita@alum.mit.edu>
 <CAKwvOdnF9xhrs+FP4QXo6uXxgHMfHO8NvPYs1=KDE2ZyhCw2QQ@mail.gmail.com>
 <20200610233046.GA2941409@rani.riverdale.lan>
 <20200610233954.GB2941409@rani.riverdale.lan>
 <CAKwvOd=UyEPOx5M0w+uwiYwE5fY-A5vDmuvPnWs_pK4zW4RH-w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAKwvOd=UyEPOx5M0w+uwiYwE5fY-A5vDmuvPnWs_pK4zW4RH-w@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jun 11, 2020 at 01:44:53PM -0700, Nick Desaulniers wrote:
> On Wed, Jun 10, 2020 at 4:39 PM Arvind Sankar <nivedita@alum.mit.edu> wrote:
> >
> > On Wed, Jun 10, 2020 at 07:30:46PM -0400, Arvind Sankar wrote:
> > > On Wed, Jun 10, 2020 at 02:27:55PM -0700, Nick Desaulniers wrote:
> > >
> > > No, as-option does invoke the assembler. The problem here is that with
> > > -Wa, the option is only seen by the assembler, not the gcc driver. So it
> > > will succeed because the assembler supports it, but it will not test
> > > whether the gcc driver also supports it.
> > >
> >
> > I think in theory another way to fix it is to just use -Wa even for
> > CFLAGS, assuming the compiler itself doesn't have to do anything with
> > the option and it's purely an assembler thing. Then you'd just do the as
> > and ld tests.
> 
> I don't think the CFLAGS are used for .S source files though.  We may
> drive assembler via the compiler, but AFLAGS are used in place of
> CFLAGS IIRC.  (eh, maybe not for ARCH=arc, ARCH=sh, ARCH=csky,
> ARCH=mips)
> 
> -- 
> Thanks,
> ~Nick Desaulniers

I meant just replace
	KBUILD_CFLAGS += -gz=zlib
with
	KBUILD_CFLAGS += -Wa,--compress-debug-sections=zlib
leaving KBUILD_AFLAGS the same as before
	KBUILD_AFLAGS += -Wa,--compress-debug-sections=zlib

This would avoid depending on the subtleties in the gcc driver's support
for this option. But -gz=zlib is passed to cc1 as well as the assembler,
so I'm not sure if there would be some loss from not passing it to the
compiler.