Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Robin Gong <yibin.gong@nxp.com>
To:     Krzysztof Kozlowski <krzk@kernel.org>,
        Vinod Koul <vkoul@kernel.org>,
        Dan Williams <dan.j.williams@intel.com>,
        Peng Ma <peng.ma@nxp.com>, Fabio Estevam <festevam@gmail.com>,
        "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/2] dmaengine: fsl-edma: Add lockdep assert for exported
 function
Thread-Topic: [PATCH 1/2] dmaengine: fsl-edma: Add lockdep assert for exported
 function
Thread-Index: AQHWP+pTL/vNe9LSdkC2zrFncJYm2qjUQMKQ
Date:   Fri, 12 Jun 2020 02:25:23 +0000
Message-ID: <VE1PR04MB663853E48FC2DA385134C66A89810@VE1PR04MB6638.eurprd04.prod.outlook.com>
References: <1591877861-28156-1-git-send-email-krzk@kernel.org>
In-Reply-To: <1591877861-28156-1-git-send-email-krzk@kernel.org>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: d783d9d3-1fe4-44f3-4cca-08d80e77dc71
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jun 2020 02:25:23.0837
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /+UQVWm82z8Kz0uilLjSliS4/vag7mtsOkye02ciVpSofeJ8nqxVPD26HXF3uOBopX1uZK2Xv4J6UjYr3xze0Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6352
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2020/06/11 20:18 Krzysztof Kozlowski <krzk@kernel.org> wrote:
> Add lockdep assert for an exported function expected to be called under s=
pin
> lock.  Since this function is called in different modules, the lockdep as=
sert will
> be self-documenting note about need for locking.
>=20
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Robin Gong <yibin.gong@nxp.com>=20
> ---
>  drivers/dma/fsl-edma-common.c | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/drivers/dma/fsl-edma-common.c
> b/drivers/dma/fsl-edma-common.c index 5697c3622699..4550818cca4a
> 100644
> --- a/drivers/dma/fsl-edma-common.c
> +++ b/drivers/dma/fsl-edma-common.c
> @@ -589,6 +589,8 @@ void fsl_edma_xfer_desc(struct fsl_edma_chan
> *fsl_chan)  {
>  	struct virt_dma_desc *vdesc;
>=20
> +	lockdep_assert_held(&fsl_chan->vchan.lock);
> +
>  	vdesc =3D vchan_next_desc(&fsl_chan->vchan);
>  	if (!vdesc)
>  		return;
> --
> 2.7.4