Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp244095ybg; Thu, 11 Jun 2020 23:47:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw4ammO9s+Xi1wxe8PaqXAgBk95kYyoGOhC2rF0ZqYCbRwSe1TZLZtHCjUYrYcSGjmW3P6d X-Received: by 2002:a17:906:fb19:: with SMTP id lz25mr12286695ejb.349.1591944440051; Thu, 11 Jun 2020 23:47:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591944440; cv=none; d=google.com; s=arc-20160816; b=cdHXu/oZ14lnmADDs2QzvSJSCBzd6+LB0cvxtcTKOWCbArOh6MmEufDO+ldZ3gBzFJ VGr2NaIozM6bj5e2WEAWUFPzd+HwyDZVk28XXx6nhYWIDM9uZwyG3tQCnC25Fg9ePoyb semLKlyHDWu4/HZik1u8vEoRKYfv2iwAOtPsN5mRBK2aeLhSXyQOy9uVgxGjjn/T2TeA 4dikNGGvjOMBS9a8va3a1Tlyg7Wc6kpoqRkp6nKOKBTUWh+30BS2EhVjIdHnQCfNmpfi isof/AYpm39nd8aX8bPClbpWGvCyPFQ9934GX/iUUyizyvSbXafNyfOxUmu9u4tmWqOG WTcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=5UhtuP90l943Isqu6Ks89etrSpmI2RwrlhSkwDRnr7w=; b=OlOu0Q14mI6nJZqhMTnxQX0iouzowGbflxQpNHAU4VKcGOFb3hqXnxAl7LD/7Akkya wCZwjjRPmETVUdZoyRbWlAm+OTDpTJk1gKwielTxNrdJUlQpW8dz9HTNZm4fa4dBC7Ls e05knqD0cSynPOAwvQfH2DG1bPj+BqlSz/E7JXRlmZTpotYSplvf7JTzHxLu4N7IdKic MgHL1FqV/Rn1Bj3iRTxrb8XUVWCwb8idEpBxL++LnkhHPM7FTO7k1O/8Y6aR9vif26bw QZXntB4b4kHne0XxRdXIZ3XqsZPYlf66AoD+TNflnrI6glenERAxWiomhXKSCWiv3oaV Obhg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=KDIb675c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o13si3044877edv.186.2020.06.11.23.46.57; Thu, 11 Jun 2020 23:47:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=KDIb675c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726529AbgFLGnB (ORCPT + 99 others); Fri, 12 Jun 2020 02:43:01 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:57228 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726300AbgFLGnB (ORCPT ); Fri, 12 Jun 2020 02:43:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591944179; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5UhtuP90l943Isqu6Ks89etrSpmI2RwrlhSkwDRnr7w=; b=KDIb675cJ0bDbkf24x/IkjlXhwtru3ryuXqBwqUGXOsJv6CFy6s5bjZWoeiSxIG2nayw46 kiNwBxvNTjClgOHYlfeiZkDJyalVo67aIj28uWFPzT0PxHSJJXMQm1Dmhmqx/D29nLexzZ Bf4vsuwYLbyaJMfJboKFz92+dmn2XTY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-503-MK4jfssWMfSNJ0xQZQHuzw-1; Fri, 12 Jun 2020 02:42:55 -0400 X-MC-Unique: MK4jfssWMfSNJ0xQZQHuzw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6C1F6801504; Fri, 12 Jun 2020 06:42:53 +0000 (UTC) Received: from carbon (unknown [10.40.208.9]) by smtp.corp.redhat.com (Postfix) with ESMTP id 992705D9CA; Fri, 12 Jun 2020 06:42:48 +0000 (UTC) Date: Fri, 12 Jun 2020 08:42:44 +0200 From: Jesper Dangaard Brouer To: Gaurav Singh Cc: Alexei Starovoitov , Daniel Borkmann , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , KP Singh , netdev@vger.kernel.org (open list:XDP (eXpress Data Path)), bpf@vger.kernel.org (open list:XDP (eXpress Data Path)), linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH] xdp_rxq_info_user: Replace malloc/memset w/calloc Message-ID: <20200612084244.4ab4f6c6@carbon> In-Reply-To: <20200612003640.16248-1-gaurav1086@gmail.com> References: <20200611150221.15665-1-gaurav1086@gmail.com> <20200612003640.16248-1-gaurav1086@gmail.com> Organization: Red Hat Inc. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 11 Jun 2020 20:36:40 -0400 Gaurav Singh wrote: > Replace malloc/memset with calloc > > Fixes: 0fca931a6f21 ("samples/bpf: program demonstrating access to xdp_rxq_info") > Signed-off-by: Gaurav Singh Above is the correct use of Fixes + Signed-off-by. Now you need to update/improve the description, to also mention/describe that this also solves the bug you found. -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer