Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp250997ybg; Fri, 12 Jun 2020 00:02:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyCCZ+lhcgFusZlhnltGmsdYG9ZO8V0xpTA555G7A1goER+4v5/bD+ecel2xd+jD0tp4BJK X-Received: by 2002:a05:6402:3092:: with SMTP id de18mr10757518edb.367.1591945353713; Fri, 12 Jun 2020 00:02:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591945353; cv=none; d=google.com; s=arc-20160816; b=N5gmWb0hMdwy4ak+xkRQB2EOLmpyMHG2nPJQe9L6EJcP9MAAwo0ufneuZUajvKpB9A N778wLXraejkkCg3eFJIIskES44fVhM3q7Q5itAJ+MTm5a84Pw+FkkrCa9/oUKD/iCEn VJwL0F1Yv2YMXUAexfHsgewKaLmNQ0YNzssV0cesFek66DlSoD6TqMD+uNQmAp/aXDnO +1Owa5fV1PIn7nxPpgCio9XFT6IJxGnB7tF5CnFDtOwzkO8q2MwTjuSN6ROTC38rxNHv g3AaTd2gnBXYEgPo63HxLFnCPyH9NcjKTwCl5OKwEsJl51F5/NwljrzstmzJ0mM9k+NS vpJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=hbBTPedvojIPOHUOPrzkvqJhdMTFZotSf6yPfyzcSVc=; b=WkwkPUXG72TY1HCa1AGT1DQAZDyGFAZjacBrlGf7GZrOgx80IEdvP3zATd5hYXTzCb SwwxsmAyFs33rF+tZa0PQi9OLxCp/ehOV7K8EDfE8PvuO0gJECLCoeXdNmpLJlDlsnw6 dixMIuzY/T8uF8GhJfClVJ+V+LIpFaA5HBawpbPzp3I8ROmedMLrc6432qv1RvJesP/U NF923fRMYB8sFUuFxRshd/Ki4Wj1XqK4e9P27Tw2u20wz2YisxlNhhqcmgmyBD6prxYQ bUQj3XZ7YuiXftzahbm1hZUYNK9dkyuU9xzfmzX0v07nqwuOecRQvIu6PtXiR7xLd0B1 tX0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=VEv60SuR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h18si3482761ejf.537.2020.06.12.00.02.11; Fri, 12 Jun 2020 00:02:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=VEv60SuR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726401AbgFLG6Q (ORCPT + 99 others); Fri, 12 Jun 2020 02:58:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726287AbgFLG6P (ORCPT ); Fri, 12 Jun 2020 02:58:15 -0400 Received: from mail-pl1-x644.google.com (mail-pl1-x644.google.com [IPv6:2607:f8b0:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5ABE0C08C5C2 for ; Thu, 11 Jun 2020 23:58:14 -0700 (PDT) Received: by mail-pl1-x644.google.com with SMTP id j4so121775plk.3 for ; Thu, 11 Jun 2020 23:58:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=hbBTPedvojIPOHUOPrzkvqJhdMTFZotSf6yPfyzcSVc=; b=VEv60SuR1xOiTK9xkgyJTKlyILo0gJSwdIeMlGuiTetR5wFnYj6YsL3yI5plGAsZg/ OMWGwHmJ43PaYQmc4gd+GLuzIVpWUsVLdppG1kCQK4jIBzjwWXGw0RM5BZd3bMh5g6Op 5zaycbbMBN8Yc9oPnkdOTIpZ4v5cFWgsPof1Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hbBTPedvojIPOHUOPrzkvqJhdMTFZotSf6yPfyzcSVc=; b=J/4Z/C+kHNKThkJAbRzqRDAxmJm4oNfYLmXJjlaw0TqpGcXheV5Jl7fqe8RxrKrdau zv73bhE/NTnKOyL+Tww91t9pVMN412ZqdekZgNm4gHPX7UrS7rGuhgY69owwYUocpijw 6cIVdJeXEzebmzqpVJHj9/hh9aerx7Nfa/jMJbNa5hJE50RjZSVlmUGv4WLItc1qpGKd Wy2fto2Aok8dCFJ9xG3r5aiKxgISO0eO1E2+SZLWnx2e57zMqYi8L6r7J9YuoyVWke/e o+EUl8HspaM+LeURhxVWJtFa0GSGP9Lj6WQ7qMPbCpfBOkq0alSXRM1at26nJm7FpIT5 f9Pg== X-Gm-Message-State: AOAM532bb4lO5HfaWSSBCvUdyX0nMl8kvEPNpUbzYAqf+pqrJpUsqGkc 5rHX730hftSpOyNzCM1ETGRf3g== X-Received: by 2002:a17:902:23:: with SMTP id 32mr10294486pla.40.1591945093613; Thu, 11 Jun 2020 23:58:13 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id t201sm5206590pfc.104.2020.06.11.23.58.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2020 23:58:12 -0700 (PDT) Date: Thu, 11 Jun 2020 23:58:11 -0700 From: Kees Cook To: David Laight Cc: 'Sargun Dhillon' , Christian Brauner , "containers@lists.linux-foundation.org" , Giuseppe Scrivano , Robert Sesek , Chris Palmer , Jann Horn , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , Matt Denton , "linux-fsdevel@vger.kernel.org" , Tejun Heo , Al Viro , "cgroups@vger.kernel.org" , "stable@vger.kernel.org" , "David S . Miller" Subject: Re: [PATCH v3 1/4] fs, net: Standardize on file_receive helper to move fds across processes Message-ID: <202006112355.932D0AD@keescook> References: <20200609200346.3fthqgfyw3bxat6l@wittgenstein> <202006091346.66B79E07@keescook> <037A305F-B3F8-4CFA-B9F8-CD4C9EF9090B@ubuntu.com> <202006092227.D2D0E1F8F@keescook> <20200610081237.GA23425@ircssh-2.c.rugged-nimbus-611.internal> <202006101953.899EFB53@keescook> <20200611100114.awdjswsd7fdm2uzr@wittgenstein> <20200611110630.GB30103@ircssh-2.c.rugged-nimbus-611.internal> <067f494d55c14753a31657f958cb0a6e@AcuMS.aculab.com> <202006111634.8237E6A5C6@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202006111634.8237E6A5C6@keescook> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 11, 2020 at 04:49:37PM -0700, Kees Cook wrote: > I think I prefer the last one. Here's where I am with things: https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/log/?h=devel/seccomp/addfd/v3.3 If we can agree on the ioctl numbering solution, I can actually send the series for email review... -- Kees Cook