Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp317403ybg; Fri, 12 Jun 2020 02:17:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwO7cU7t5rO28KJ7lyi8nSpoAH3SN13KAJHFZc7T+g+085HxX+nP5cuUsgvDKfWsTvuAvVk X-Received: by 2002:a17:907:20db:: with SMTP id qq27mr12021610ejb.232.1591953444813; Fri, 12 Jun 2020 02:17:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591953444; cv=none; d=google.com; s=arc-20160816; b=i6XujOLUrGdns6wyLQfmDBSOm/d7VCFTj36v0TzH4wQhj3cTCmW5o8O321tuz+UkGH RL8dRSSD+ppx/H+oXjqxrfZnq9ELYWGutHhaOUBfXqDxaVrxvRKW6QJ+NgEmCqroB/n1 DJ91ribNRwpM+tsLttCSepFgvlgqL76Oe25hLHXclpTyXCfz8VavMM82ZVvbULTKCAK3 H11XiQ6SeFzxONPUKT3zuipfY9yA7Ytr5D1nVBCs5LtU4knnnpSLg4jCsYUSM79NObo+ unkmFi7xjKCIEUnf1yeHJ0JqziIYaSr53hZVOsZW57yU8BOvXu3t4ZNWGNW/Ui38bLj7 cWzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=RpN5eACb/MREgqVtfF2TDCIX2Q4IHEDnudj9PV0NnxY=; b=koLE0y98n1NDc5kdu14G9jh/Vy0QsZbyqiqdIrrvhjsx/aZm4E139vN2jI3i8nOZz7 YRKQTSWewY25C0dEmtRcfwoPDfgy8s4IDBf+ZCRFMp14ePVI8q01LDusQegyKPjaqF7Q zktPjh428RoJKBPfJEC06ybjVaXMiv9/O9xLm1e/XKwupmC8YJlBoR4DH7NmShhCYV/l RzDVfYrdAKpx11b3VYKUXzcL1XmmWrZAg/1Q4fIrl61hVNaSDkEAQ+K9yQ8LCJabK/XI FH9nFwuCvWJuNUInR2m0mKJKZo861fnLRsYi1Bviry5RbazQsRCCBdg1OE2KOgdG9saS Lokw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i24si3050985edb.577.2020.06.12.02.17.02; Fri, 12 Jun 2020 02:17:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726543AbgFLJMR (ORCPT + 99 others); Fri, 12 Jun 2020 05:12:17 -0400 Received: from 8bytes.org ([81.169.241.247]:47472 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726302AbgFLJMR (ORCPT ); Fri, 12 Jun 2020 05:12:17 -0400 Received: by theia.8bytes.org (Postfix, from userid 1000) id 845443AA; Fri, 12 Jun 2020 11:12:14 +0200 (CEST) Date: Fri, 12 Jun 2020 11:12:11 +0200 From: Joerg Roedel To: x86@kernel.org Cc: hpa@zytor.com, Andy Lutomirski , Dave Hansen , Peter Zijlstra , Thomas Hellstrom , Jiri Slaby , Dan Williams , Tom Lendacky , Juergen Gross , Kees Cook , David Rientjes , Cfir Cohen , Erdem Aktas , Masami Hiramatsu , Mike Stunes , Joerg Roedel , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH v3 64/75] x86/sev-es: Cache CPUID results for improved performance Message-ID: <20200612091210.GA3701@8bytes.org> References: <20200428151725.31091-1-joro@8bytes.org> <20200428151725.31091-65-joro@8bytes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200428151725.31091-65-joro@8bytes.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 28, 2020 at 05:17:14PM +0200, Joerg Roedel wrote: > From: Mike Stunes > > To avoid a future VMEXIT for a subsequent CPUID function, cache the > results returned by CPUID into an xarray. > > [tl: coding standard changes, register zero extension] > > Signed-off-by: Mike Stunes > Signed-off-by: Tom Lendacky > [ jroedel@suse.de: - Wrapped cache handling into vc_handle_cpuid_cached() > - Used lower_32_bits() where applicable > - Moved cache_index out of struct es_em_ctxt ] > Co-developed-by: Joerg Roedel > Signed-off-by: Joerg Roedel > --- > arch/x86/kernel/sev-es-shared.c | 12 ++-- > arch/x86/kernel/sev-es.c | 119 +++++++++++++++++++++++++++++++- > 2 files changed, 124 insertions(+), 7 deletions(-) Okay, following the discussion, I am dropping this patch for now. We can revisit CPUID caching later when we have a better justification. Regards, Joerg