Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp324402ybg; Fri, 12 Jun 2020 02:31:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzNetZexJ5HFr4iSkrVqQOIAOGGPLbZG0gp/1MoNJlR2e5UcP4gQ1fh+4ZyWz9WT0FPORMX X-Received: by 2002:aa7:d5c7:: with SMTP id d7mr10954963eds.11.1591954267471; Fri, 12 Jun 2020 02:31:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591954267; cv=none; d=google.com; s=arc-20160816; b=ZgdEDc0OgBJy2WEmBV/unMtMmVjmKah/vFG0IXCOc0D4aAD5qlVH6RKaDdZxVzUB2v tKLA7jH0h7cI9zi5HBihJWyZ0eL7VdMxmpHo4p6W5jITwzc4+NawuA2b7Q1Xsjzqx/Pe H+7iHTpxubVlRtmkdZ+ZBoO48PDX+Of3389saHQfQ0mgYuvfDQ7Hlv5frmsXJfEq47Px wbfWEC/OStLq7vda9Ot3HcjUWDQOvL2PB6bbhVaoX0+MwrXeassy+Nbf3WKtfd2J47X/ anzSOUoaGEehDoGJN+BqS+Ymss/CJ4AQ7rqxWPSqGSkSnH0f6uaIupWj8OYk45NAqs99 e/zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from; bh=CrpgYVtr+uwUEdX4ixlinqBGJ+ZBCK/F8jNSPSTJ/po=; b=jkVjuZaDQe/3U8XMWPCSMhkS2oUodbW6guXKLo+DoXY+Hzj5Yl6V5Nd3dsnjE81kIu RSJ6RJDWOe7X4JJczHv4oXR1jisAdN5BMlFDDik2SR3GsbvEjXK6lGshf7dK1eY8JN7Z DvUgptvZ7TqNMDU3Zs/ughohR0TCw8dgvycFTY0odY3QqUA0txOGNa+j/cuIzUvXPL2I GmMHq1carD3f3DS48HXqcgeYKM0JuXbVWilt69V6db7HK9anoFYzQtOLxW5CVMfSjWYW bpCZhRxTYd0bL1aV7xH9oBJZvXyfT7VYBU+cwsZxFtMYmdGqphWuMp0g6QkhL9bEi6fb n8Qg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w11si3076009ede.55.2020.06.12.02.30.44; Fri, 12 Jun 2020 02:31:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726448AbgFLJ1j (ORCPT + 99 others); Fri, 12 Jun 2020 05:27:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726335AbgFLJ1i (ORCPT ); Fri, 12 Jun 2020 05:27:38 -0400 Received: from Galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC9BCC03E96F; Fri, 12 Jun 2020 02:27:38 -0700 (PDT) Received: from p5de0bf0b.dip0.t-ipconnect.de ([93.224.191.11] helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1jjfy6-0000uH-JW; Fri, 12 Jun 2020 11:27:22 +0200 Received: by nanos.tec.linutronix.de (Postfix, from userid 1000) id 06D73100F5A; Fri, 12 Jun 2020 11:27:22 +0200 (CEST) From: Thomas Gleixner To: paulmck@kernel.org, linux-kernel@vger.kernel.org, rcu@vger.kernel.org Cc: luto@kernel.org, x86@kernel.org, frederic@kernel.org, rostedt@goodmis.org, joel@joelfernandes.org, mathieu.desnoyers@efficios.com, will@kernel.org, peterz@infradead.org Subject: Re: [PATCH RFC] x86/entry: Ask RCU if it needs rcu_irq_{enter,exit}() In-Reply-To: <20200611235305.GA32342@paulmck-ThinkPad-P72> References: <20200611235305.GA32342@paulmck-ThinkPad-P72> Date: Fri, 12 Jun 2020 11:27:21 +0200 Message-ID: <87ftb0d47a.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "Paul E. McKenney" writes: > +static __always_inline bool rcu_needs_irq_enter(void) > +{ > + return !IS_ENABLED(CONFIG_TINY_RCU) && > + (context_tracking_enabled_cpu(smp_processor_id()) || is_idle_task(current)); This reintroduces the #PF problem which started the whole conditional RCU entry discussion: https://lore.kernel.org/lkml/20200515235125.628629605@linutronix.de/ and which made us all come to the conclusion that we can do it always conditional. No biscuit for you. :) Thanks, tglx