Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp359895ybg; Fri, 12 Jun 2020 03:33:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxzqJIsKdHLMhclCFEfs6/aLAKJ+WNCrbyRKh0DqZtouHBb1OZvnZAAaegNWMYtskxA3rjZ X-Received: by 2002:a50:b022:: with SMTP id i31mr11208776edd.301.1591957993358; Fri, 12 Jun 2020 03:33:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591957993; cv=none; d=google.com; s=arc-20160816; b=zf5DLzbqmcuOw9XIE3swfvlHp1vjLXnw+NBc5EwjuHnZES58oAxonnpjA1BZbZY3zF t/Qs77GR/KCA9yEukqHvmxk5mTzGH8UZN2S4O+UuY+7mWMeMAFEdbit2EBolPIC42PpU NiTX0ylTno5GJK1U29l58YM39vzwjYxRd5yduWR4/jf3i9FytEsVR10K+vtlBI/zhu7X K1roPE/Zenrc9bJwBO4YiP6gbjOBho/DjMXoD1TVs8EIxsfrSeEbWtobxgXW2AEPiOGi azP4JdB2ZG42jciSm/vdQ4Z0eigyJnqe5QSBv3PQYyGdSBsrMTKYw7jNx6oA3T4KgHgN qnnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:organization:user-agent :message-id:subject:cc:to:from:date:ironport-sdr:ironport-sdr; bh=7OtXoSpdiImGYfjc0/8VGi/qBTdCOAlWC27mtIn5ddk=; b=0xPOLllQsWPktYcJvHdhn9AceCCk0R0oBIzmqN7ULB1SdbPyubQYV+YwVKiJMr3/eY 03iWmGp5764AXRV81NZU0psQn0Uw8ett10pe/Fu09UwgoP1X/bQ7Akv9I+tA/6qxmqNw sFQFExs+PEXCoHYH5CUhJTAzeyAt0lWCmtfW4LbwjziNxD1vja2WSf366cmx91qT0viP QwKNV5E/2detzBHw4KWyW2GRdODP0eZoElkng/iEe4hcnxMLBsx//ZXFTqcatlcLvM1q rb5mP4yYYU4DudrgTpftGYk4s1gna/9bxgw3XlmHPqn9B80c5ofGP7Ham0gSZjz6XrAf qs/g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id do11si5071271ejc.450.2020.06.12.03.32.50; Fri, 12 Jun 2020 03:33:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726277AbgFLKaS (ORCPT + 99 others); Fri, 12 Jun 2020 06:30:18 -0400 Received: from mga18.intel.com ([134.134.136.126]:17570 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725805AbgFLKaN (ORCPT ); Fri, 12 Jun 2020 06:30:13 -0400 IronPort-SDR: MLYq0/+hhbKCmc57Svh3BZyGYCNkqPrU3M/fewo21KCc12LjCojxbIaphjRp3OBGqELj9nqSX1 tQjDjkz/Xghw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2020 03:30:05 -0700 IronPort-SDR: FB7TDU6toUsBW8rgmmhkVAjuNlzXccIiopAQ9bo5sN9VfuAVt0LvcsBhAlbL8R29lkBq7UN9Vh fvLdMhYVQ04Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,502,1583222400"; d="scan'208";a="419425987" Received: from eliteleevi.tm.intel.com ([10.237.54.20]) by orsmga004.jf.intel.com with ESMTP; 12 Jun 2020 03:30:00 -0700 Date: Fri, 12 Jun 2020 13:29:52 +0300 (EEST) From: Kai Vehmanen X-X-Sender: kvehmane@eliteleevi.tm.intel.com To: Brent Lu cc: alsa-devel@alsa-project.org, Pierre-Louis Bossart , Liam Girdwood , Ranjani Sridharan , Kai Vehmanen , Daniel Baluta , Mark Brown , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Zhu Yingjiang , Keyon Jie , Bard Liao , sound-open-firmware@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ASoC: SOF: Intel: hda: unsolicited RIRB response Message-ID: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7 02160 Espoo MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Brent, On Fri, 12 Jun 2020, Brent Lu wrote: > Port commit 6d011d5057ff ("ALSA: hda: Clear RIRB status before reading > WP") from legacy HDA driver to fix the get response timeout issue. > Current SOF driver does not suffer from this issue because sync write > is enabled in hda_init. The issue will come back if the sync write is > disabled for some reason. better to align the logic, so I'm ok to take this patch to SOF. Can you fix the summary though: - ASoC: SOF: Intel: hda: unsolicited RIRB response + ASoC: SOF: Intel: hda: Clear RIRB status before reading WP Br, Kai