Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp429473ybg; Fri, 12 Jun 2020 05:27:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJypVUtajctrIFiULrL91vTXmUPlQiwpb6St8+xjK3NL2MhuL81MMys5tFjX+zFJJ5cZQ7lF X-Received: by 2002:a17:906:7693:: with SMTP id o19mr12269394ejm.295.1591964822805; Fri, 12 Jun 2020 05:27:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591964822; cv=none; d=google.com; s=arc-20160816; b=s2eGQlnikYq8BS9hb5GK2ULyiSA4U1ePpxmJ0nxMmzH/khv5K0KYRspz4J/FFkJ4V8 bgpRrfU2GXGyEg28xxZ1PMnBuzo9Vy+WJVjRp+cYtd8mXaZmSfTk4aCtxWANs2q0ZEo1 1ZEksv+MKDwzHrbe1hC0gWotVaW/GXQGPMRu+HegVTSD5D1f4IoFYQEmQmss8jY2h1zZ MoI7a9i8HtIKC02bp8/nkq58IyJ9zffZC8aq0Ihj1X7/cz+b7/jn2yi2PzzBdfV5MHjI JQ+pubOLBgm94d/ojLj5IYIm2koKIndiCjA0IzTcjbXjU/LcYMRGOqjfo8yW04emVvC/ zHMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:organization:user-agent :references:message-id:in-reply-to:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=Ebfv5AdIOpoHbW59qOxA/g2t7mvsh+XZ9GG+ayc7aT4=; b=sSk2h/gzx0oU/TjRb+41S18gLZfvodGyNFyRM3DRJpIRlrXfrYAUewqhF+ZcU+QmN8 zBoMQDVwmMgKS6xlpUV9VhFRbxAERzyEAeGx5eunI730Qt/LxWtMaNkpnfQtyHlijXUA DDGlaL1IVllEE1R6c3WwXCvzIlOzc2b4GeLVDivc5iq7rhM4BQuLiZxPEiSfNw+tJLpx oYfnsKreUUdQNz5SlHWbq5tzsT9M1wtIqxkuxPUtIL8j1sIgyItUW0onOFiNCcx/v26x TkETp3yrHz0ii/iXT2kAAK2LWDc06vCivL6SYEnoW9eNkuwAjvYn+pbm/qoFgroNKoCO y4jA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v1si3531651edx.37.2020.06.12.05.26.38; Fri, 12 Jun 2020 05:27:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726089AbgFLMY2 (ORCPT + 99 others); Fri, 12 Jun 2020 08:24:28 -0400 Received: from mga02.intel.com ([134.134.136.20]:23212 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725791AbgFLMY2 (ORCPT ); Fri, 12 Jun 2020 08:24:28 -0400 IronPort-SDR: v+jp0xi13MbRaSj7evNFcoCNK1OTY+lkL2v3GLQmEWr0HfTH8isk3E0iwm+6KQxoOpBfaIpkl+ KLDotSibqMhA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2020 05:24:28 -0700 IronPort-SDR: edLFrEi3NxAR9f/XA/1Zqf2TSrMrqLLxGG9+oW3Pj01oUUVl1GpOl4VEm+mPHVW72NRVd1LsNk +Q7rY9jBsIyw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,503,1583222400"; d="scan'208";a="448284655" Received: from eliteleevi.tm.intel.com ([10.237.54.20]) by orsmga005.jf.intel.com with ESMTP; 12 Jun 2020 05:24:24 -0700 Date: Fri, 12 Jun 2020 15:24:16 +0300 (EEST) From: Kai Vehmanen X-X-Sender: kvehmane@eliteleevi.tm.intel.com To: Takashi Iwai cc: Brent Lu , alsa-devel@alsa-project.org, Pierre-Louis Bossart , Liam Girdwood , Ranjani Sridharan , Kai Vehmanen , Daniel Baluta , Mark Brown , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Zhu Yingjiang , Keyon Jie , Bard Liao , sound-open-firmware@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] ASoC: SOF: Intel: hda: Clear RIRB status before reading WP In-Reply-To: Message-ID: References: <1591959048-15813-1-git-send-email-brent.lu@intel.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7 02160 Espoo MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey Brent, On Fri, 12 Jun 2020, Takashi Iwai wrote: > On Fri, 12 Jun 2020 12:50:48 +0200, Brent Lu wrote: > > > > Port commit 6d011d5057ff ("ALSA: hda: Clear RIRB status before reading > > WP") from legacy HDA driver to fix the get response timeout issue. > > Current SOF driver does not suffer from this issue because sync write > > is enabled in hda_init. The issue will come back if the sync write is > > disabled for some reason. > > > > Signed-off-by: Brent Lu > > Reviewed-by: Takashi Iwai thanks, looks good now: Reviewed-by: Kai Vehmanen