Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp444374ybg; Fri, 12 Jun 2020 05:51:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzN04UEOqv7QQM6UjQwWGlZU4AFF66Go9eO8D2wrP3l0SqvqWHDgap3ZZem6sItvw9tlHpK X-Received: by 2002:a17:906:81cc:: with SMTP id e12mr13637847ejx.67.1591966278442; Fri, 12 Jun 2020 05:51:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591966278; cv=none; d=google.com; s=arc-20160816; b=iGlDezmo4qtIa8/pEqss9LS/lX0WyXxEkLIb9ov0oSxUyziKZKLRSBYZw7KEhIXhZV VwZHCSsmIilXHdSOC4z2CjUbduRKfd8T0lMVZyAsWM1sy2kNP5tJIiEvaQ5vXkjjH3+F s9RnJo4pqdt8mfqng53dwLRXKBQf4kc2IwOXSMyvyVLJ4NWwdYYB2BlSd7g3nQNsx/gB 9yrePCCtgvZKmvc3aRBUsJZiqbH9fst1JAD3ih6IrUWu3CaFxvl7aAF9aKmIBxlvGy7i jvEXTNrU0gEXCAs2JawaW6vG4LYjr8LIneWIlHLCXjISWrxsMD9wznAuhpPB2gkdxWUC N47Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Lll4LpnQqg/40/ft9cpEpXMU5ki3jbo1fNK2cyJ90CI=; b=Sy+u9zr6/hk00VdcYds3k1ukqVOp1dY4JmLO7IwCSgsOMLnfU2LsLIcRdP/lgDvKhH HcbFiiV9GgRGYOxhAcHbEMYJDWaJk9SnL9tUzxHwTZEOg0RS7v1vJHiXlBN9FUpkW2mO s19MJhb0THtktYie+wez11Oe1J4C4jbcb+RYJfXVKDb+K2/VdD+yYeogaPttCqla94O9 n9bWlzzKSk/yL0lryQS5HFS++zF1DxqS73+OeoRyV+4dsjp4nTXYF5/L9Sl/HBHQWU5f xCaSLly8gplv15WuL53pVWPS+T2lox/AeQwHeP1sHlbbTKw9mLnJIPksOIdnS8K/OYYC 1awg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@sang-engineering.com header.s=k1 header.b=E6VGAcVj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e2si3411150edv.101.2020.06.12.05.50.55; Fri, 12 Jun 2020 05:51:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@sang-engineering.com header.s=k1 header.b=E6VGAcVj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726278AbgFLMtG (ORCPT + 99 others); Fri, 12 Jun 2020 08:49:06 -0400 Received: from www.zeus03.de ([194.117.254.33]:35496 "EHLO mail.zeus03.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726089AbgFLMtG (ORCPT ); Fri, 12 Jun 2020 08:49:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; s=k1; bh=LHqHHlSRkMeun3OMl7GCaw/Jhst 3kMW958QRIBoAimc=; b=E6VGAcVjCTZfHOYZdDcB2jZtt66FmKKy1D0Tu0uJBFw wgleUmX1Q8b02fh8arFowu7umeCaWSNAmtyxewMLwGNiY+0iC9IBxk8M96rVes6P fElxd8Wx+mSFIs66+0bgNb1rUBxQEonMTM+bw6ORRChG80ccIZV2BJn+CD+qwO6A = Received: (qmail 230824 invoked from network); 12 Jun 2020 14:49:03 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 12 Jun 2020 14:49:03 +0200 X-UD-Smtp-Session: l3s3148p1@IEB/gOKnIOEgAwDPXwbpAGeWwLnioHPK From: Wolfram Sang To: linux-kernel@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, Krzysztof Kozlowski , Oleksij Rempel , Marc Kleine-Budde , Thomas Gleixner , Wolfram Sang Subject: [PATCH] lib: update DEBUG_SHIRQ docs to match reality Date: Fri, 12 Jun 2020 14:48:44 +0200 Message-Id: <20200612124844.19422-1-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is no extra interrupt when registering a shared interrupt handler since 2011. Update the Kconfig text to make it clear and to avoid wrong assumptions when debugging issues found by it. Fixes: 6d83f94db95c ("genirq: Disable the SHIRQ_DEBUG call in request_threaded_irq for now") Link: https://lore.kernel.org/linux-i2c/859e8211-2c56-8dd5-d6fb-33e4358e4128@pengutronix.de/T/#mf24d7070d7e0c8f17b6be6ceb51df94b7d7613b3 Signed-off-by: Wolfram Sang --- I'd think this could go in via one of tglx' trees? lib/Kconfig.debug | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index ef675beccab1..50522d3a7770 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -845,10 +845,10 @@ config DEBUG_SHIRQ bool "Debug shared IRQ handlers" depends on DEBUG_KERNEL help - Enable this to generate a spurious interrupt as soon as a shared - interrupt handler is registered, and just before one is deregistered. - Drivers ought to be able to handle interrupts coming in at those - points; some don't and need to be caught. + Enable this to generate a spurious interrupt just before a shared + interrupt handler is deregistered (generating one when registering + is currently disabled). Drivers need to handle this correctly. Some + don't and need to be caught. menu "Debug Oops, Lockups and Hangs" -- 2.20.1