Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: Xl4wIJOotmnv+mePScFlOIvmkV/tpRdiaG1iXKyvcON0B0VUBWK48aSg14iuAzOEmnQnyJx2yx
 hGRRbyiCYbFw==
IronPort-SDR: qbMMbC3vf1k45oMKqRqK8eRrYVgDJdMebeYGvLUSX5uo04mv8WSH1rUkKUqF6zrOAMAuZZuVnc
 5iGrelD9ButQ==
Date:   Fri, 12 Jun 2020 16:18:22 +0300
From:   Andy Shevchenko <andriy.shevchenko@intel.com>
To:     "Ramuthevar,Vadivel MuruganX" 
        <vadivel.muruganx.ramuthevar@linux.intel.com>
Cc:     linux-kernel@vger.kernel.org, balbi@kernel.org, robh@kernel.org,
        p.zabel@pengutronix.de, gregkh@linuxfoundation.org,
        devicetree@vger.kernel.org, linux-usb@vger.kernel.org,
        cheol.yong.kim@intel.com, qi-ming.wu@intel.com, yin1.li@intel.com
Subject: Re: [PATCH v3 2/2] usb: phy: Add USB3 PHY support for Intel LGM SoC
Message-ID: <20200612131822.GG2428291@smile.fi.intel.com>
References: <20200612025941.5484-1-vadivel.muruganx.ramuthevar@linux.intel.com>
 <20200612025941.5484-3-vadivel.muruganx.ramuthevar@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200612025941.5484-3-vadivel.muruganx.ramuthevar@linux.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jun 12, 2020 at 10:59:41AM +0800, Ramuthevar,Vadivel MuruganX wrote:
> From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
> 
> Add support for USB PHY on Intel LGM SoC.

Thank you for an update, looks pretty much good, my comments below.

...

> +static int get_flipped(struct tca_apb *ta, bool *flipped)
> +{
> +	union extcon_property_value property;
> +	int ret;
> +
> +	ret = extcon_get_property(ta->phy.edev, EXTCON_USB_HOST,
> +				  EXTCON_PROP_USB_TYPEC_POLARITY, &property);
> +	if (ret) {

> +		dev_err(ta->phy.dev, "no polarity property from extcon\n");

(1)

> +		return ret;
> +	}
> +
> +	*flipped = property.intval;
> +
> +	return ret;
> +}

...

> +	ret = get_flipped(ta, &flipped);
> +	if (ret)
> +		dev_err(ta->phy.dev, "no polarity property from extcon\n");

You already has a message in (1). You should decide which one to leave.

But note, if it's a fatal error, you have to return here, otherwise, if you
decide to leave message here, it should be not on error level.

> +	connected = extcon_get_state(ta->phy.edev, EXTCON_USB_HOST);
> +	if (connected == ta->connected)
> +		return;
> +
> +	ta->connected = connected;
> +	if (connected) {
> +		val = TCPC_VALID | FIELD_PREP(TCPC_MUX_CTL, MUX_USB);
> +		if (flipped)
> +			val |= TCPC_FLIPPED;
> +		dev_info(ta->phy.dev, "connected%s\n", flipped ? " flipped" : "");
> +	} else {
> +		val = TCPC_DISCONN;
> +		dev_info(ta->phy.dev, "disconnected\n");
> +	}
> +
> +	writel(val, ta->phy.io_priv + TCPC_OFFSET);
> +

> +	if (ta->phy.set_vbus(&ta->phy, connected))
> +		dev_err(ta->phy.dev, "failed to set VBUS\n");

Please, split it to
	ret = ...;
	if (ret)

> +}

...

> +static int vbus_notifier(struct notifier_block *nb,
> +			 unsigned long event, void *ptr)

Consider to put it on one line (you can also shrink the names of unused
parameters.

> +{
> +	return NOTIFY_DONE;
> +}

-- 
With Best Regards,
Andy Shevchenko